* [dpdk-stable] [PATCH 2/3] net/qede: fix to modify MTU update flow
[not found] <20191020052051.9905-1-rmody@marvell.com>
@ 2019-10-20 5:20 ` Rasesh Mody
2019-10-20 5:20 ` [dpdk-stable] [PATCH 3/3] net/qede: fix to set VLAN strip mode Rasesh Mody
1 sibling, 0 replies; 2+ messages in thread
From: Rasesh Mody @ 2019-10-20 5:20 UTC (permalink / raw)
To: dev, jerinj, ferruh.yigit; +Cc: Shahed Shaikh, GR-Everest-DPDK-Dev, stable
From: Shahed Shaikh <shshaikh@marvell.com>
New MTU value is not propagated to vport in HW when MTU update request
is sent while ports are stopped.
This patch fixes the logic error for above mentioned condition.
Fixes: d121a6b5f781 ("net/qede: fix VF MTU update")
Cc: stable@dpdk.org
Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>
Reviewed-by: Rasesh Mody <rmody@marvell.com>
---
drivers/net/qede/qede_ethdev.c | 8 +++++---
drivers/net/qede/qede_ethdev.h | 1 +
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 53fdfde9a..42e2b5083 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -1038,9 +1038,11 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev)
PMD_INIT_FUNC_TRACE(edev);
/* Update MTU only if it has changed */
- if (eth_dev->data->mtu != qdev->mtu) {
- if (qede_update_mtu(eth_dev, qdev->mtu))
+ if (qdev->new_mtu && qdev->new_mtu != qdev->mtu) {
+ if (qede_update_mtu(eth_dev, qdev->new_mtu))
goto err;
+ qdev->mtu = qdev->new_mtu;
+ qdev->new_mtu = 0;
}
/* Configure TPA parameters */
@@ -2248,7 +2250,7 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)
restart = true;
}
rte_delay_ms(1000);
- qdev->mtu = mtu;
+ qdev->new_mtu = mtu;
/* Fix up RX buf size for all queues of the port */
for (i = 0; i < qdev->num_rx_queues; i++) {
diff --git a/drivers/net/qede/qede_ethdev.h b/drivers/net/qede/qede_ethdev.h
index 21115a077..b988a73f2 100644
--- a/drivers/net/qede/qede_ethdev.h
+++ b/drivers/net/qede/qede_ethdev.h
@@ -225,6 +225,7 @@ struct qede_dev {
struct qede_fastpath *fp_array;
struct qede_fastpath_cmt *fp_array_cmt;
uint16_t mtu;
+ uint16_t new_mtu;
bool enable_tx_switching;
bool rss_enable;
struct rte_eth_rss_conf rss_conf;
--
2.18.0
^ permalink raw reply [flat|nested] 2+ messages in thread* [dpdk-stable] [PATCH 3/3] net/qede: fix to set VLAN strip mode
[not found] <20191020052051.9905-1-rmody@marvell.com>
2019-10-20 5:20 ` [dpdk-stable] [PATCH 2/3] net/qede: fix to modify MTU update flow Rasesh Mody
@ 2019-10-20 5:20 ` Rasesh Mody
1 sibling, 0 replies; 2+ messages in thread
From: Rasesh Mody @ 2019-10-20 5:20 UTC (permalink / raw)
To: dev, jerinj, ferruh.yigit; +Cc: Shahed Shaikh, GR-Everest-DPDK-Dev, stable
From: Shahed Shaikh <shshaikh@marvell.com>
Commit 9a6d30ae6d46 ("net/qede: refactoring vport handling code")
deleted the code as part of refactoring which sets vlan strip mode.
Revert it back and fix vlan strip feature.
Fixes: 9a6d30ae6d46 ("net/qede: refactoring vport handling code")
Cc: stable@dpdk.org
Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>
Reviewed-by: Rasesh Mody <rmody@marvell.com>
---
drivers/net/qede/qede_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 42e2b5083..575982fd0 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -833,6 +833,8 @@ static int qede_vlan_stripping(struct rte_eth_dev *eth_dev, bool flg)
}
}
+ qdev->vlan_strip_flg = flg;
+
DP_INFO(edev, "VLAN stripping %s\n", flg ? "enabled" : "disabled");
return 0;
}
--
2.18.0
^ permalink raw reply [flat|nested] 2+ messages in thread