From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46244A320B for ; Mon, 21 Oct 2019 13:16:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1E0EC1BEA0; Mon, 21 Oct 2019 13:16:38 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 4FD881BEA0 for ; Mon, 21 Oct 2019 13:16:37 +0200 (CEST) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iMVfx-0006Ac-0z; Mon, 21 Oct 2019 11:16:37 +0000 From: Christian Ehrhardt To: Luca Boccassi , dpdk stable Cc: Thomas Monjalon , Christian Ehrhardt Date: Mon, 21 Oct 2019 13:16:31 +0200 Message-Id: <20191021111634.15500-1-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] [PATCH 0/3] kni: fix kernel 5.4 builds X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, I've got a report [1] from our kernel Team which regularly pre-checks new kernels ahead of time. All of this is about kni/ethtool failing to build with 5.4. I know that going forward there is [2] so the master branch doesn't care anymore. To be clear, Thomas was rather straight on this topic on IRC :-) [11:18] cpaelzer: Drop KNI ethtool from your package! [11:20] That's a lot easier than maintaining this... thing [11:31] tmonjalo: that is true and correct for the future, which also reflects what happened in master branch [11:31] tmonjalo: but the past is the past and I guess I need to fix it there [11:34] cpaelzer: there is another way: drop it and wait for requests ;) [11:35] I'm not bold enough to do that [11:35] but I already have it in the not officially supported packages [11:35] so I can worst case just stop caring, but then I like to fix things ... But I wondered if we should keep it a bit alive at least for a while for Distributions that carry it as package. Personally for Ubuntu that would be around the time of whatever kernel is recent April next year and valid for DPDK 17.11 and 18.11. But needs surely will differ for different distributions. Here is a patch series intended for stable releases only, tested with kernel 5.3 (old behavior) and 5.4 (new behavior). We might want to have someone test other distros and other (older) kernels as well maybe? I'm throwing in the patch series as suggestion for a fix, but it might as well be just the start for a discussion to document the projects thoughts about released e.g. 17.11.x/18.11.x versions carrying that package and how they are suggested to handle kni-ethtool being sort of unmaintainable. I'll surely start that discussion with Luca for the Debian/Ubuntu scope. [1]: https://bugs.launchpad.net/ubuntu/eoan/+source/dpdk/+bug/1848585 [2]: https://git.dpdk.org/dpdk/commit/?id=ea6b39b5 Christian Ehrhardt (3): kni: fix kernel 5.4 build - merged pci_aspm.h kni: fix kernel 5.4 build - num_online_cpus kni: fix kernel 5.4 build - skb_frag_t to bio_vec kernel/linux/kni/ethtool/igb/igb_main.c | 12 ++++++++++-- kernel/linux/kni/ethtool/igb/kcompat.h | 10 ++++++++-- kernel/linux/kni/ethtool/ixgbe/kcompat.h | 10 ++++++++-- 3 files changed, 26 insertions(+), 6 deletions(-) -- 2.23.0