From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75DC0A00B8 for ; Mon, 28 Oct 2019 09:50:00 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 552231BF05; Mon, 28 Oct 2019 09:50:00 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id D8EDD49DF; Mon, 28 Oct 2019 09:49:55 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Oct 2019 01:49:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,239,1569308400"; d="scan'208";a="282880813" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga001.jf.intel.com with ESMTP; 28 Oct 2019 01:49:53 -0700 Date: Mon, 28 Oct 2019 16:46:27 +0800 From: Ye Xiaolong To: Min JiaqiX Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20191028084627.GA12923@intel.com> References: <20191024190818.36524-1-jiaqix.min@intel.com> <20191028155453.37207-1-jiaqix.min@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191028155453.37207-1-jiaqix.min@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/ice: fix setting max frame size X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 10/28, Min JiaqiX wrote: >Max frame size is not set to HW, so packets above the MTU >do not get dropped by HW. The patch fixed the issue. > >Fixes: ae2bdd0219cb ("net/ice: support MTU setting") We should set max frame size to HW in the beginning when the driver was introduced, so the fix commit should be 50370662b727 ("net/ice: support device and queue ops") Fix this while merging. >Cc: stable@dpdk.org > >Signed-off-by: Min JiaqiX >--- >v2: >* Changed commit message. >--- > drivers/net/ice/ice_ethdev.c | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c >index 022b58c01..403305cfb 100644 >--- a/drivers/net/ice/ice_ethdev.c >+++ b/drivers/net/ice/ice_ethdev.c >@@ -2506,6 +2506,10 @@ ice_dev_start(struct rte_eth_dev *dev) > > pf->adapter_stopped = false; > >+ /* Set the max frame size */ >+ ice_aq_set_mac_cfg(hw, >+ pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL); >+ Why set the max frame size to HW in start ops, not in init stage like in i40e? and what if max_rx_pkt_len hasn't been set? Thanks, Xiaolong > return 0; > > /* stop the started queues if failed to start all queues */ >-- >2.17.1 > Reviewed-by: Xiaolong Ye Applied to dpdk-next-net-intel. Thanks.