OcteonTx was disabled for causing an internal compiler error on old gcc versions. See commit 4f760550a093 ("mk: disable OcteonTx for buggy compilers"). The condition that was added later to apply disabling OcteonTx only on arm64 caused the condition to never be obeyed because it compares ["arm64"] to [arm64]. This fixes the condition by using RTE_ARCH instead of CONFIG_RTE_ARCH, because the former has the quotes removed, while the later doesn't. Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on arm64") Cc: stable@dpdk.org Signed-off-by: Ali Alnubani <alialnu@mellanox.com> --- mk/toolchain/gcc/rte.toolchain-compat.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk index ea40a11c0..00d6fd642 100644 --- a/mk/toolchain/gcc/rte.toolchain-compat.mk +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk @@ -99,7 +99,7 @@ else endif # Disable octeontx event PMD for gcc < 4.8.6 & ARCH=arm64 - ifeq ($(CONFIG_RTE_ARCH), arm64) + ifeq ($(RTE_ARCH), arm64) ifeq ($(shell test $(GCC_VERSION)$(GCC_PATCHLEVEL) -lt 486 && echo 1), 1) CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d -- 2.23.0
This disables OcteonTx2 for gcc 4.8.5 as the compiler is emitting "internal compiler error" for aarch64. Fixes: 9a8864c8b5da ("net/octeontx2: add build and doc infrastructure") Cc: stable@dpdk.org Signed-off-by: Ali Alnubani <alialnu@mellanox.com> --- mk/toolchain/gcc/rte.toolchain-compat.mk | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk index 00d6fd642..dd2c4e5da 100644 --- a/mk/toolchain/gcc/rte.toolchain-compat.mk +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk @@ -104,6 +104,9 @@ else CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d CONFIG_RTE_LIBRTE_OCTEONTX_PMD=d + CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV=d + CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL=d + CONFIG_RTE_LIBRTE_OCTEONTX2_PMD=d endif endif -- 2.23.0
28/10/2019 12:25, Ali Alnubani:
> OcteonTx was disabled for causing an internal compiler error on old gcc
> versions.
> See commit 4f760550a093 ("mk: disable OcteonTx for buggy compilers").
>
> The condition that was added later to apply disabling OcteonTx
> only on arm64 caused the condition to never be obeyed because it
> compares ["arm64"] to [arm64].
>
> This fixes the condition by using RTE_ARCH instead of CONFIG_RTE_ARCH,
> because the former has the quotes removed, while the later doesn't.
>
> Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on arm64")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> ---
> - ifeq ($(CONFIG_RTE_ARCH), arm64)
> + ifeq ($(RTE_ARCH), arm64)
Acked-by: Thomas Monjalon <thomas@monjalon.net>
On Mon, Oct 28, 2019 at 4:56 PM Ali Alnubani <alialnu@mellanox.com> wrote: > > OcteonTx was disabled for causing an internal compiler error on old gcc > versions. > See commit 4f760550a093 ("mk: disable OcteonTx for buggy compilers"). > > The condition that was added later to apply disabling OcteonTx > only on arm64 caused the condition to never be obeyed because it > compares ["arm64"] to [arm64]. > > This fixes the condition by using RTE_ARCH instead of CONFIG_RTE_ARCH, > because the former has the quotes removed, while the later doesn't. > > Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on arm64") > Cc: stable@dpdk.org > > Signed-off-by: Ali Alnubani <alialnu@mellanox.com> Acked-by: Jerin Jacob <jerinj@marvell.com> > --- > mk/toolchain/gcc/rte.toolchain-compat.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk > index ea40a11c0..00d6fd642 100644 > --- a/mk/toolchain/gcc/rte.toolchain-compat.mk > +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk > @@ -99,7 +99,7 @@ else > endif > > # Disable octeontx event PMD for gcc < 4.8.6 & ARCH=arm64 > - ifeq ($(CONFIG_RTE_ARCH), arm64) > + ifeq ($(RTE_ARCH), arm64) > ifeq ($(shell test $(GCC_VERSION)$(GCC_PATCHLEVEL) -lt 486 && echo 1), 1) > CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d > CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d > -- > 2.23.0 >
On Mon, Oct 28, 2019 at 4:56 PM Ali Alnubani <alialnu@mellanox.com> wrote: > > This disables OcteonTx2 for gcc 4.8.5 as the compiler is > emitting "internal compiler error" for aarch64. > > Fixes: 9a8864c8b5da ("net/octeontx2: add build and doc infrastructure") > Cc: stable@dpdk.org > > Signed-off-by: Ali Alnubani <alialnu@mellanox.com> > --- > mk/toolchain/gcc/rte.toolchain-compat.mk | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk > index 00d6fd642..dd2c4e5da 100644 > --- a/mk/toolchain/gcc/rte.toolchain-compat.mk > +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk > @@ -104,6 +104,9 @@ else > CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d > CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d > CONFIG_RTE_LIBRTE_OCTEONTX_PMD=d > + CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV=d > + CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL=d > + CONFIG_RTE_LIBRTE_OCTEONTX2_PMD=d # Please add the following config also as there may be a connection in future CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_CRYPTO=d CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_DMA_RAWDEV=d # s/OcteonTx2/OCTEON TX2/g in git commit and subject With the above change: Acked-by: Jerin Jacob <jerinj@marvell.com> > endif > endif > > -- > 2.23.0 >
OcteonTx was disabled for causing an internal compiler error on old gcc versions. See commit 4f760550a093 ("mk: disable OcteonTx for buggy compilers"). The condition that was added later to apply disabling OcteonTx only on arm64 caused the condition to never be obeyed because it compares ["arm64"] to [arm64]. This fixes the condition by using RTE_ARCH instead of CONFIG_RTE_ARCH, because the former has the quotes removed, while the later doesn't. Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on arm64") Cc: stable@dpdk.org Signed-off-by: Ali Alnubani <alialnu@mellanox.com> Acked-by: Thomas Monjalon <thomas@monjalon.net> Acked-by: Jerin Jacob <jerinj@marvell.com> --- mk/toolchain/gcc/rte.toolchain-compat.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk index ea40a11c0..00d6fd642 100644 --- a/mk/toolchain/gcc/rte.toolchain-compat.mk +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk @@ -99,7 +99,7 @@ else endif # Disable octeontx event PMD for gcc < 4.8.6 & ARCH=arm64 - ifeq ($(CONFIG_RTE_ARCH), arm64) + ifeq ($(RTE_ARCH), arm64) ifeq ($(shell test $(GCC_VERSION)$(GCC_PATCHLEVEL) -lt 486 && echo 1), 1) CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d -- 2.23.0
This disables OCTEON TX2 for gcc 4.8.5 as the compiler is emitting "internal compiler error" for aarch64. Fixes: 9a8864c8b5da ("net/octeontx2: add build and doc infrastructure") Cc: stable@dpdk.org Signed-off-by: Ali Alnubani <alialnu@mellanox.com> Acked-by: Jerin Jacob <jerinj@marvell.com> --- v2: Disabled configs PMD_OCTEONTX2_CRYPTO & PMD_OCTEONTX2_DMA_RAWDEV. mk/toolchain/gcc/rte.toolchain-compat.mk | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk index 00d6fd642..41c18f525 100644 --- a/mk/toolchain/gcc/rte.toolchain-compat.mk +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk @@ -104,6 +104,11 @@ else CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d CONFIG_RTE_LIBRTE_OCTEONTX_PMD=d + CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_DMA_RAWDEV=d + CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV=d + CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_CRYPTO=d + CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL=d + CONFIG_RTE_LIBRTE_OCTEONTX2_PMD=d endif endif -- 2.23.0
04/11/2019 14:30, Ali Alnubani:
> This disables OCTEON TX2 for gcc 4.8.5 as the compiler is
> emitting "internal compiler error" for aarch64.
>
> Fixes: 9a8864c8b5da ("net/octeontx2: add build and doc infrastructure")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied, thanks