patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH] net/ice: correct key len and queues check for RSS
@ 2019-10-30  2:52 Simei Su
  2019-10-30  3:13 ` Zhang, Qi Z
  2019-10-30  5:16 ` Ye Xiaolong
  0 siblings, 2 replies; 3+ messages in thread
From: Simei Su @ 2019-10-30  2:52 UTC (permalink / raw)
  To: qi.z.zhang, beilei.xing, qiming.yang; +Cc: dev, xiaolong.ye, simei.su, stable

This patch corrects key_len and queues check. The key_len and queues
are not supported to configure for RSS in rte_flow.

Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
Cc: stable@dpdk.org

Signed-off-by: Simei Su <simei.su@intel.com>
---
 drivers/net/ice/ice_hash.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index f710b97..f78fe42 100644
--- a/drivers/net/ice/ice_hash.c
+++ b/drivers/net/ice/ice_hash.c
@@ -25,8 +25,6 @@
 #include "ice_ethdev.h"
 #include "ice_generic_flow.h"
 
-#define ICE_ACTION_RSS_MAX_QUEUE_NUM 32
-
 struct rss_type_match_hdr {
 	uint32_t hdr_mask;
 	uint64_t eth_rss_hint;
@@ -333,15 +331,15 @@ struct ice_hash_match_type ice_hash_type_list[] = {
 					RTE_FLOW_ERROR_TYPE_ACTION, action,
 					"a nonzero RSS encapsulation level is not supported");
 
-			if (rss->key_len == 0)
+			if (rss->key_len)
 				return rte_flow_error_set(error, ENOTSUP,
 					RTE_FLOW_ERROR_TYPE_ACTION, action,
-					"RSS hash key_len mustn't be 0");
+					"a nonzero RSS key_len is not supported");
 
-			if (rss->queue_num > ICE_ACTION_RSS_MAX_QUEUE_NUM)
+			if (rss->queue)
 				return rte_flow_error_set(error, ENOTSUP,
 					RTE_FLOW_ERROR_TYPE_ACTION, action,
-					"too many queues for RSS context");
+					"a non-NULL RSS queue is not supported");
 
 			/* Check hash function and save it to rss_meta. */
 			if (rss->func ==
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] net/ice: correct key len and queues check for RSS
  2019-10-30  2:52 [dpdk-stable] [PATCH] net/ice: correct key len and queues check for RSS Simei Su
@ 2019-10-30  3:13 ` Zhang, Qi Z
  2019-10-30  5:16 ` Ye Xiaolong
  1 sibling, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2019-10-30  3:13 UTC (permalink / raw)
  To: Su, Simei, Xing, Beilei, Yang, Qiming; +Cc: dev, Ye, Xiaolong, stable



> -----Original Message-----
> From: Su, Simei <simei.su@intel.com>
> Sent: Wednesday, October 30, 2019 10:52 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Yang, Qiming <qiming.yang@intel.com>
> Cc: dev@dpdk.org; Ye, Xiaolong <xiaolong.ye@intel.com>; Su, Simei
> <simei.su@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/ice: correct key len and queues check for RSS
> 
> This patch corrects key_len and queues check. The key_len and queues are not
> supported to configure for RSS in rte_flow.
> 
> Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Simei Su <simei.su@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] net/ice: correct key len and queues check for RSS
  2019-10-30  2:52 [dpdk-stable] [PATCH] net/ice: correct key len and queues check for RSS Simei Su
  2019-10-30  3:13 ` Zhang, Qi Z
@ 2019-10-30  5:16 ` Ye Xiaolong
  1 sibling, 0 replies; 3+ messages in thread
From: Ye Xiaolong @ 2019-10-30  5:16 UTC (permalink / raw)
  To: Simei Su; +Cc: qi.z.zhang, beilei.xing, qiming.yang, dev, stable

On 10/30, Simei Su wrote:
>This patch corrects key_len and queues check. The key_len and queues
>are not supported to configure for RSS in rte_flow.
>
>Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
>Cc: stable@dpdk.org
>
>Signed-off-by: Simei Su <simei.su@intel.com>
>---
> drivers/net/ice/ice_hash.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
>diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
>index f710b97..f78fe42 100644
>--- a/drivers/net/ice/ice_hash.c
>+++ b/drivers/net/ice/ice_hash.c
>@@ -25,8 +25,6 @@
> #include "ice_ethdev.h"
> #include "ice_generic_flow.h"
> 
>-#define ICE_ACTION_RSS_MAX_QUEUE_NUM 32
>-
> struct rss_type_match_hdr {
> 	uint32_t hdr_mask;
> 	uint64_t eth_rss_hint;
>@@ -333,15 +331,15 @@ struct ice_hash_match_type ice_hash_type_list[] = {
> 					RTE_FLOW_ERROR_TYPE_ACTION, action,
> 					"a nonzero RSS encapsulation level is not supported");
> 
>-			if (rss->key_len == 0)
>+			if (rss->key_len)
> 				return rte_flow_error_set(error, ENOTSUP,
> 					RTE_FLOW_ERROR_TYPE_ACTION, action,
>-					"RSS hash key_len mustn't be 0");
>+					"a nonzero RSS key_len is not supported");
> 
>-			if (rss->queue_num > ICE_ACTION_RSS_MAX_QUEUE_NUM)
>+			if (rss->queue)
> 				return rte_flow_error_set(error, ENOTSUP,
> 					RTE_FLOW_ERROR_TYPE_ACTION, action,
>-					"too many queues for RSS context");
>+					"a non-NULL RSS queue is not supported");
> 
> 			/* Check hash function and save it to rss_meta. */
> 			if (rss->func ==
>-- 
>1.8.3.1
>

Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel. Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-30  2:52 [dpdk-stable] [PATCH] net/ice: correct key len and queues check for RSS Simei Su
2019-10-30  3:13 ` Zhang, Qi Z
2019-10-30  5:16 ` Ye Xiaolong

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox