From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89194A00BE for ; Wed, 30 Oct 2019 06:20:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 648DD1BEC3; Wed, 30 Oct 2019 06:20:28 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id ED40C1BE3D; Wed, 30 Oct 2019 06:20:23 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Oct 2019 22:20:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,246,1569308400"; d="scan'208";a="203081746" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga003.jf.intel.com with ESMTP; 29 Oct 2019 22:20:21 -0700 Date: Wed, 30 Oct 2019 13:16:48 +0800 From: Ye Xiaolong To: Simei Su Cc: qi.z.zhang@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20191030051648.GD11315@intel.com> References: <1572403945-192506-1-git-send-email-simei.su@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1572403945-192506-1-git-send-email-simei.su@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-stable] [PATCH] net/ice: correct key len and queues check for RSS X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 10/30, Simei Su wrote: >This patch corrects key_len and queues check. The key_len and queues >are not supported to configure for RSS in rte_flow. > >Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS") >Cc: stable@dpdk.org > >Signed-off-by: Simei Su >--- > drivers/net/ice/ice_hash.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > >diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c >index f710b97..f78fe42 100644 >--- a/drivers/net/ice/ice_hash.c >+++ b/drivers/net/ice/ice_hash.c >@@ -25,8 +25,6 @@ > #include "ice_ethdev.h" > #include "ice_generic_flow.h" > >-#define ICE_ACTION_RSS_MAX_QUEUE_NUM 32 >- > struct rss_type_match_hdr { > uint32_t hdr_mask; > uint64_t eth_rss_hint; >@@ -333,15 +331,15 @@ struct ice_hash_match_type ice_hash_type_list[] = { > RTE_FLOW_ERROR_TYPE_ACTION, action, > "a nonzero RSS encapsulation level is not supported"); > >- if (rss->key_len == 0) >+ if (rss->key_len) > return rte_flow_error_set(error, ENOTSUP, > RTE_FLOW_ERROR_TYPE_ACTION, action, >- "RSS hash key_len mustn't be 0"); >+ "a nonzero RSS key_len is not supported"); > >- if (rss->queue_num > ICE_ACTION_RSS_MAX_QUEUE_NUM) >+ if (rss->queue) > return rte_flow_error_set(error, ENOTSUP, > RTE_FLOW_ERROR_TYPE_ACTION, action, >- "too many queues for RSS context"); >+ "a non-NULL RSS queue is not supported"); > > /* Check hash function and save it to rss_meta. */ > if (rss->func == >-- >1.8.3.1 > Acked-by: Xiaolong Ye Applied to dpdk-next-net-intel. Thanks.