From: Jack Min <jackmin@mellanox.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: "dev@dpdk.org" <dev@dpdk.org>, Ori Kam <orika@mellanox.com>, Slava Ovsiienko <viacheslavo@mellanox.com>, Adrien Mazarguil <adrien.mazarguil@6wind.com>, Ferruh Yigit <ferruh.yigit@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>, "stable@dpdk.org" <stable@dpdk.org> Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] ethdev: expand RSS flows based on last item spec Date: Tue, 5 Nov 2019 12:08:38 +0000 Message-ID: <20191105120814.hx4tnoz5ytqozd6n@mellanox.com> (raw) In-Reply-To: <4507833.CEzoxxxZIU@xps> On Tue, 19-11-05, 11:11, Thomas Monjalon wrote: > Hi Jack, > > If it is a fix, please change your title. > Ok, I will add 'fix' in title. > 05/11/2019 10:16, Xiaoyu Min: > > When rte_flow_expand_rss expands rte_flow item list based on the RSS > > types. > > There is no verb in this sentence. > It seems I missed some words here. I'll update it. > > In another word, it will add some rte_flow items if the user > > What is "it"? > I mean rte_flow_expande_rss. > > specified items are not complete, for example: > > > > ... pattern eth / end actions rss type tcp end ... > > Please explain why it is not complete. > What I mean is user provides above instead of: ... pattern eth / ipv6 / tcp / end actions rss type tcp end ... This one is complete. > > > > above flow will be expaned to: > > > > ... pattern eth / end actions rss types tcp > > ... pattern eth / ipv4 / tcp / end actions rss types tcp ... > > ... pattern eth / ipv6 / tcp / end actsion rss types tcp ... > > There are several typos in this text. Please check. > Sure. > > However the expansion is just simply expanding items without > > checking last items' spec, means the expanded rules could have conflicting > > settings which is not reasonable and leads to some HW error, for > > example: > > This wording is really not clear. > Please make short sentences. > OK, I'll make it shorter. > > ... pattern eth type is 0x86DD / end actions rss types tcp ... > > > > is expaneded to: > > > > ... pattern eth type is 0x86DD / ipv4 / tcp end ... > > > > which has conflicting values: 0x86DD vs. ipv4 and HW will refuse create > > flow on some NICs. > > > > This patch will fix above by checking the last item's spec and try to > > complete the item list. > > > > Currently only support to complete item list based on L2/L3 layer. > > > > Fixes: 4ed05fcd441b ("ethdev: add flow API to expand RSS flows") > > Cc: stable@dpdk.org > > Missing empty line here to separate blocks. > Ok, I'll add empty line here. > > Signed-off-by: Xiaoyu Min <jackmin@mellanox.com> > > --- > > lib/librte_ethdev/rte_flow.c | 132 +++++++++++++++++++++++++++++++++-- > > 1 file changed, 127 insertions(+), 5 deletions(-) > > It's a big change. It needs to be carefully reviewed. > >
next prev parent reply other threads:[~2019-11-05 12:08 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-05 9:16 [dpdk-stable] " Xiaoyu Min 2019-11-05 10:11 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon 2019-11-05 12:08 ` Jack Min [this message] 2019-11-05 13:42 ` [dpdk-stable] [PATCH v2] ethdev: fix expand RSS flows Xiaoyu Min 2019-11-06 10:12 ` Ori Kam 2019-11-07 17:02 ` Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191105120814.hx4tnoz5ytqozd6n@mellanox.com \ --to=jackmin@mellanox.com \ --cc=adrien.mazarguil@6wind.com \ --cc=arybchenko@solarflare.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=orika@mellanox.com \ --cc=stable@dpdk.org \ --cc=thomas@monjalon.net \ --cc=viacheslavo@mellanox.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git