From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DC1DA04AB for ; Thu, 7 Nov 2019 04:34:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D9FA1E545; Thu, 7 Nov 2019 04:34:09 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2174D1E545; Thu, 7 Nov 2019 04:34:06 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 19:34:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,276,1569308400"; d="scan'208";a="229366191" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by FMSMGA003.fm.intel.com with ESMTP; 06 Nov 2019 19:34:04 -0800 Date: Thu, 7 Nov 2019 11:30:02 +0800 From: Ye Xiaolong To: Wang ShougangX Cc: dev@dpdk.org, qiming.yang@intel.com, beilei.xing@intel.com, yahui.cao@intel.com, stable@dpdk.org Message-ID: <20191107033002.GB100445@intel.com> References: <20191105033806.2878-1-shougangx.wang@intel.com> <20191107031955.GE68021@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191107031955.GE68021@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ice: fix wild pointer X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 11/07, Ye Xiaolong wrote: >On 11/05, Wang ShougangX wrote: >>To avoid wild pointer, pointers should be set to NULL after free them. >> >>Fixes: 1a2fc1799f09 ("net/ice: reject duplicated flow for flow director") >>Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine") >>Cc: stable@dpdk.org >> >>Signed-off-by: Wang ShougangX >>--- >> drivers/net/ice/ice_fdir_filter.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >>diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c >>index 736ccd54e..d2c754f07 100644 >>--- a/drivers/net/ice/ice_fdir_filter.c >>+++ b/drivers/net/ice/ice_fdir_filter.c >>@@ -403,6 +403,9 @@ ice_fdir_release_filter_list(struct ice_pf *pf) >> rte_free(fdir_info->hash_map); >> if (fdir_info->hash_table) >> rte_hash_free(fdir_info->hash_table); >>+ >>+ fdir_info->hash_map = NULL; >>+ fdir_info->hash_table = NULL; >> } >> >> /* >>@@ -525,10 +528,13 @@ ice_fdir_prof_free(struct ice_hw *hw) >> >> for (ptype = ICE_FLTR_PTYPE_NONF_IPV4_UDP; >> ptype < ICE_FLTR_PTYPE_MAX; >>- ptype++) >>+ ptype++) { >> rte_free(hw->fdir_prof[ptype]); >>+ hw->fdir_prof[ptype] = NULL; >>+ } >> >> rte_free(hw->fdir_prof); >>+ hw->fdir_prof = NULL; >> } >> >> /* Remove a profile for some filter type */ >>-- >>2.17.1 >> > >Reviewed-by: Xiaolong Ye > >Applied to dpdk-next-net-intel. Thanks. Please ignore this mail, I'm still waiting for your new patchset. Thanks, Xiaolong