patches for DPDK stable branches
 help / color / Atom feed
* Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved address range
       [not found] <20191105160921.6951-1-stephen@networkplumber.org>
@ 2019-11-06  5:36 ` Hemant Agrawal
  2019-11-07 20:52   ` David Marchand
  0 siblings, 1 reply; 3+ messages in thread
From: Hemant Agrawal @ 2019-11-06  5:36 UTC (permalink / raw)
  To: Stephen Hemminger, dev; +Cc: Ferruh Yigit, stable

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Stephen Hemminger
> Sent: Tuesday, November 5, 2019 9:39 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Ferruh Yigit
> <ferruh.yigit@intel.com>
> Subject: [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved
> address range
> 
> The original patch used incorrect subnet range for testing.
> 
> Fixes: 37afe381bde4 ("examples/l3fwd: use reserved IP addresses")

[Hemant]  better to also add Cc: stable@dpdk.org
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved address range
  2019-11-06  5:36 ` [dpdk-stable] [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved address range Hemant Agrawal
@ 2019-11-07 20:52   ` David Marchand
  2019-11-08  3:24     ` Stephen Hemminger
  0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2019-11-07 20:52 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev, Hemant Agrawal, Ferruh Yigit, stable

Stephen,

Do we want to fix testpmd?

$ git grep 192.*18 origin/master -- app/test-pmd/
origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_src_addr = (192U <<
24) | (18 << 16) | (0 << 8) | 1;
origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_dst_addr = (192U <<
24) | (18 << 16) | (0 << 8) | 2;

Commit bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP parameters")


I will take this patch on the example, for now.

On Wed, Nov 6, 2019 at 6:36 AM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Stephen Hemminger
> > Sent: Tuesday, November 5, 2019 9:39 PM
> > To: dev@dpdk.org
> > Cc: Stephen Hemminger <stephen@networkplumber.org>; Ferruh Yigit
> > <ferruh.yigit@intel.com>
> > Subject: [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved
> > address range
> >
> > The original patch used incorrect subnet range for testing.
> >
> > Fixes: 37afe381bde4 ("examples/l3fwd: use reserved IP addresses")
>
> [Hemant]  better to also add Cc: stable@dpdk.org

Yes.

> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved address range
  2019-11-07 20:52   ` David Marchand
@ 2019-11-08  3:24     ` Stephen Hemminger
  0 siblings, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2019-11-08  3:24 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, Hemant Agrawal, Ferruh Yigit, stable

On Thu, 7 Nov 2019 21:52:47 +0100
David Marchand <david.marchand@redhat.com> wrote:

> Stephen,
> 
> Do we want to fix testpmd?
> 
> $ git grep 192.*18 origin/master -- app/test-pmd/
> origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_src_addr = (192U <<
> 24) | (18 << 16) | (0 << 8) | 1;
> origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_dst_addr = (192U <<
> 24) | (18 << 16) | (0 << 8) | 2;
> 
> Commit bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP parameters")
> 

Yes, that should be fixed.
Ideally it should use a string instead of hardcoding shifts.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20191105160921.6951-1-stephen@networkplumber.org>
2019-11-06  5:36 ` [dpdk-stable] [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved address range Hemant Agrawal
2019-11-07 20:52   ` David Marchand
2019-11-08  3:24     ` Stephen Hemminger

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox