From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11F0DA04AB for ; Fri, 8 Nov 2019 04:24:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C7FDA1BF4E; Fri, 8 Nov 2019 04:24:41 +0100 (CET) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 4CC181BF3C for ; Fri, 8 Nov 2019 04:24:39 +0100 (CET) Received: by mail-pf1-f194.google.com with SMTP id v19so3769769pfm.3 for ; Thu, 07 Nov 2019 19:24:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1gjZWDnBM46aH4FV6fNjNYwql0+oB7EBeiZOuftggaM=; b=AbBL3SSerOaHOHXIoo2Q4zDGr2/BBIiWfVO3SIYJkgsD+J+avb6YPrGPh66/yzw5pq Mp0KalTuEE/CJ2xCgUxMK/3rj7nltvay9Cme+J3BHePrbQwesum5JMn7qHSdBwyS+g2M zq3Wyf9Qt+jsdngTUaP2wVtsHNge7L3A+7TBc2LqSsX4ZzBRZcL5FT94w5b+0HMVMSyx hTYYUaYpKmuEoc5MX/HGAef7ZqvjhlsDogX+GdPsztEo7/kIydp13RyESzlZSkwAabVr zXKTeOzdwC7FaPxl3wfI9TWdJ10JI2UXsaFkEg7XKt9EvLLqq7jaCnzVg7UY0fN7eahL rmtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1gjZWDnBM46aH4FV6fNjNYwql0+oB7EBeiZOuftggaM=; b=eW/H2zLRi9lGaJw61QuFttLPbg/1QSxWQZzIg2IIFRR89Ts+stKHt3jmGlwSCReMT+ YUvUJiLhcZ+WAYlgFwnqwQ43k3qGZzDYF40S2vZCZZx8S92UkD7bqEDz08g7IG9NUjwX E5Flxc0DGePFTds+bI9o4WDJ+XckmonDz9bM7XVOOchveWnKPm25nQBZIW/+oFUHxOGY Hl/mTV1Q4sHwe33CMI43L7Lfdfv6Fo5RzeQFnHADnj+SY+BiZtMrFx2CaFjbr3hPnEDn 8spnZE1bPA17ZOhGw5Q1gs7qurU4fwXMs3a8YT/1eXN3ZoY0WbdnWUyhmhyXuAkpg5Ew h8+g== X-Gm-Message-State: APjAAAVEpMAq5tW/WubZyij9KwUCVrWLgT5IfXP1RN8uj42WApBi2OvP o31I+R6AbultfsHWRpz9Ej80jg== X-Google-Smtp-Source: APXvYqy/BplQa4JXmtOA24pnWAHloGDFCW6ODEMkt58RNuDLOGas/fjQpwNRMt/Y2vBr+2XHYcLAwg== X-Received: by 2002:a63:db15:: with SMTP id e21mr8983362pgg.21.1573183478124; Thu, 07 Nov 2019 19:24:38 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id w24sm3983932pfn.136.2019.11.07.19.24.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2019 19:24:37 -0800 (PST) Date: Thu, 7 Nov 2019 19:24:29 -0800 From: Stephen Hemminger To: David Marchand Cc: "dev@dpdk.org" , Hemant Agrawal , Ferruh Yigit , "stable@dpdk.org" Message-ID: <20191107192429.2f2609c3@hermes.lan> In-Reply-To: References: <20191105160921.6951-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved address range X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, 7 Nov 2019 21:52:47 +0100 David Marchand wrote: > Stephen, > > Do we want to fix testpmd? > > $ git grep 192.*18 origin/master -- app/test-pmd/ > origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_src_addr = (192U << > 24) | (18 << 16) | (0 << 8) | 1; > origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_dst_addr = (192U << > 24) | (18 << 16) | (0 << 8) | 2; > > Commit bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP parameters") > Yes, that should be fixed. Ideally it should use a string instead of hardcoding shifts.