From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCEE1A04B3 for ; Mon, 18 Nov 2019 04:32:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 992942B87; Mon, 18 Nov 2019 04:32:11 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 0058D23D; Mon, 18 Nov 2019 04:32:07 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Nov 2019 19:32:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,318,1569308400"; d="scan'208";a="208718512" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga003.jf.intel.com with ESMTP; 17 Nov 2019 19:32:05 -0800 Date: Mon, 18 Nov 2019 11:28:36 +0800 From: Ye Xiaolong To: "Cui, LunyuanX" Cc: "dev@dpdk.org" , "Lu, Wenzhuo" , "stable@dpdk.org" Message-ID: <20191118032836.GD69793@intel.com> References: <20191113173243.90826-1-lunyuanx.cui@intel.com> <20191115144823.3647-1-lunyuanx.cui@intel.com> <20191118030637.GB69793@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/e1000: fix link status update X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 11/18, Cui, LunyuanX wrote: >Hi, Xiaolong > >> -----Original Message----- >> From: Ye, Xiaolong >> Sent: Monday, November 18, 2019 11:07 AM >> To: Cui, LunyuanX >> Cc: dev@dpdk.org; Lu, Wenzhuo ; >> stable@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: fix link status update >> >> On 11/15, Lunyuan Cui wrote: >> >Unassigned variable should not be used as judgment, and there is no >> >need to update link status according to old link status. >> >This patch fix the issue. >> > >> >Fixes: 80ba61115e77 ("net/e1000: use link status helper functions") >> >Cc: stable@dpdk.org >> > >> >Signed-off-by: Lunyuan Cui >> >--- >> > drivers/net/e1000/em_ethdev.c | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> > >> >diff --git a/drivers/net/e1000/em_ethdev.c >> >b/drivers/net/e1000/em_ethdev.c index 9a88b50b2..7959ee4e9 100644 >> >--- a/drivers/net/e1000/em_ethdev.c >> >+++ b/drivers/net/e1000/em_ethdev.c >> >@@ -1157,7 +1157,7 @@ eth_em_link_update(struct rte_eth_dev *dev, >> int wait_to_complete) >> > memset(&link, 0, sizeof(link)); >> > >> > /* Now we check if a transition has happened */ >> >- if (link_check && (link.link_status == ETH_LINK_DOWN)) { >> >+ if (link_check) { >> > uint16_t duplex, speed; >> > hw->mac.ops.get_link_up_info(hw, &speed, &duplex); >> > link.link_duplex = (duplex == FULL_DUPLEX) ? >> >@@ -1167,7 +1167,7 @@ eth_em_link_update(struct rte_eth_dev *dev, >> int wait_to_complete) >> > link.link_status = ETH_LINK_UP; >> > link.link_autoneg = !(dev->data->dev_conf.link_speeds & >> > ETH_LINK_SPEED_FIXED); >> >- } else if (!link_check && (link.link_status == ETH_LINK_UP)) { >> >+ } else { >> > link.link_speed = ETH_SPEED_NUM_NONE; >> > link.link_duplex = ETH_LINK_HALF_DUPLEX; >> > link.link_status = ETH_LINK_DOWN; >> >> I am a little confused about the variable link_check, is it used to indicate >> whether there is link status change or link status up? > >The variable link_check is used to indicate link status up. >When link_check is true, link status is up. >When link_check is false, link status is down. Then the link_check seems a bad name, could you help submit a patch to rename it? @whenzhuo, could you help review/ack this change? Thanks, Xiaolong > >Thanks, >Lunyuan >