From: Ferruh Yigit <ferruh.yigit@intel.com> To: Thomas Monjalon <thomas@monjalon.net>, Andrew Rybchenko <arybchenko@solarflare.com> Cc: dev@dpdk.org, stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com> Subject: [dpdk-stable] [PATCH v2] mk: remove library search path from binary Date: Fri, 22 Nov 2019 11:30:23 +0000 Message-ID: <20191122113023.15296-1-ferruh.yigit@intel.com> (raw) In-Reply-To: <20191112131556.16668-1-ferruh.yigit@intel.com> This patch functionally reverts the patch in fixes line to not have any hardcoded library path in the final binary for the security reasons, in case this binary distributed to production environment. RPATH only added in RTE_DEVEL_BUILD case and this binary shouldn't distributed, but still removing it to be cautious. Fixes: 8919f73bcbaa ("mk: add build directory to library search path") Cc: stable@dpdk.org Suggested-by: Bruce Richardson <bruce.richardson@intel.com> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> --- v2: * set 'build' if provided argument is testpmd path --- devtools/test-null.sh | 2 ++ mk/rte.app.mk | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/devtools/test-null.sh b/devtools/test-null.sh index 9f9a459f7..afcd8bb29 100755 --- a/devtools/test-null.sh +++ b/devtools/test-null.sh @@ -11,6 +11,7 @@ coremask=${2:-3} # default using cores 0 and 1 eal_options=$3 testpmd_options=$4 +[ -f "$testpmd" ] && build=$(dirname $(dirname $testpmd)) [ -f "$testpmd" ] || testpmd=$build/app/dpdk-testpmd [ -f "$testpmd" ] || testpmd=$build/app/testpmd if [ ! -f "$testpmd" ] ; then @@ -19,6 +20,7 @@ if [ ! -f "$testpmd" ] ; then fi if ldd $testpmd | grep -q librte_ ; then + export LD_LIBRARY_PATH=$build/lib:$LD_LIBRARY_PATH libs='-d librte_mempool_ring.so -d librte_pmd_null.so' else libs= diff --git a/mk/rte.app.mk b/mk/rte.app.mk index a278552c6..05ea034b9 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -379,10 +379,6 @@ filter-libs = \ LDLIBS := $(call filter-libs,$(LDLIBS)) -ifeq ($(RTE_DEVEL_BUILD)$(CONFIG_RTE_BUILD_SHARED_LIB),yy) -LDFLAGS += -rpath=$(RTE_SDK_BIN)/lib -endif - MAPFLAGS = -Map=$@.map --cref .PHONY: all -- 2.21.0
next prev parent reply other threads:[~2019-11-22 11:30 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-12 13:15 [dpdk-stable] [PATCH] " Ferruh Yigit 2019-11-22 11:30 ` Ferruh Yigit [this message] 2019-11-25 22:11 ` [dpdk-stable] [dpdk-dev] [PATCH v2] " Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191122113023.15296-1-ferruh.yigit@intel.com \ --to=ferruh.yigit@intel.com \ --cc=arybchenko@solarflare.com \ --cc=bruce.richardson@intel.com \ --cc=dev@dpdk.org \ --cc=stable@dpdk.org \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git