patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH] net/e1000: fix link status
@ 2019-11-13 12:46 Cui LunyuanX
  2019-11-26  2:38 ` Lu, Wenzhuo
  0 siblings, 1 reply; 3+ messages in thread
From: Cui LunyuanX @ 2019-11-13 12:46 UTC (permalink / raw)
  To: dev; +Cc: Wenzhuo Lu, Yang Qiming, Cui LunyuanX, stable

The link status got from link status register was not correct,
because register has been reset when ports reset.
After port reset, set the link status down.

Fixes: c431ec66c54c ("net/igb: support setting link up or down")
Cc: stable@dpdk.org

Signed-off-by: Lunyuan Cui <lunyuanx.cui@intel.com>
---
 drivers/net/e1000/igb_ethdev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 369a978ad..83102f2ad 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -891,6 +891,8 @@ eth_igb_dev_init(struct rte_eth_dev *eth_dev)
 	/* enable support intr */
 	igb_intr_enable(eth_dev);
 
+	eth_igb_dev_set_link_down(eth_dev);
+
 	/* initialize filter info */
 	memset(filter_info, 0,
 	       sizeof(struct e1000_filter_info));
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] net/e1000: fix link status
  2019-11-13 12:46 [dpdk-stable] [PATCH] net/e1000: fix link status Cui LunyuanX
@ 2019-11-26  2:38 ` Lu, Wenzhuo
  2019-11-26  2:39   ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
  0 siblings, 1 reply; 3+ messages in thread
From: Lu, Wenzhuo @ 2019-11-26  2:38 UTC (permalink / raw)
  To: Cui, LunyuanX, dev; +Cc: Yang, Qiming, stable

Hi,

> -----Original Message-----
> From: Cui, LunyuanX
> Sent: Wednesday, November 13, 2019 8:47 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Cui, LunyuanX <lunyuanx.cui@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] net/e1000: fix link status
> 
> The link status got from link status register was not correct, because register
> has been reset when ports reset.
> After port reset, set the link status down.
> 
> Fixes: c431ec66c54c ("net/igb: support setting link up or down")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Lunyuan Cui <lunyuanx.cui@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/e1000: fix link status
  2019-11-26  2:38 ` Lu, Wenzhuo
@ 2019-11-26  2:39   ` " Ye Xiaolong
  0 siblings, 0 replies; 3+ messages in thread
From: Ye Xiaolong @ 2019-11-26  2:39 UTC (permalink / raw)
  To: Lu, Wenzhuo; +Cc: Cui, LunyuanX, dev, Yang, Qiming, stable

On 11/26, Lu, Wenzhuo wrote:
>Hi,
>
>> -----Original Message-----
>> From: Cui, LunyuanX
>> Sent: Wednesday, November 13, 2019 8:47 PM
>> To: dev@dpdk.org
>> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
>> <qiming.yang@intel.com>; Cui, LunyuanX <lunyuanx.cui@intel.com>;
>> stable@dpdk.org
>> Subject: [PATCH] net/e1000: fix link status
>> 
>> The link status got from link status register was not correct, because register
>> has been reset when ports reset.
>> After port reset, set the link status down.
>> 
>> Fixes: c431ec66c54c ("net/igb: support setting link up or down")
>> Cc: stable@dpdk.org
>> 
>> Signed-off-by: Lunyuan Cui <lunyuanx.cui@intel.com>
>Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

Applied to dpdk-next-net-intel, Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-13 12:46 [dpdk-stable] [PATCH] net/e1000: fix link status Cui LunyuanX
2019-11-26  2:38 ` Lu, Wenzhuo
2019-11-26  2:39   ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox