From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C059FA04B5 for ; Tue, 3 Dec 2019 19:28:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5D871BF80; Tue, 3 Dec 2019 19:28:46 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 62BF8235 for ; Tue, 3 Dec 2019 19:28:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575397723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2zLMUsGxN/WMs3amjcgmEbuS/SkFzGBShisQYJLTDqQ=; b=UhWLAqCnnKnBsTSwSN9dBNDOQC2R6SzvjPC4lqYgDBK0/+AxRsGjfpSrabJTOAjIZ/nkhG hZys6DwNSme6ZiWsJFv+JJEfI83hPi5RysXf+Jv/PGqkfr3iZ9fwKaUboGz7BWiedggBDR g7hQg+UFJJzx+E2ct8RgeYd3S54T3Wo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-431-J0X4eBzeMgu4uX51v9id_A-1; Tue, 03 Dec 2019 13:28:40 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DE6071883521; Tue, 3 Dec 2019 18:28:38 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-10.ams2.redhat.com [10.36.117.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id D18AF5C240; Tue, 3 Dec 2019 18:28:37 +0000 (UTC) From: Kevin Traynor To: Christian Ehrhardt Cc: Luca Boccassi , dpdk stable Date: Tue, 3 Dec 2019 18:26:46 +0000 Message-Id: <20191203182714.17297-37-ktraynor@redhat.com> In-Reply-To: <20191203182714.17297-1-ktraynor@redhat.com> References: <20191203182714.17297-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: J0X4eBzeMgu4uX51v9id_A-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'build: avoid overlinking' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/10/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/a6a3a60b99f665ca2d= 0cdac911c98d7f0a9e2a5d Thanks. Kevin. --- >From a6a3a60b99f665ca2d0cdac911c98d7f0a9e2a5d Mon Sep 17 00:00:00 2001 From: Christian Ehrhardt Date: Thu, 29 Aug 2019 17:30:03 +0200 Subject: [PATCH] build: avoid overlinking [ upstream commit 31b798a6f08e9b333b94b8bb26910209aa810b73 ] A while ago telemetry was added in 57ae0ec6 and it also added as-needed to config/meson.build. This seems no more needed these days as due to other build changes the ordering in buildlogs is: [...] -lrte_telemetry [...] -Wl,--no-as-needed [...] Which means telemetry no more benefits from --no-as-needed anyway. Overlinking problems get triggered by the meson generated pkgconfig which will have: [...] -Wl,--no-as-needed This will overlink and in addition anything that follows as it also doesn't wrap back to --as-needed. So if a projects includes dpdk libs + it will also consider with --no-as-needed. Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1841759 Fixes: 57ae0ec62620 ("build: add dependency on telemetry to apps with meson= ") Signed-off-by: Christian Ehrhardt Acked-by: Luca Boccassi --- config/meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/config/meson.build b/config/meson.build index d4d450829..e92be6c47 100644 --- a/config/meson.build +++ b/config/meson.build @@ -54,5 +54,4 @@ dpdk_conf.set('RTE_ARCH_64', cc.sizeof('void *') =3D=3D 8= ) =20 add_project_link_arguments('-Wl,--no-as-needed', language: 'c') -dpdk_extra_ldflags +=3D '-Wl,--no-as-needed' =20 # use pthreads --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-12-03 17:29:53.969262045 +0000 +++ 0037-build-avoid-overlinking.patch=092019-12-03 17:29:51.762749703 +000= 0 @@ -1 +1 @@ -From 31b798a6f08e9b333b94b8bb26910209aa810b73 Mon Sep 17 00:00:00 2001 +From a6a3a60b99f665ca2d0cdac911c98d7f0a9e2a5d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 31b798a6f08e9b333b94b8bb26910209aa810b73 ] + @@ -21 +22,0 @@ -Cc: stable@dpdk.org @@ -30 +31 @@ -index 2bafea530..a27f731f8 100644 +index d4d450829..e92be6c47 100644 @@ -33 +34 @@ -@@ -95,5 +95,4 @@ dpdk_conf.set('RTE_ARCH_64', cc.sizeof('void *') =3D=3D = 8) +@@ -54,5 +54,4 @@ dpdk_conf.set('RTE_ARCH_64', cc.sizeof('void *') =3D=3D = 8)