From: Bruce Richardson <bruce.richardson@intel.com>
To: Gargi Sau <gargi.sau@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/ethtool: fix unchecked return value
Date: Mon, 9 Dec 2019 12:07:12 +0000 [thread overview]
Message-ID: <20191209120712.GA98@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20191209063756.26790-1-gargi.sau@intel.com>
On Mon, Dec 09, 2019 at 06:37:56AM +0000, Gargi Sau wrote:
> This checks the return value from the function
> rte_eth_dev_set_vlan_offload.
>
> Coverity issue: 350358
> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gargi Sau <gargi.sau@intel.com>
> ---
> examples/ethtool/lib/rte_ethtool.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c
> index 667d7eaf2..db8150efd 100644
> --- a/examples/ethtool/lib/rte_ethtool.c
> +++ b/examples/ethtool/lib/rte_ethtool.c
> @@ -402,7 +402,9 @@ rte_ethtool_net_set_rx_mode(uint16_t port_id)
> }
>
> /* Enable Rx vlan filter, VF unspport status is discard */
> - rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK);
> + ret = rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK);
> + if (ret != 0)
> + return ret;
>
Looks ok to me.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2019-12-09 12:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 6:37 [dpdk-stable] " Gargi Sau
2019-12-09 12:07 ` Bruce Richardson [this message]
2020-02-13 13:59 ` [dpdk-stable] [dpdk-dev] " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209120712.GA98@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gargi.sau@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).