From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B50FA04F1 for ; Mon, 9 Dec 2019 14:03:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E516423D; Mon, 9 Dec 2019 14:03:46 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id F19C023D; Mon, 9 Dec 2019 14:03:45 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Dec 2019 05:03:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,294,1571727600"; d="scan'208";a="295550208" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga001.jf.intel.com with ESMTP; 09 Dec 2019 05:03:43 -0800 Date: Mon, 9 Dec 2019 20:59:18 +0800 From: Ye Xiaolong To: "Wang, Xiao W" Cc: Lu Qiuwen , "Zhang, Qi Z" , "dev@dpdk.org" , "Shaw, Jeffrey B" , "stable@dpdk.org" Message-ID: <20191209125918.GA64933@intel.com> References: <20191205133008.4464-1-luqiuwen@iie.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/fm10k: fix descriptor vlan field filling in Tx X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 12/06, Wang, Xiao W wrote: >Hi, > >> -----Original Message----- >> From: Lu Qiuwen >> Sent: Thursday, December 5, 2019 9:30 PM >> To: Zhang, Qi Z ; Wang, Xiao W >> >> Cc: dev@dpdk.org; Shaw, Jeffrey B ; >> stable@dpdk.org >> Subject: [PATCH] net/fm10k: fix descriptor vlan field filling in Tx >> >> The VLAN field in the descriptor is not filled when ol_flags has >> no VLAN flag. When the caller sends some packets with VLAN tags, >> but other packets do not have VLAN tags, the behavior of the program >> cannot be determined. >> >> Fixes: 4b61d3bfa941 ("fm10k: add receive and tranmit") >> Cc: jeffrey.b.shaw@intel.com >> Cc: stable@dpdk.org >> >> Signed-off-by: Lu Qiuwen >> --- >> drivers/net/fm10k/fm10k_rxtx.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/net/fm10k/fm10k_rxtx.c b/drivers/net/fm10k/fm10k_rxtx.c >> index 5c3112183..4accaa2cd 100644 >> --- a/drivers/net/fm10k/fm10k_rxtx.c >> +++ b/drivers/net/fm10k/fm10k_rxtx.c >> @@ -611,6 +611,8 @@ static inline void tx_xmit_pkt(struct fm10k_tx_queue *q, >> struct rte_mbuf *mb) >> /* set vlan if requested */ >> if (mb->ol_flags & PKT_TX_VLAN_PKT) >> q->hw_ring[q->next_free].vlan = mb->vlan_tci; >> + else >> + q->hw_ring[q->next_free].vlan = 0; >> >> q->sw_ring[q->next_free] = mb; >> q->hw_ring[q->next_free].buffer_addr = >> -- >> 2.20.1.windows.1 > >Acked-by: Xiao Wang Applied to dpdk-next-net-intel, Thanks.