From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2ABFA04F5 for ; Wed, 11 Dec 2019 22:28:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B8D3A2C6A; Wed, 11 Dec 2019 22:28:14 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id D1D6D2C6A for ; Wed, 11 Dec 2019 22:28:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576099692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xWnbTFNxfyd5Pgyj1/fErJdnVTCE4S9feJEq0zaUYjo=; b=ilSUG7tD2ZkcfES/sLruWCmPBCOSicJ72XctQQniCYVNcT52lPNma5FBDtDff4lCuxdmhO yksN+rVrR9sg4hJR/0538nFrPRfs63FO5pdk+9eiYIgCqyn58ewzSMdiQac10tXRQ3x+Zx Sf1TE4hj0C9FscUFeQNvpGudSBjMQK8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-33-F4tWYQbnMVGHYeXvWi5E3A-1; Wed, 11 Dec 2019 16:28:08 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8B2841800D45; Wed, 11 Dec 2019 21:28:07 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-64.ams2.redhat.com [10.36.116.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id BA56F10013A1; Wed, 11 Dec 2019 21:28:02 +0000 (UTC) From: Kevin Traynor To: Nithin Dabilpuram Cc: Jerin Jacob , Shahed Shaikh , David Marchand , Kevin Traynor , dpdk stable Date: Wed, 11 Dec 2019 21:26:10 +0000 Message-Id: <20191211212702.27851-18-ktraynor@redhat.com> In-Reply-To: <20191211212702.27851-1-ktraynor@redhat.com> References: <20191211212702.27851-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: F4tWYQbnMVGHYeXvWi5E3A-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'net/qede: use ack in interrupt handlers' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/17/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/9b30de5d63f0166e3b= 77bee7ad5c62d3fc4aaaca Thanks. Kevin. --- >From 9b30de5d63f0166e3b77bee7ad5c62d3fc4aaaca Mon Sep 17 00:00:00 2001 From: Nithin Dabilpuram Date: Wed, 11 Dec 2019 15:50:57 +0000 Subject: [PATCH] net/qede: use ack in interrupt handlers This is a partial pick of below commit from master. At this point only qede is updated as it addresses an observed issue. commit 6bee9d5f456a61a427384c815f6827aad83e3c06 Author: Nithin Dabilpuram Date: Tue Jul 23 10:04:19 2019 +0200 drivers/net: use ack in interrupt handlers Replace rte_intr_enable() with rte_intr_ack() API for acking an interrupt in interrupt handlers and rx_queue_intr_enable() callbacks of PMD's. This is inline with original intent of this change in PMDs to ack interrupts after handling is completed if device is backed by UIO, IGB_UIO or VFIO(with INTx). Signed-off-by: Nithin Dabilpuram Signed-off-by: Jerin Jacob Acked-by: Shahed Shaikh Tested-by: Shahed Shaikh Signed-off-by: David Marchand Signed-off-by: Kevin Traynor --- drivers/net/qede/Makefile | 1 + drivers/net/qede/meson.build | 2 ++ drivers/net/qede/qede_ethdev.c | 8 ++++---- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile index 2ecbd8d20..a11d5946a 100644 --- a/drivers/net/qede/Makefile +++ b/drivers/net/qede/Makefile @@ -13,4 +13,5 @@ LIB =3D librte_pmd_qede.a CFLAGS +=3D -O3 CFLAGS +=3D $(WERROR_FLAGS) +CFLAGS +=3D -DALLOW_EXPERIMENTAL_API LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring LDLIBS +=3D -lrte_ethdev -lrte_net -lrte_kvargs diff --git a/drivers/net/qede/meson.build b/drivers/net/qede/meson.build index 12388a680..1755719f0 100644 --- a/drivers/net/qede/meson.build +++ b/drivers/net/qede/meson.build @@ -2,4 +2,6 @@ # Copyright(c) 2018 Luca Boccassi =20 +allow_experimental_apis =3D true + subdir('base') objs =3D [base_objs] diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.= c index 8dced1899..c8291839c 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -249,6 +249,6 @@ qede_interrupt_handler_intx(void *param) =09=09qede_interrupt_action(ECORE_LEADING_HWFN(edev)); =20 -=09=09if (rte_intr_enable(eth_dev->intr_handle)) -=09=09=09DP_ERR(edev, "rte_intr_enable failed\n"); +=09=09if (rte_intr_ack(eth_dev->intr_handle)) +=09=09=09DP_ERR(edev, "rte_intr_ack failed\n"); =09} } @@ -262,6 +262,6 @@ qede_interrupt_handler(void *param) =20 =09qede_interrupt_action(ECORE_LEADING_HWFN(edev)); -=09if (rte_intr_enable(eth_dev->intr_handle)) -=09=09DP_ERR(edev, "rte_intr_enable failed\n"); +=09if (rte_intr_ack(eth_dev->intr_handle)) +=09=09DP_ERR(edev, "rte_intr_ack failed\n"); } =20 --=20 2.21.0