From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82FCFA04F3 for ; Thu, 19 Dec 2019 15:35:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7AFF31BE8E; Thu, 19 Dec 2019 15:35:22 +0100 (CET) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 6C84B1BE8E for ; Thu, 19 Dec 2019 15:35:21 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id b6so6246411wrq.0 for ; Thu, 19 Dec 2019 06:35:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=I5BtbFcqfm7EH9I+Xpf5CRd6pUI9UhFAQ5rYcXCG/Eo=; b=t6xJ/amVr+C1K+spozVjk+4wlK7DQv1SUThv2k/VrlXJsFWRjNZ22edmRH3Uuz7iPc jx9tLWGiC3/9lftH3qpb37w4b9T40cK1eYPUDXp2GVe+xRhU4tc1NLUg5PZpymv+Mcsk XkE9xv8u73LEnF3kaNqlR6ETy9feubjkuBCrW3rjquZzjUhbmJwmuvNfD3yAtWIYmS8I ojd2gMnQ52HkSHRrJcbMuG3XrXNscVyuOTECkqRiTE9hByfDlz5h6/lhG8vLIm/OFkcB nFnWXJDW7ySatVmQodS1a0NmXW7rXvs8d5yK720yx2FjJUAp8Xfd193JlYr3nrmC2hVQ 79hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I5BtbFcqfm7EH9I+Xpf5CRd6pUI9UhFAQ5rYcXCG/Eo=; b=m/WLOdb/A4YwAdmjHXKzErGwoLJtwKq80lFIBVCRF2RSy77j3MpXlcdF+0rJTeVX0U ecVDoJc69yOTnHv1RwEXBY3lFZpAQ6FTgQ4+0DJ4PQW0aoZA7cvvxyAyXKvBTCb8HZXj zqXMS3UGOoLYl9UND/n8mKuSc4t3D8t58y+sgdadmvTtcEavLrY2NBdvQV7EDtYGcZmr XSV2c43TzoV3nhG2LWNu6UVCdzubxVLGrV/r3qNe9cP7u/6Ori35XO5sZK21Vp4FwWEu mMqoYLQTwjNPDYl97gBVZquT8w6cEWPnLAsdGRkJCe6pkRAufq5Pj+Zgc3MInMheCKnF BMhA== X-Gm-Message-State: APjAAAXHSL1qvvBHSqeSd1zolCUdyXpCGrFn2NEZPMZKp8bfjn//KdwE yxUhmMLkHyMh+i0kr4pbzPLlIN8J X-Google-Smtp-Source: APXvYqw1mRA/CXK1jqU5O9E9vyHJTKG2jsePQzLrx06Y58IhB8LXQDr1fup5wQPvfpMxm9CX2wfC4Q== X-Received: by 2002:a5d:610a:: with SMTP id v10mr10046227wrt.267.1576766121132; Thu, 19 Dec 2019 06:35:21 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id y6sm6477936wrl.17.2019.12.19.06.35.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 06:35:20 -0800 (PST) From: luca.boccassi@gmail.com To: Yong Wang Cc: Xiaolong Ye , dpdk stable Date: Thu, 19 Dec 2019 14:32:37 +0000 Message-Id: <20191219143447.21506-10-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191219143447.21506-1-luca.boccassi@gmail.com> References: <20191219143447.21506-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/ixgbe: remove redundant assignment' has been queued to LTS release 17.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/21/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 7bddbf66a08d5f379e4db8b9273fcac116e7ef24 Mon Sep 17 00:00:00 2001 From: Yong Wang Date: Fri, 30 Aug 2019 16:45:29 +0800 Subject: [PATCH] net/ixgbe: remove redundant assignment [ upstream commit e573264c71de3de67e8fa81b0872c10bf4650f15 ] Since "link.link_duplex" has been assigned to ETH_LINK_FULL_DUPLEX just before switch statement, the assignment in switch-case statement is redundant. Remove it. Fixes: 82113036e4e5 ("ethdev: redesign link speed config") Signed-off-by: Yong Wang Reviewed-by: Xiaolong Ye --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index c186ed61a3..fef2270596 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4059,7 +4059,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, switch (link_speed) { default: case IXGBE_LINK_SPEED_UNKNOWN: - link.link_duplex = ETH_LINK_FULL_DUPLEX; link.link_speed = ETH_SPEED_NUM_100M; break; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-12-19 14:32:26.722053590 +0000 +++ 0010-net-ixgbe-remove-redundant-assignment.patch 2019-12-19 14:32:25.413284103 +0000 @@ -1,14 +1,15 @@ -From e573264c71de3de67e8fa81b0872c10bf4650f15 Mon Sep 17 00:00:00 2001 +From 7bddbf66a08d5f379e4db8b9273fcac116e7ef24 Mon Sep 17 00:00:00 2001 From: Yong Wang Date: Fri, 30 Aug 2019 16:45:29 +0800 Subject: [PATCH] net/ixgbe: remove redundant assignment +[ upstream commit e573264c71de3de67e8fa81b0872c10bf4650f15 ] + Since "link.link_duplex" has been assigned to ETH_LINK_FULL_DUPLEX just before switch statement, the assignment in switch-case statement is redundant. Remove it. Fixes: 82113036e4e5 ("ethdev: redesign link speed config") -Cc: stable@dpdk.org Signed-off-by: Yong Wang Reviewed-by: Xiaolong Ye @@ -17,17 +18,17 @@ 1 file changed, 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c -index 03fc1f7179..f328d7c033 100644 +index c186ed61a3..fef2270596 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c -@@ -4138,7 +4138,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, - link.link_speed = ETH_SPEED_NUM_10M; - else - link.link_speed = ETH_SPEED_NUM_100M; +@@ -4059,7 +4059,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, + switch (link_speed) { + default: + case IXGBE_LINK_SPEED_UNKNOWN: - link.link_duplex = ETH_LINK_FULL_DUPLEX; + link.link_speed = ETH_SPEED_NUM_100M; break; - case IXGBE_LINK_SPEED_100_FULL: -- 2.20.1