From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26BEAA04F0 for ; Thu, 19 Dec 2019 15:42:00 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1B8FA1C02A; Thu, 19 Dec 2019 15:42:00 +0100 (CET) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by dpdk.org (Postfix) with ESMTP id 769051C024 for ; Thu, 19 Dec 2019 15:41:58 +0100 (CET) Received: by mail-wm1-f51.google.com with SMTP id u2so5869308wmc.3 for ; Thu, 19 Dec 2019 06:41:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=icfHowfEIlKm4iXUAQ2g8OwMVQcy0ZpFrVQ1yppXsxo=; b=M1kHXqLHZfZh6v9zehj7LGngyb2Q7e5+VTIi3btnS3n7xG9w/r7gq/10+7wMGFS6QN 3iwcvyPGF/r1nxAoaOOZn69ZHOqpahzcozm43ho7eTFgRTjnT20W5YDlRZcsorBptpyU NpcXdDIqkIYIp1Ey0cXxYfnBEjZt3e2m1YnG2UA1ZvFOs4AI5TiMG1cx+GGzL7kguud4 qcCE9nuUDXAT145n4u5PxJajpSpClKL9pU8MaO4BfTb+wYxsKFDQlsuwyLxDhkAWOA61 oE8G7/s2FQW8pHhJfM+LUmSr0EEkNQ6kyWOcVjBK8Wxb999UY8gruI6kDAp1RhX5xNdt RncQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=icfHowfEIlKm4iXUAQ2g8OwMVQcy0ZpFrVQ1yppXsxo=; b=bGvHoDqQK2vksYDeXe4/xIs7pO6Z1hxSIKkEOER/x28bxayRjsREXtImGlGjmo0+lU DMf8GozokSTt0pbUZ7nujeRGe1egGmFneElJfEuwKrHsoKOLLkWrHW3wvwGjktenlsjj 7TLOdB6Tfhlci9FlapjJKtX5fdH4NGjcfDlTCmGPKWvAgkeWSnpnuFdKDmHeG6xPZTfS SF7n7MJXDWDIizXvGqYvoO0MmM59Z4L92riEy2AceR88d229QSuex6aXRAb0U4l8iXir NLZJoXcqCGOBsNLeplyZU4Z3Oa3AFutSB27K2vGlKKd5ScR1oXIOREN0HKiKvwvVfP/C shKQ== X-Gm-Message-State: APjAAAVUlNt2WTPSru1OovwY2C2DNWltbulHIZkOkW/CMBYCBbIZQ4Lu 8Unj9d/TH7ANflouCY8i1DW+OygKJmY= X-Google-Smtp-Source: APXvYqz99BOUPtxCzuxZeY5x/yvzlPpX5UPbyxsTnxc4lcqS9iLdHGXqbzSz7abK6TgsP8mIz9NS7Q== X-Received: by 2002:a05:600c:a:: with SMTP id g10mr10834839wmc.14.1576766518190; Thu, 19 Dec 2019 06:41:58 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id w8sm6458214wmm.0.2019.12.19.06.41.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 06:41:57 -0800 (PST) From: luca.boccassi@gmail.com To: Ferruh Yigit Cc: Bruce Richardson , dpdk stable Date: Thu, 19 Dec 2019 14:34:37 +0000 Message-Id: <20191219143447.21506-130-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191219143447.21506-1-luca.boccassi@gmail.com> References: <20191219143447.21506-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'mk: remove library search path from binary' has been queued to LTS release 17.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/21/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 7da96b000ea54eaf435b9aa8f3c000877add9009 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Fri, 22 Nov 2019 11:30:23 +0000 Subject: [PATCH] mk: remove library search path from binary [ upstream commit 6b01864cc9c59a731dbc727a96995fd2b2ff452f ] This patch functionally reverts the patch in fixes line to not have any hardcoded library path in the final binary for the security reasons, in case this binary distributed to production environment. RPATH only added in RTE_DEVEL_BUILD case and this binary shouldn't distributed, but still removing it to be cautious. Fixes: 8919f73bcbaa ("mk: add build directory to library search path") Suggested-by: Bruce Richardson Signed-off-by: Ferruh Yigit --- mk/rte.app.mk | 4 ---- 1 file changed, 4 deletions(-) diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 6a6a7452e2..4a03e83141 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -248,10 +248,6 @@ filter-libs = \ LDLIBS := $(call filter-libs,$(LDLIBS)) -ifeq ($(RTE_DEVEL_BUILD)$(CONFIG_RTE_BUILD_SHARED_LIB),yy) -LDFLAGS += -rpath=$(RTE_SDK_BIN)/lib -endif - MAPFLAGS = -Map=$@.map --cref .PHONY: all -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-12-19 14:32:31.495650132 +0000 +++ 0130-mk-remove-library-search-path-from-binary.patch 2019-12-19 14:32:26.337302426 +0000 @@ -1,8 +1,10 @@ -From 6b01864cc9c59a731dbc727a96995fd2b2ff452f Mon Sep 17 00:00:00 2001 +From 7da96b000ea54eaf435b9aa8f3c000877add9009 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Fri, 22 Nov 2019 11:30:23 +0000 Subject: [PATCH] mk: remove library search path from binary +[ upstream commit 6b01864cc9c59a731dbc727a96995fd2b2ff452f ] + This patch functionally reverts the patch in fixes line to not have any hardcoded library path in the final binary for the security reasons, in case this binary distributed to production environment. @@ -11,40 +13,18 @@ distributed, but still removing it to be cautious. Fixes: 8919f73bcbaa ("mk: add build directory to library search path") -Cc: stable@dpdk.org Suggested-by: Bruce Richardson Signed-off-by: Ferruh Yigit --- - devtools/test-null.sh | 2 ++ - mk/rte.app.mk | 4 ---- - 2 files changed, 2 insertions(+), 4 deletions(-) - -diff --git a/devtools/test-null.sh b/devtools/test-null.sh -index d82c6ad193..72aa82b16f 100755 ---- a/devtools/test-null.sh -+++ b/devtools/test-null.sh -@@ -11,6 +11,7 @@ coremask=${2:-3} # default using cores 0 and 1 - eal_options=$3 - testpmd_options=$4 - -+[ -f "$testpmd" ] && build=$(dirname $(dirname $testpmd)) - [ -f "$testpmd" ] || testpmd=$build/app/dpdk-testpmd - [ -f "$testpmd" ] || testpmd=$build/app/testpmd - if [ ! -f "$testpmd" ] ; then -@@ -19,6 +20,7 @@ if [ ! -f "$testpmd" ] ; then - fi - - if ldd $testpmd | grep -q librte_ ; then -+ export LD_LIBRARY_PATH=$build/lib:$LD_LIBRARY_PATH - libs='-d librte_mempool_ring.so -d librte_pmd_null.so' - else - libs= + mk/rte.app.mk | 4 ---- + 1 file changed, 4 deletions(-) + diff --git a/mk/rte.app.mk b/mk/rte.app.mk -index a278552c62..05ea034b99 100644 +index 6a6a7452e2..4a03e83141 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk -@@ -379,10 +379,6 @@ filter-libs = \ +@@ -248,10 +248,6 @@ filter-libs = \ LDLIBS := $(call filter-libs,$(LDLIBS))