From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB6EBA04F0 for ; Thu, 19 Dec 2019 15:42:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C200C1C01F; Thu, 19 Dec 2019 15:42:07 +0100 (CET) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 6DEBF1C044 for ; Thu, 19 Dec 2019 15:42:05 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id y17so6252003wrh.5 for ; Thu, 19 Dec 2019 06:42:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gU6h/shkHnNifWF22adrqkpuH/t3PoxMuS4aOUGN+uM=; b=UfFSmRqrm5j1Xw9LxrFVF9fNXeRRHXRxPyydMjzTTt87hocn80B0roCjPXu0EZ3QMe CMcbbhprgEXD5w5TQ7e9ULJlp8KfEVDlXZwiix7aqlD9n2k6kAJ2tPnd4ireakd+D1gT VrKDtQzTEFZ6IfckmwJFJH9b1tW5GXQWzrUdeyyCKgC9gP+1Zz+ysoQBbHuC80Si4fIz 5TnHPwwt72Kme5HrGysAQbMdT2nhthlylNuSr2HOtYVWBijf/JU5N2+4z/YHiPXtJ8Hb 1sKDsWGPdwV7h4qcvjbaKt0WBnJUqMVwXsWBUFAZoaGg6JfmGsT1zQI1Av3wVUACge01 CNDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gU6h/shkHnNifWF22adrqkpuH/t3PoxMuS4aOUGN+uM=; b=grxVhRh24pbnBdnSvUWYqwDaTRDve/oYw1CJdik4Wa1oG2p3kF6IGf73bVJ+Ei8wZ9 guPPytmoIcUYBa/dsqdJAAoYtUyHcr/VyWNfyVF90UjAYnA8LkSXnpLrHxtN9ZS5Vn13 jovJ0onyXY1SMI7Rmrf0g8ihOjG6lgmQgxKWsMdFyYxsm6luec9XXX4zmASyCKFWQlpD PF/KjF74o0iyF7CguLqK9TU0HFgyUsK/0M50bu8XmR5qgi+M5UeQSEUWtOHUaVG+dlyM ATDwqE959R1tLqtRfA4ZBHvf/0SwT9j6/bvD2WMI1r8lBIq2kO5ASDH3gvf+rzPUT/0g XdcQ== X-Gm-Message-State: APjAAAUNO7hluuRZqBdtGFrV6e3sh8x0/lNOMpgWzNIcjIuRwuWqNaWa 5kZSzPNFF2Eb6uDAfz3OCuQ= X-Google-Smtp-Source: APXvYqwNwHFkLKzZ8syQOWXaaCG6NqDcx0Rz676ANgKQlh/AspcUgY7jCD7yYjcIofZT9N01LXADQA== X-Received: by 2002:a5d:6346:: with SMTP id b6mr9775830wrw.354.1576766525166; Thu, 19 Dec 2019 06:42:05 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id b15sm6234332wmj.13.2019.12.19.06.42.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 06:42:04 -0800 (PST) From: luca.boccassi@gmail.com To: Lunyuan Cui Cc: Wenzhuo Lu , dpdk stable Date: Thu, 19 Dec 2019 14:34:43 +0000 Message-Id: <20191219143447.21506-136-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191219143447.21506-1-luca.boccassi@gmail.com> References: <20191219143447.21506-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/e1000: fix link status' has been queued to LTS release 17.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/21/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 1706ce3713d3d956c416e94444d9292c4bd86c14 Mon Sep 17 00:00:00 2001 From: Lunyuan Cui Date: Wed, 13 Nov 2019 12:46:59 +0000 Subject: [PATCH] net/e1000: fix link status [ upstream commit a407d7c2ddfe05d0f13ca6170b1b8849023347e9 ] The link status got from link status register was not correct, because register has been reset when ports reset. After port reset, set the link status down. Fixes: c431ec66c54c ("net/igb: support setting link up or down") Signed-off-by: Lunyuan Cui Acked-by: Wenzhuo Lu --- drivers/net/e1000/igb_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index cef6fded96..daf9d2fc3d 100644 --- a/drivers/net/e1000/igb_ethdev.c +++ b/drivers/net/e1000/igb_ethdev.c @@ -956,6 +956,8 @@ eth_igb_dev_init(struct rte_eth_dev *eth_dev) /* enable support intr */ igb_intr_enable(eth_dev); + eth_igb_dev_set_link_down(eth_dev); + /* initialize filter info */ memset(filter_info, 0, sizeof(struct e1000_filter_info)); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-12-19 14:32:31.730942554 +0000 +++ 0136-net-e1000-fix-link-status.patch 2019-12-19 14:32:26.357302822 +0000 @@ -1,14 +1,15 @@ -From a407d7c2ddfe05d0f13ca6170b1b8849023347e9 Mon Sep 17 00:00:00 2001 +From 1706ce3713d3d956c416e94444d9292c4bd86c14 Mon Sep 17 00:00:00 2001 From: Lunyuan Cui Date: Wed, 13 Nov 2019 12:46:59 +0000 Subject: [PATCH] net/e1000: fix link status +[ upstream commit a407d7c2ddfe05d0f13ca6170b1b8849023347e9 ] + The link status got from link status register was not correct, because register has been reset when ports reset. After port reset, set the link status down. Fixes: c431ec66c54c ("net/igb: support setting link up or down") -Cc: stable@dpdk.org Signed-off-by: Lunyuan Cui Acked-by: Wenzhuo Lu @@ -17,10 +18,10 @@ 1 file changed, 2 insertions(+) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c -index 2d2dc9cbef..a3e30dbe5a 100644 +index cef6fded96..daf9d2fc3d 100644 --- a/drivers/net/e1000/igb_ethdev.c +++ b/drivers/net/e1000/igb_ethdev.c -@@ -891,6 +891,8 @@ eth_igb_dev_init(struct rte_eth_dev *eth_dev) +@@ -956,6 +956,8 @@ eth_igb_dev_init(struct rte_eth_dev *eth_dev) /* enable support intr */ igb_intr_enable(eth_dev);