From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53EA5A04F3 for ; Thu, 19 Dec 2019 15:36:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4944D1BF80; Thu, 19 Dec 2019 15:36:36 +0100 (CET) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id B44CD1BF80 for ; Thu, 19 Dec 2019 15:36:34 +0100 (CET) Received: by mail-wm1-f67.google.com with SMTP id q9so5674117wmj.5 for ; Thu, 19 Dec 2019 06:36:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eqSTkhirAXbAEYPlkDkFLLZb8nQlIYuH7/Glp+YtQBo=; b=Whjqho19YjNjAMXzTBhn2Xa/ybx9DUlGRcZj7Bq+T6HdP2UM/gXSF1W3VM/5EriMAi U/gIP9e3HscsjosxSufHh6fxTxnsYa/cL7+noG003c3tmgBg9m45DWfSCbCd9pwcncb2 0wjCDQaVb22DSCymGoJLtJppPk7249+bgD32Kjuk5wRLC73LI1L7ZW3rTQxzVM14ZKpN RGS9azbJFxLqgWuGmRYkfyVxCOsgyEa3zhk5mxeX9z7spY8XbDJodFMAILb+UdRQ/J81 eAVfpUlxJNf2FUrEaPOd6dQ0cPDtNpx94Ty1PMYnCZh6Yh/B0Z7EhdZsSFpztcIMG/sN rtNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eqSTkhirAXbAEYPlkDkFLLZb8nQlIYuH7/Glp+YtQBo=; b=dk14LrWFhPa3GMb2qhjJ19ICvG4n78GxtlH1SUQ+qsyUqpp4hyoCJt+wmhndYHHUsp Gcuo2G378Qn+jLBoj/uoqHM7SFSH4UM1sTbFFtIRg77QWDFZ2tVe6iXjR0t3E2CvV5LL +T1XP2x9VKMtUTQXEcMobJH5/VW/3+8io8XKChkNoVZtALtSWIqbHz/IodmmLSndeBxa HnwYhmutdMYu0FrqsIelAvO0vQPqzGwi3GDUhQ69BBtBU2D23cx7PL9F/B3DVOcGtDwq Y7udScu3lRGHKUYQE+LYNiVA5duWL0Ir60MwmGjvXQsf9c5nXgtfb1OgzqdCgM/x8xnZ hjiA== X-Gm-Message-State: APjAAAVgbcpLguUDi/fvkDav6Rna+/lwWWiT30PzdqzpljpDl5BLarpC b1jzUAfjf00zY7DwlFrgbPQ= X-Google-Smtp-Source: APXvYqz9Jiu1b0gssUfFOdLLUrB9lY+0rtR0F/1aDIMR6M249fw0CnfbSYeUxyK8ss1liaZ2/d/1lw== X-Received: by 2002:a05:600c:2148:: with SMTP id v8mr10928209wml.111.1576766194462; Thu, 19 Dec 2019 06:36:34 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id m7sm5830295wma.39.2019.12.19.06.36.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 06:36:33 -0800 (PST) From: luca.boccassi@gmail.com To: Gavin Hu Cc: Steve Capper , Ruifeng Wang , Phil Yang , Ajit Khaparde , dpdk stable Date: Thu, 19 Dec 2019 14:33:07 +0000 Message-Id: <20191219143447.21506-40-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191219143447.21506-1-luca.boccassi@gmail.com> References: <20191219143447.21506-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bnxt: remove duplicate barrier' has been queued to LTS release 17.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/21/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From acd94bdd9d93194758dc47a998fab28d2117860d Mon Sep 17 00:00:00 2001 From: Gavin Hu Date: Mon, 16 Sep 2019 19:27:16 +0800 Subject: [PATCH] net/bnxt: remove duplicate barrier [ upstream commit 4a1721107c30603e078a611e99a4183de178fd7d ] As there is an inclusive rte_io_wmb within the following rte_write32() API who rings the doorbell, this makes the above rte_wmb unnecessary and remove it. Fixes: 1cd45aeb3270 ("net/bnxt: support Stratus VF device") Signed-off-by: Gavin Hu Reviewed-by: Steve Capper Reviewed-by: Ruifeng Wang Reviewed-by: Phil Yang Acked-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 815bad97b7..a28439f51c 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -123,9 +123,6 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg, data = (uint32_t *)&short_input; msg_len = sizeof(short_input); - /* Sync memory write before updating doorbell */ - rte_wmb(); - max_req_len = BNXT_HWRM_SHORT_REQ_LEN; } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-12-19 14:32:27.931104213 +0000 +++ 0040-net-bnxt-remove-duplicate-barrier.patch 2019-12-19 14:32:25.901293781 +0000 @@ -1,14 +1,15 @@ -From 4a1721107c30603e078a611e99a4183de178fd7d Mon Sep 17 00:00:00 2001 +From acd94bdd9d93194758dc47a998fab28d2117860d Mon Sep 17 00:00:00 2001 From: Gavin Hu Date: Mon, 16 Sep 2019 19:27:16 +0800 Subject: [PATCH] net/bnxt: remove duplicate barrier +[ upstream commit 4a1721107c30603e078a611e99a4183de178fd7d ] + As there is an inclusive rte_io_wmb within the following rte_write32() API who rings the doorbell, this makes the above rte_wmb unnecessary and remove it. Fixes: 1cd45aeb3270 ("net/bnxt: support Stratus VF device") -Cc: stable@dpdk.org Signed-off-by: Gavin Hu Reviewed-by: Steve Capper @@ -20,10 +21,10 @@ 1 file changed, 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c -index 174dc75d54..e73d8ed76a 100644 +index 815bad97b7..a28439f51c 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c -@@ -127,9 +127,6 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg, +@@ -123,9 +123,6 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg, data = (uint32_t *)&short_input; msg_len = sizeof(short_input);