From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31320A04F3 for ; Thu, 19 Dec 2019 15:35:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 26FC41B9BF; Thu, 19 Dec 2019 15:35:18 +0100 (CET) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by dpdk.org (Postfix) with ESMTP id 7CAF31B9BF for ; Thu, 19 Dec 2019 15:35:16 +0100 (CET) Received: by mail-wm1-f52.google.com with SMTP id m24so5656204wmc.3 for ; Thu, 19 Dec 2019 06:35:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fQE7nwAfH73xpohIsP7W61DW1e/1rsV7q4M4qkseTu8=; b=qGCHm19cPToCR4WDzperHByLhKqjnpPZ9qXGcdm7xfYUi752ldv6TXmzeXpdWGhzuQ ZytI6y5sZ2bxCYCbb1udM5Gvkhce8ieEGdu9Q2VkBpE0qi475gQcKhwA1r/kAGl6VV5Z lx6ZAyyOpX2PGGUyxCm8DB3tu56u3Rp/55PtV4jPqlVtwM+Od/5S/LipHCvfBXeMlD5x i7I9ON6NGXwm8afAws6xVgxgCuwZPeCEMIZ2iqiSkTD4F1WGn8oAXwav6Hr3ai0S3wIb 9yV6H18jl0aomQTIIzHodz81z/v3bOjJYHdNPX0+CB0sXS+LGU96iScyTvdVy0tdYI6x Gcxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fQE7nwAfH73xpohIsP7W61DW1e/1rsV7q4M4qkseTu8=; b=de18UoGbH0k0IUjaAGZ0NkzO12KRohuJ7R+wyi3i0A+fTFpmcPZceXqhZuHUonK+iC V9hNiD6zidvnIexvHx+x+5yH0fsseC0bfTpsehfMX9F8WcUWvU3m24YwKm4gGDfYRCzp Q09aXNV4K1U602NMFNTXvqiVTf9Ezc36RsOOofb6jrSZrglc+iy6yLgW/P1I858XPpXE ugiRTSrsZtYUPiOBniQfwokHNopA0Wabxh1FUC6j/Nedk4Wu1A7hUYHTVy6EAgsqdtwz KNDQIH73KVcc009mz1WjqexGML3OyDIuhr5DgT7MRVP8syFWnIqb7d7B1QFkv9eflNSL +t1g== X-Gm-Message-State: APjAAAWgNv7JdqlvaIjfFwGtqBG6lm9GxqaBMPXIgnK8d1YQhGGplOoQ lLCXTGn/Ni04yu5OyXwcD2A= X-Google-Smtp-Source: APXvYqw0i8B6C7QAX/76jQuw82wJTcOJ6geugjPoKcoFgP2s4scOHKgWVWTmu+xj76eJ6/CGDphdfw== X-Received: by 2002:a1c:1b41:: with SMTP id b62mr10158272wmb.53.1576766116202; Thu, 19 Dec 2019 06:35:16 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id d12sm6512991wrp.62.2019.12.19.06.35.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 06:35:15 -0800 (PST) From: luca.boccassi@gmail.com To: Gavin Hu Cc: Ruifeng Wang , Steve Capper , dpdk stable Date: Thu, 19 Dec 2019 14:32:34 +0000 Message-Id: <20191219143447.21506-7-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191219143447.21506-1-luca.boccassi@gmail.com> References: <20191219143447.21506-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/i40e: remove memory barrier from NEON Rx' has been queued to LTS release 17.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/21/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From cbb2fc535ac9338f55a8cd419e4b93ff31f3dbc7 Mon Sep 17 00:00:00 2001 From: Gavin Hu Date: Tue, 13 Aug 2019 18:43:30 +0800 Subject: [PATCH] net/i40e: remove memory barrier from NEON Rx [ upstream commit 78b50591c8e7ae3d010e8f4005e0e95c17800941 ] For x86, the descriptors needs to be loaded in order, so in between two descriptors loading, there is a compiler barrier in place.[1] For aarch64, a patch [2] is in place to survive with discontinuous DD bits, the barriers can be removed to take full advantage of out-of-order execution. 50% performance gain in the RFC2544 NDR test was measured on ThunderX2. 12.50% performance gain in the RFC2544 NDR test was measured on Ampere eMAG80 platform. [1] http://inbox.dpdk.org/users/039ED4275CED7440929022BC67E7061153D71548@ SHSMSX105.ccr.corp.intel.com/ [2] https://mails.dpdk.org/archives/stable/2017-October/003324.html Fixes: ae0eb310f253 ("net/i40e: implement vector PMD for ARM") Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang Reviewed-by: Steve Capper --- drivers/net/i40e/i40e_rxtx_vec_neon.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c b/drivers/net/i40e/i40e_rxtx_vec_neon.c index b5685e2b91..3fb7de2dbc 100644 --- a/drivers/net/i40e/i40e_rxtx_vec_neon.c +++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c @@ -314,7 +314,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts, /* Read desc statuses backwards to avoid race condition */ /* A.1 load 4 pkts desc */ descs[3] = vld1q_u64((uint64_t *)(rxdp + 3)); - rte_rmb(); /* B.2 copy 2 mbuf point into rx_pkts */ vst1q_u64((uint64_t *)&rx_pkts[pos], mbp1); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-12-19 14:32:26.615683291 +0000 +++ 0007-net-i40e-remove-memory-barrier-from-NEON-Rx.patch 2019-12-19 14:32:25.401283865 +0000 @@ -1,8 +1,10 @@ -From 78b50591c8e7ae3d010e8f4005e0e95c17800941 Mon Sep 17 00:00:00 2001 +From cbb2fc535ac9338f55a8cd419e4b93ff31f3dbc7 Mon Sep 17 00:00:00 2001 From: Gavin Hu Date: Tue, 13 Aug 2019 18:43:30 +0800 Subject: [PATCH] net/i40e: remove memory barrier from NEON Rx +[ upstream commit 78b50591c8e7ae3d010e8f4005e0e95c17800941 ] + For x86, the descriptors needs to be loaded in order, so in between two descriptors loading, there is a compiler barrier in place.[1] For aarch64, a patch [2] is in place to survive with discontinuous DD @@ -18,7 +20,6 @@ [2] https://mails.dpdk.org/archives/stable/2017-October/003324.html Fixes: ae0eb310f253 ("net/i40e: implement vector PMD for ARM") -Cc: stable@dpdk.org Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang @@ -28,10 +29,10 @@ 1 file changed, 1 deletion(-) diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c b/drivers/net/i40e/i40e_rxtx_vec_neon.c -index 83572ef843..5555e9b5cf 100644 +index b5685e2b91..3fb7de2dbc 100644 --- a/drivers/net/i40e/i40e_rxtx_vec_neon.c +++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c -@@ -285,7 +285,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts, +@@ -314,7 +314,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts, /* Read desc statuses backwards to avoid race condition */ /* A.1 load 4 pkts desc */ descs[3] = vld1q_u64((uint64_t *)(rxdp + 3));