From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35D74A04F3 for ; Thu, 19 Dec 2019 15:37:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2B5FE1BF92; Thu, 19 Dec 2019 15:37:47 +0100 (CET) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 1156B1BFB2 for ; Thu, 19 Dec 2019 15:37:46 +0100 (CET) Received: by mail-wm1-f65.google.com with SMTP id d73so5682917wmd.1 for ; Thu, 19 Dec 2019 06:37:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GYCe79MDCO/OM3hkuN7np0AQRLNrxOSb1RfNjhq5enA=; b=r0Asm73LqKBbgCJ39q4mYXkHVKNg8m0H0UoCH4tjxhyzhdBNIqlYlMinSDWAUnMWHX eQsacO2gu8S1Bzx6YlwAxaQWGoZdQXKAv644eMAR9jfYD9q3k04gtw9+L8JZdDGaymNR sGQEIOunFeO+bd36cs+T1z44yogzhTsOz14oKEKeuZBsFJlZrk1uD0IfK8JWdMUyiZiI toE+tWQvynFB4iBS3sxV8/pq0p8IfgYNlcutDvOjaj8mLm+2A1CtpLyjUocONz+6X0Eo NES0B/k+ZMi3HIrYuJ5ux7JytL8XbSfn5e9CJuYoMNOcFFOMt/M9p7k+w+/V7JOu9/L/ uxWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GYCe79MDCO/OM3hkuN7np0AQRLNrxOSb1RfNjhq5enA=; b=OGRtm5H1EKXTUAKXSzAB43wDbhywdH4RWfPr3RvMgnrjs1l7blQL33x4wkpkmef6xt nLvdu6MHXSp9cB1rfIA1HBtBTV4d5z+vGVhXVxYetrq3quoWrcQqUpmBJv6+Hf/TFI+/ TWttzPClhwvOxHYcA8OK1L6lxjYKNZhVUKennqqJbc4FpEDTDUDiThIjuOba97VfjSky Jg82usmdEsJZ5FfFpbGBxyTkA+keLDdBMLkuJ76r/eJ4dkIgNd9QYBTE3/Cykj/kfjf9 QvFfA9u9vYg4b63l88/jK62eE/H2OKQEExzJHz+3HBWUunL4+CFVb2h6bcTU4cyRoBc4 aGfw== X-Gm-Message-State: APjAAAU4/Z1qI4lzgqiswmxZzOtdRL3KIghGr8TxfkDd8lQWLzFCgHQl bo7WWM0bjK+2zfLhnZ0h3Di61cg8NK0= X-Google-Smtp-Source: APXvYqyvkLEMLZcfRGh6r8vO9SglL6rTrHkM9/TOP8FyKutb21OaCUjPT+/VQR2ivbXUWioCIV5ZmA== X-Received: by 2002:a1c:4b0a:: with SMTP id y10mr10955083wma.78.1576766265820; Thu, 19 Dec 2019 06:37:45 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id b10sm6584834wrt.90.2019.12.19.06.37.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 06:37:45 -0800 (PST) From: luca.boccassi@gmail.com To: Joyce Kong Cc: Xiao Zhang , Xiaolong Ye , dpdk stable Date: Thu, 19 Dec 2019 14:33:41 +0000 Message-Id: <20191219143447.21506-74-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191219143447.21506-1-luca.boccassi@gmail.com> References: <20191219143447.21506-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/ixgbe: fix address of first segment' has been queued to LTS release 17.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/21/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From e2d7c98653f151eaa64964352f7e3fde22b35065 Mon Sep 17 00:00:00 2001 From: Joyce Kong Date: Tue, 24 Sep 2019 13:48:45 +0800 Subject: [PATCH] net/ixgbe: fix address of first segment [ upstream commit 648255d43e4a820274cbb02cca3ece445d8de302 ] This patch fixes (dereference after null check) coverity issue. The address of first segmented packets was not set correctly during reassembling packets which led to this issue. Coverity issue: 13245 Fixes: 8a44c15aa57d ("net/ixgbe: extract non-x86 specific code from vector driver") Signed-off-by: Joyce Kong Reviewed-by: Xiao Zhang Reviewed-by: Xiaolong Ye --- drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c index 4d7726f406..0b38d97fa0 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c @@ -403,6 +403,7 @@ ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, i++; if (i == nb_bufs) return nb_bufs; + rxq->pkt_first_seg = rx_pkts[i]; } return i + reassemble_packets(rxq, &rx_pkts[i], nb_bufs - i, &split_flags[i]); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-12-19 14:32:29.261099526 +0000 +++ 0074-net-ixgbe-fix-address-of-first-segment.patch 2019-12-19 14:32:26.165299015 +0000 @@ -1,15 +1,16 @@ -From 648255d43e4a820274cbb02cca3ece445d8de302 Mon Sep 17 00:00:00 2001 +From e2d7c98653f151eaa64964352f7e3fde22b35065 Mon Sep 17 00:00:00 2001 From: Joyce Kong Date: Tue, 24 Sep 2019 13:48:45 +0800 Subject: [PATCH] net/ixgbe: fix address of first segment +[ upstream commit 648255d43e4a820274cbb02cca3ece445d8de302 ] + This patch fixes (dereference after null check) coverity issue. The address of first segmented packets was not set correctly during reassembling packets which led to this issue. Coverity issue: 13245 Fixes: 8a44c15aa57d ("net/ixgbe: extract non-x86 specific code from vector driver") -Cc: stable@dpdk.org Signed-off-by: Joyce Kong Reviewed-by: Xiao Zhang @@ -19,10 +20,10 @@ 1 file changed, 1 insertion(+) diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c -index eeb825911c..26c0ef5aec 100644 +index 4d7726f406..0b38d97fa0 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c -@@ -375,6 +375,7 @@ ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, +@@ -403,6 +403,7 @@ ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, i++; if (i == nb_bufs) return nb_bufs;