From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F7F6A04F0 for ; Thu, 19 Dec 2019 15:40:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3E6931BFDA; Thu, 19 Dec 2019 15:40:19 +0100 (CET) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id EA5FE1BFCD for ; Thu, 19 Dec 2019 15:40:17 +0100 (CET) Received: by mail-wm1-f67.google.com with SMTP id a5so5683647wmb.0 for ; Thu, 19 Dec 2019 06:40:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WOl7r+l1b2ICQekJeUxozBFt07N6Y1SpFqT0gDxBLDs=; b=fbgIuLReDfigGgUvdv2/SL1fQimqq+RF17qXBq3NPLEi8oskoSPNkyiZ3B6OqfY6Xb RiGUlujBy/9BpGHW6gLq3NivHgF+44yEGPJlpr4rckcUO6jMrGORH7fy4pb5ZEq3494Y znBhXtiPOG9lEPNAZjPdFlhlQ19KYGZOUwqYJaEUoQqpn80F4s5GmrnU+6Q0bZ362cqj +tecBhjKwkNiCXbdX+elF8amrcY2s6oCciqiNHZiNVgpZ5P6CfLXsOul9tI6VGzDiKYw SNTJ/XDGwzV8Gsh+ldiySZoz+PFpQYOVgBGP4r62rpgGvV3bjbch40QRY0jAzQ7X0Der P2lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WOl7r+l1b2ICQekJeUxozBFt07N6Y1SpFqT0gDxBLDs=; b=q1K8/pysqKjiqNQvYNrjC8Qsb3VKRGi5FzQjLBzMI5LyEt6qyNajuPcKpn0WDNHASL JI8snUgafvl3pyzQ+I5DkIFivXzzkedbG9rbvZ3xa5/an1UZ3OX/pGgClAOzxQ6/XlL0 PgNbGA2jVruL7ifFOYIsJ8k/Gh/UlRkeJF9/P3/BzUO0JvfN50UWsg46ak6vBVEXg38u z+7CfnEEZ5RscMcvi7acwOJwsANp0sAij1R5S8dJOdwZqWoq1G0+rqa2vQIDVCI9ucw5 zDQNtfpjKK3JZzFssShMxzHKPp2sFQwLvGM4qOVL3ytS4Ls8WuWPlZrj4PCU0Ne3Ukvy bgdw== X-Gm-Message-State: APjAAAWpCynDKW2fEVU8vBRSApFIYmiPJjcYj9yrm1eO2J8rPuDpeRM7 NE8+r96Ep+/EAcocykBYor4= X-Google-Smtp-Source: APXvYqymeTagM6pTLQLwvHYWEW3Tt0Gc60LtA6NZ2+iuRl5ncnuKfviYBIerGRMWNi+IzMSJx98oXw== X-Received: by 2002:a1c:9d8b:: with SMTP id g133mr10094302wme.27.1576766417583; Thu, 19 Dec 2019 06:40:17 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id x26sm6029101wmc.30.2019.12.19.06.40.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 06:40:17 -0800 (PST) From: luca.boccassi@gmail.com To: Xiao Zhang Cc: Marvin Liu , David Hunt , dpdk stable Date: Thu, 19 Dec 2019 14:34:01 +0000 Message-Id: <20191219143447.21506-94-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191219143447.21506-1-luca.boccassi@gmail.com> References: <20191219143447.21506-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'examples/l3fwd-power: fix Rx interrupt disabling' has been queued to LTS release 17.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/21/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 1fce227f6a11f1e9968ce93ebe6923f53d854469 Mon Sep 17 00:00:00 2001 From: Xiao Zhang Date: Wed, 11 Sep 2019 00:10:14 +0800 Subject: [PATCH] examples/l3fwd-power: fix Rx interrupt disabling [ upstream commit 0412cfeff907bb9102a2ca834e95ef8c6767f538 ] Interrupt will not be received when disabling RX interrupt without synchronization mechanism sometimes which leads to wake up issue. Add spinlock to fix it. Fixes: b736d64787 ("examples/l3fwd-power: disable Rx interrupt when waking up") Signed-off-by: Xiao Zhang Reviewed-by: Marvin Liu Acked-by: David Hunt --- examples/l3fwd-power/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 50c3702f6c..c669f6a441 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -813,7 +813,9 @@ sleep_until_rx_interrupt(int num) port_id = ((uintptr_t)data) >> CHAR_BIT; queue_id = ((uintptr_t)data) & RTE_LEN2MASK(CHAR_BIT, uint8_t); + rte_spinlock_lock(&(locks[port_id])); rte_eth_dev_rx_intr_disable(port_id, queue_id); + rte_spinlock_unlock(&(locks[port_id])); RTE_LOG(INFO, L3FWD_POWER, "lcore %u is waked up from rx interrupt on" " port %d queue %d\n", -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-12-19 14:32:30.082985348 +0000 +++ 0094-examples-l3fwd-power-fix-Rx-interrupt-disabling.patch 2019-12-19 14:32:26.221300126 +0000 @@ -1,14 +1,15 @@ -From 0412cfeff907bb9102a2ca834e95ef8c6767f538 Mon Sep 17 00:00:00 2001 +From 1fce227f6a11f1e9968ce93ebe6923f53d854469 Mon Sep 17 00:00:00 2001 From: Xiao Zhang Date: Wed, 11 Sep 2019 00:10:14 +0800 Subject: [PATCH] examples/l3fwd-power: fix Rx interrupt disabling +[ upstream commit 0412cfeff907bb9102a2ca834e95ef8c6767f538 ] + Interrupt will not be received when disabling RX interrupt without synchronization mechanism sometimes which leads to wake up issue. Add spinlock to fix it. Fixes: b736d64787 ("examples/l3fwd-power: disable Rx interrupt when waking up") -Cc: stable@dpdk.org Signed-off-by: Xiao Zhang Reviewed-by: Marvin Liu @@ -18,10 +19,10 @@ 1 file changed, 2 insertions(+) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c -index a03f64a1a3..d049d8a5dc 100644 +index 50c3702f6c..c669f6a441 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c -@@ -880,7 +880,9 @@ sleep_until_rx_interrupt(int num) +@@ -813,7 +813,9 @@ sleep_until_rx_interrupt(int num) port_id = ((uintptr_t)data) >> CHAR_BIT; queue_id = ((uintptr_t)data) & RTE_LEN2MASK(CHAR_BIT, uint8_t);