From: Ferruh Yigit <ferruh.yigit@intel.com> To: Maxime Coquelin <maxime.coquelin@redhat.com>, Xuan Ding <xuan.ding@intel.com>, tiwei.bie@intel.com, zhihong.wang@intel.com, yong.liu@intel.com, xiaolong.ye@intel.com Cc: dev@dpdk.org, stable@dpdk.org Subject: Re: [dpdk-stable] [PATCH v5] net/virtio-user: fix packed ring server mode Date: Wed, 15 Jan 2020 15:40:40 +0000 Message-ID: <201b8f42-674d-2df1-baa6-10b1671aa70f@intel.com> (raw) In-Reply-To: <2bbfce86-c26a-a93d-3ac4-fb8b18572f8f@redhat.com> On 1/15/2020 11:16 AM, Maxime Coquelin wrote: > > > On 1/15/20 7:13 AM, Xuan Ding wrote: >> This patch fixes the situation where data path does not work properly when >> vhost reconnects to virtio in server mode with packed ring. >> >> Currently, virtio and vhost share memory of vring. For split ring, vhost >> can read the status of descriptors directly from the available ring and >> the used ring during reconnection. Therefore, the data path can continue. >> >> But for packed ring, when reconnecting to virtio, vhost cannot get the >> status of descriptors via the descriptor ring. By resetting Tx >> and Rx queues, the data path can restart from the beginning. >> >> Fixes: 4c3f5822eb214 ("net/virtio: add packed virtqueue defines") >> Cc: stable@dpdk.org >> >> Signed-off-by: Xuan Ding <xuan.ding@intel.com> >> --- >> >> v5: >> * Fixed two spelling mistakes in the commit log. >> * Added notice message when resetting vring. >> >> v4: >> * Moved change log below '---' marker. >> >> v3: >> * Removed an extra asterisk from a comment. >> * Renamed device reset function and moved it to virtio_user_ethdev.c. >> >> v2: >> * Renamed queue reset functions and moved them to virtqueue.c. >> --- >> drivers/net/virtio/virtio_ethdev.c | 4 +- >> drivers/net/virtio/virtio_user_ethdev.c | 42 +++++++++++++++ >> drivers/net/virtio/virtqueue.c | 71 +++++++++++++++++++++++++ >> drivers/net/virtio/virtqueue.h | 4 ++ >> 4 files changed, 119 insertions(+), 2 deletions(-) > > Applied to dpdk-next-virtio/master > This was causing build error [1] on cross compilation [2], I am fixing it while merging [3], please double check in next-net. [1] .../drivers/net/virtio/virtio_user_ethdev.c:44:2: error: implicit declaration of function ‘rte_delay_ms’; did you mean ‘rte_realloc’? [-Werror=implicit-function-declaration] rte_delay_ms(1); [2] CROSS=/opt/aarch64/bin/aarch64-buildroot-linux-gnu- make -j64 [3] diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c index 9c9d3407f..f3b35d1bd 100644 --- a/drivers/net/virtio/virtio_user_ethdev.c +++ b/drivers/net/virtio/virtio_user_ethdev.c @@ -13,6 +13,7 @@ #include <rte_ethdev_vdev.h> #include <rte_bus_vdev.h> #include <rte_alarm.h> +#include <rte_cycles.h> #include "virtio_ethdev.h" #include "virtio_logs.h"
next prev parent reply other threads:[~2020-01-15 15:40 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-09 16:49 [dpdk-stable] [PATCH v1] " Xuan Ding 2019-12-09 8:51 ` [dpdk-stable] [dpdk-dev] " Liu, Yong 2019-12-12 11:08 ` Ding, Xuan 2019-12-18 2:24 ` [dpdk-stable] [PATCH v3] " Xuan Ding 2019-12-18 2:25 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong 2019-12-18 2:38 ` Ding, Xuan 2019-12-23 7:25 ` [dpdk-stable] [PATCH v4] " Xuan Ding 2020-01-14 15:04 ` Maxime Coquelin 2020-01-15 6:08 ` Ding, Xuan 2020-01-15 6:13 ` [dpdk-stable] [PATCH v5] " Xuan Ding 2020-01-15 10:47 ` Maxime Coquelin 2020-01-15 11:16 ` Maxime Coquelin 2020-01-15 15:40 ` Ferruh Yigit [this message] 2020-01-16 7:13 ` Ding, Xuan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201b8f42-674d-2df1-baa6-10b1671aa70f@intel.com \ --to=ferruh.yigit@intel.com \ --cc=dev@dpdk.org \ --cc=maxime.coquelin@redhat.com \ --cc=stable@dpdk.org \ --cc=tiwei.bie@intel.com \ --cc=xiaolong.ye@intel.com \ --cc=xuan.ding@intel.com \ --cc=yong.liu@intel.com \ --cc=zhihong.wang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git