patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH] net/af_xdp: fix redundant check for NEED WAKEUP
@ 2020-01-06 14:09 Xiao Wang
  2020-01-08 15:57 ` [dpdk-stable] [dpdk-dev] " Loftus, Ciara
  0 siblings, 1 reply; 3+ messages in thread
From: Xiao Wang @ 2020-01-06 14:09 UTC (permalink / raw)
  To: xiaolong.ye, qi.z.zhang; +Cc: dev, Xiao Wang, stable

Function kick_tx() has built-in detection on NEED_WAKEUP flag, so just
call it directly, like elsewhere in the driver.

Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks")
Cc: stable@dpdk.org

Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
---
 drivers/net/af_xdp/rte_eth_af_xdp.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c
index 2b1245ee4..d903e6c28 100644
--- a/drivers/net/af_xdp/rte_eth_af_xdp.c
+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
@@ -480,10 +480,7 @@ af_xdp_tx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 		tx_bytes += mbuf->pkt_len;
 	}
 
-#if defined(XDP_USE_NEED_WAKEUP)
-	if (xsk_ring_prod__needs_wakeup(&txq->tx))
-#endif
-		kick_tx(txq);
+	kick_tx(txq);
 
 out:
 	xsk_ring_prod__submit(&txq->tx, count);
-- 
2.15.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/af_xdp: fix redundant check for NEED WAKEUP
  2020-01-06 14:09 [dpdk-stable] [PATCH] net/af_xdp: fix redundant check for NEED WAKEUP Xiao Wang
@ 2020-01-08 15:57 ` " Loftus, Ciara
  2020-01-10 14:44   ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Loftus, Ciara @ 2020-01-08 15:57 UTC (permalink / raw)
  To: Wang, Xiao W, Ye, Xiaolong, Zhang, Qi Z; +Cc: dev, Wang, Xiao W, stable

> 
> Function kick_tx() has built-in detection on NEED_WAKEUP flag, so just
> call it directly, like elsewhere in the driver.
> 
> Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> ---
>  drivers/net/af_xdp/rte_eth_af_xdp.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c
> b/drivers/net/af_xdp/rte_eth_af_xdp.c
> index 2b1245ee4..d903e6c28 100644
> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c
> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
> @@ -480,10 +480,7 @@ af_xdp_tx_zc(void *queue, struct rte_mbuf **bufs,
> uint16_t nb_pkts)
>  		tx_bytes += mbuf->pkt_len;
>  	}
> 
> -#if defined(XDP_USE_NEED_WAKEUP)
> -	if (xsk_ring_prod__needs_wakeup(&txq->tx))
> -#endif
> -		kick_tx(txq);
> +	kick_tx(txq);
> 
>  out:
>  	xsk_ring_prod__submit(&txq->tx, count);
> --
> 2.15.1


Thanks for the patch.

Tested-by: Ciara Loftus <ciara.loftus@intel.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/af_xdp: fix redundant check for NEED WAKEUP
  2020-01-08 15:57 ` [dpdk-stable] [dpdk-dev] " Loftus, Ciara
@ 2020-01-10 14:44   ` Ferruh Yigit
  0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2020-01-10 14:44 UTC (permalink / raw)
  To: Loftus, Ciara, Wang, Xiao W, Ye, Xiaolong, Zhang, Qi Z; +Cc: dev, stable

On 1/8/2020 3:57 PM, Loftus, Ciara wrote:
>>
>> Function kick_tx() has built-in detection on NEED_WAKEUP flag, so just
>> call it directly, like elsewhere in the driver.
>>
>> Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
>> ---
>>  drivers/net/af_xdp/rte_eth_af_xdp.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c
>> b/drivers/net/af_xdp/rte_eth_af_xdp.c
>> index 2b1245ee4..d903e6c28 100644
>> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c
>> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
>> @@ -480,10 +480,7 @@ af_xdp_tx_zc(void *queue, struct rte_mbuf **bufs,
>> uint16_t nb_pkts)
>>  		tx_bytes += mbuf->pkt_len;
>>  	}
>>
>> -#if defined(XDP_USE_NEED_WAKEUP)
>> -	if (xsk_ring_prod__needs_wakeup(&txq->tx))
>> -#endif
>> -		kick_tx(txq);
>> +	kick_tx(txq);
>>
>>  out:
>>  	xsk_ring_prod__submit(&txq->tx, count);
>> --
>> 2.15.1
> 
> 
> Thanks for the patch.
> 
> Tested-by: Ciara Loftus <ciara.loftus@intel.com>
> 

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-06 14:09 [dpdk-stable] [PATCH] net/af_xdp: fix redundant check for NEED WAKEUP Xiao Wang
2020-01-08 15:57 ` [dpdk-stable] [dpdk-dev] " Loftus, Ciara
2020-01-10 14:44   ` Ferruh Yigit

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox