From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6D4D2A046B
	for <public@inbox.dpdk.org>; Thu,  9 Jan 2020 17:56:30 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 1D8271DEA4;
	Thu,  9 Jan 2020 17:56:30 +0100 (CET)
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 14E951DEA4
 for <stable@dpdk.org>; Thu,  9 Jan 2020 17:56:28 +0100 (CET)
Received: from 2606-a000-111b-43ee-0000-0000-0000-115f.inf6.spectrum.com
 ([2606:a000:111b:43ee::115f] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1ipa86-0003US-Ml; Thu, 09 Jan 2020 10:53:54 -0500
Date: Thu, 9 Jan 2020 10:53:49 -0500
From: Neil Horman <nhorman@tuxdriver.com>
To: Kevin Traynor <ktraynor@redhat.com>
Cc: stable@dpdk.org
Message-ID: <20200109155349.GD11396@hmswarspite.think-freely.org>
References: <20200109133433.12494-1-ktraynor@redhat.com>
 <20200109133433.12494-7-ktraynor@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200109133433.12494-7-ktraynor@redhat.com>
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Subject: Re: [dpdk-stable] [18.11 6/7] pmdinfogen: fix freebsd build
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>

On Thu, Jan 09, 2020 at 01:34:32PM +0000, Kevin Traynor wrote:
> rte_compat.h is needed as part of the fixed commit
> but it could not be found with meson on FreeBSD causing
> a build failure. Add it's include directory.
> 
> This is not an issue on DPDK master branch since
> rte_compat.h was moved under lib/eal.
> 
> Fixes: 3e41c8bc7584 ("eal: add ack interrupt API")
> 
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> Cc: Neil Horman <nhorman@tuxdriver.com>
> ---
>  buildtools/pmdinfogen/meson.build | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/buildtools/pmdinfogen/meson.build b/buildtools/pmdinfogen/meson.build
> index a219a8e96..ab2b20032 100644
> --- a/buildtools/pmdinfogen/meson.build
> +++ b/buildtools/pmdinfogen/meson.build
> @@ -4,4 +4,9 @@
>  pmdinfogen_inc = eal_inc
>  pmdinfogen_inc += include_directories('../../lib/librte_pci')
> +
> +if host_machine.system() == 'freebsd'
> +	pmdinfogen_inc += include_directories('../../lib/librte_compat')
> +endif
> +
Actually, is there a corresponding Makefile change that needs to be made here
too?

Neil

>  pmdinfogen = executable('pmdinfogen',
>  	'pmdinfogen.c',
> -- 
> 2.21.1
> 
>