* [dpdk-stable] [PATCH] net/bxnt: fix vlan strip flags in sse mode
@ 2020-01-22 0:47 Stephen Hemminger
2020-01-22 23:18 ` [dpdk-stable] [PATCH v2] net/bnxt: fix VLAN " Ajit Khaparde
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2020-01-22 0:47 UTC (permalink / raw)
To: ajit.khaparde, somnath.kotur
Cc: dev, Stephen Hemminger, lance.richardson, stable
When the VLAN is stripped from the packet on receive the
driver must set the PKT_RX_VLAN_STRIPPED flag in the mbuf.
This is done correctly for normal receive in the bnxt driver
but was not being handled correctly in the new SSE code.
Fixes: bc4a000f2f53 ("net/bnxt: implement SSE vector mode")
Cc: lance.richardson@broadcom.com
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
index 22d9f9e84abe..d47ad7e1796d 100644
--- a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
+++ b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
@@ -289,7 +289,7 @@ bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
(RX_PKT_CMPL_METADATA_VID_MASK |
RX_PKT_CMPL_METADATA_DE |
RX_PKT_CMPL_METADATA_PRI_MASK);
- mbuf->ol_flags |= PKT_RX_VLAN;
+ mbuf->ol_flags |= PKT_RX_VLAN | PKT_RX_VLAN_STRIPPED;
}
bnxt_parse_csum(mbuf, rxcmp1);
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-stable] [PATCH v2] net/bnxt: fix VLAN strip flags in sse mode
2020-01-22 0:47 [dpdk-stable] [PATCH] net/bxnt: fix vlan strip flags in sse mode Stephen Hemminger
@ 2020-01-22 23:18 ` Ajit Khaparde
2020-01-22 23:23 ` [dpdk-stable] [dpdk-dev] " Ajit Khaparde
0 siblings, 1 reply; 3+ messages in thread
From: Ajit Khaparde @ 2020-01-22 23:18 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, Stephen Hemminger, lance.richardson, stable
From: Stephen Hemminger <stephen@networkplumber.org>
When the VLAN is stripped from the packet on receive the
driver must set the PKT_RX_VLAN_STRIPPED flag in the mbuf.
This is done correctly for normal receive in the bnxt driver
but was not being handled correctly in the new SSE code.
Fixes: bc4a000f2f53 ("net/bnxt: implement SSE vector mode")
Cc: lance.richardson@broadcom.com
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
v1->v2: fixed the commit headline
drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
index 22d9f9e84..31457300a 100644
--- a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
+++ b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
@@ -289,7 +289,8 @@ bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
(RX_PKT_CMPL_METADATA_VID_MASK |
RX_PKT_CMPL_METADATA_DE |
RX_PKT_CMPL_METADATA_PRI_MASK);
- mbuf->ol_flags |= PKT_RX_VLAN;
+ mbuf->ol_flags |=
+ PKT_RX_VLAN | PKT_RX_VLAN_STRIPPED;
}
bnxt_parse_csum(mbuf, rxcmp1);
--
2.21.0 (Apple Git-122.2)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/bnxt: fix VLAN strip flags in sse mode
2020-01-22 23:18 ` [dpdk-stable] [PATCH v2] net/bnxt: fix VLAN " Ajit Khaparde
@ 2020-01-22 23:23 ` Ajit Khaparde
0 siblings, 0 replies; 3+ messages in thread
From: Ajit Khaparde @ 2020-01-22 23:23 UTC (permalink / raw)
To: dpdk-dev; +Cc: Ferruh Yigit, Stephen Hemminger, Lance Richardson, dpdk stable
On Wed, Jan 22, 2020 at 3:18 PM Ajit Khaparde <ajit.khaparde@broadcom.com>
wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
>
> When the VLAN is stripped from the packet on receive the
> driver must set the PKT_RX_VLAN_STRIPPED flag in the mbuf.
> This is done correctly for normal receive in the bnxt driver
> but was not being handled correctly in the new SSE code.
>
> Fixes: bc4a000f2f53 ("net/bnxt: implement SSE vector mode")
> Cc: lance.richardson@broadcom.com
> Cc: stable@dpdk.org
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
Patch applied to dpdk-next-net-brcm. Thanks
> ---
> v1->v2: fixed the commit headline
>
> drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> index 22d9f9e84..31457300a 100644
> --- a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> +++ b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> @@ -289,7 +289,8 @@ bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf
> **rx_pkts,
> (RX_PKT_CMPL_METADATA_VID_MASK |
> RX_PKT_CMPL_METADATA_DE |
> RX_PKT_CMPL_METADATA_PRI_MASK);
> - mbuf->ol_flags |= PKT_RX_VLAN;
> + mbuf->ol_flags |=
> + PKT_RX_VLAN | PKT_RX_VLAN_STRIPPED;
> }
>
> bnxt_parse_csum(mbuf, rxcmp1);
> --
> 2.21.0 (Apple Git-122.2)
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-22 23:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-22 0:47 [dpdk-stable] [PATCH] net/bxnt: fix vlan strip flags in sse mode Stephen Hemminger
2020-01-22 23:18 ` [dpdk-stable] [PATCH v2] net/bnxt: fix VLAN " Ajit Khaparde
2020-01-22 23:23 ` [dpdk-stable] [dpdk-dev] " Ajit Khaparde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).