From: "Liang, Ma" <liang.j.ma@intel.com>
To: Xiao Wang <xiao.w.wang@intel.com>
Cc: david.hunt@intel.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 2/2] l3fwd-power: fix interrupt disable
Date: Thu, 30 Jan 2020 17:40:25 +0000 [thread overview]
Message-ID: <20200130174025.GA30906@sivswdev09.ir.intel.com> (raw)
In-Reply-To: <20200121030657.39048-3-xiao.w.wang@intel.com>
On 20 Jan 22:06, Xiao Wang wrote:
> Since all related queues' interrupts are turned on before epoll, we need
> to turn off all the interrupts after wakeup. This patch fixes the issue
> of only turning off the interrupted queues.
>
> Fixes: b736d64787fc ("examples/l3fwd-power: disable Rx interrupt when waking up")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
Hi Xiao,
I'm OK with the patch.
Reviewed-by: Liang Ma <liang.j.ma@intel.com>
Regards
Liang
> ---
> examples/l3fwd-power/main.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
> index ffcc7ecf4..e9b2cb5b3 100644
> --- a/examples/l3fwd-power/main.c
> +++ b/examples/l3fwd-power/main.c
> @@ -880,9 +880,6 @@ sleep_until_rx_interrupt(int num)
> port_id = ((uintptr_t)data) >> CHAR_BIT;
> queue_id = ((uintptr_t)data) &
> RTE_LEN2MASK(CHAR_BIT, uint8_t);
> - rte_spinlock_lock(&(locks[port_id]));
> - rte_eth_dev_rx_intr_disable(port_id, queue_id);
> - rte_spinlock_unlock(&(locks[port_id]));
> RTE_LOG(INFO, L3FWD_POWER,
> "lcore %u is waked up from rx interrupt on"
> " port %d queue %d\n",
> @@ -892,7 +889,7 @@ sleep_until_rx_interrupt(int num)
> return 0;
> }
>
> -static void turn_on_intr(struct lcore_conf *qconf)
> +static void turn_on_off_intr(struct lcore_conf *qconf, bool on)
> {
> int i;
> struct lcore_rx_queue *rx_queue;
> @@ -905,7 +902,10 @@ static void turn_on_intr(struct lcore_conf *qconf)
> queue_id = rx_queue->queue_id;
>
> rte_spinlock_lock(&(locks[port_id]));
> - rte_eth_dev_rx_intr_enable(port_id, queue_id);
> + if (on)
> + rte_eth_dev_rx_intr_enable(port_id, queue_id);
> + else
> + rte_eth_dev_rx_intr_disable(port_id, queue_id);
> rte_spinlock_unlock(&(locks[port_id]));
> }
> }
> @@ -1340,9 +1340,10 @@ main_loop(__attribute__((unused)) void *dummy)
> else {
> /* suspend until rx interrupt triggers */
> if (intr_en) {
> - turn_on_intr(qconf);
> + turn_on_off_intr(qconf, 1);
> sleep_until_rx_interrupt(
> qconf->n_rx_queue);
> + turn_on_off_intr(qconf, 0);
> /**
> * start receiving packets immediately
> */
> --
> 2.15.1
>
next prev parent reply other threads:[~2020-01-30 17:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200121030657.39048-1-xiao.w.wang@intel.com>
2020-01-21 3:06 ` [dpdk-stable] [PATCH 1/2] l3fwd-power: fix a typo Xiao Wang
2020-02-14 10:46 ` Hunt, David
2020-02-14 10:46 ` Hunt, David
2020-01-21 3:06 ` [dpdk-stable] [PATCH 2/2] l3fwd-power: fix interrupt disable Xiao Wang
2020-01-22 13:30 ` [dpdk-stable] [dpdk-dev] " Harman Kalra
2020-01-22 14:32 ` Wang, Xiao W
2020-01-23 17:42 ` [dpdk-stable] [EXT] " Harman Kalra
2020-01-30 17:40 ` Liang, Ma [this message]
2020-02-14 10:43 ` [dpdk-stable] " Hunt, David
2020-02-05 17:25 ` Liang, Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200130174025.GA30906@sivswdev09.ir.intel.com \
--to=liang.j.ma@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).