* [dpdk-stable] [PATCH 1/2] l3fwd-power: fix a typo [not found] <20200121030657.39048-1-xiao.w.wang@intel.com> @ 2020-01-21 3:06 ` Xiao Wang 2020-02-14 10:46 ` Hunt, David 2020-02-14 10:46 ` Hunt, David 2020-01-21 3:06 ` [dpdk-stable] [PATCH 2/2] l3fwd-power: fix interrupt disable Xiao Wang 1 sibling, 2 replies; 10+ messages in thread From: Xiao Wang @ 2020-01-21 3:06 UTC (permalink / raw) To: david.hunt; +Cc: dev, Xiao Wang, stable Fixes: aee3bc79cc34 ("examples/l3fwd-power: enable one-shot Rx interrupt and polling switch") Cc: stable@dpdk.org Signed-off-by: Xiao Wang <xiao.w.wang@intel.com> --- examples/l3fwd-power/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index d049d8a5d..ffcc7ecf4 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -1338,7 +1338,7 @@ main_loop(__attribute__((unused)) void *dummy) */ rte_delay_us(lcore_idle_hint); else { - /* suspend until rx interrupt trigges */ + /* suspend until rx interrupt triggers */ if (intr_en) { turn_on_intr(qconf); sleep_until_rx_interrupt( -- 2.15.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-stable] [PATCH 1/2] l3fwd-power: fix a typo 2020-01-21 3:06 ` [dpdk-stable] [PATCH 1/2] l3fwd-power: fix a typo Xiao Wang @ 2020-02-14 10:46 ` Hunt, David 2020-02-14 10:46 ` Hunt, David 1 sibling, 0 replies; 10+ messages in thread From: Hunt, David @ 2020-02-14 10:46 UTC (permalink / raw) To: Xiao Wang; +Cc: dev, stable On 21/1/2020 3:06 AM, Xiao Wang wrote: > Fixes: aee3bc79cc34 ("examples/l3fwd-power: enable one-shot Rx interrupt and polling switch") > Cc: stable@dpdk.org > > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com> > --- > examples/l3fwd-power/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c > index d049d8a5d..ffcc7ecf4 100644 > --- a/examples/l3fwd-power/main.c > +++ b/examples/l3fwd-power/main.c > @@ -1338,7 +1338,7 @@ main_loop(__attribute__((unused)) void *dummy) > */ > rte_delay_us(lcore_idle_hint); > else { > - /* suspend until rx interrupt trigges */ > + /* suspend until rx interrupt triggers */ > if (intr_en) { > turn_on_intr(qconf); > sleep_until_rx_interrupt( ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-stable] [PATCH 1/2] l3fwd-power: fix a typo 2020-01-21 3:06 ` [dpdk-stable] [PATCH 1/2] l3fwd-power: fix a typo Xiao Wang 2020-02-14 10:46 ` Hunt, David @ 2020-02-14 10:46 ` Hunt, David 1 sibling, 0 replies; 10+ messages in thread From: Hunt, David @ 2020-02-14 10:46 UTC (permalink / raw) To: Xiao Wang; +Cc: dev, stable On 21/1/2020 3:06 AM, Xiao Wang wrote: > Fixes: aee3bc79cc34 ("examples/l3fwd-power: enable one-shot Rx interrupt and polling switch") > Cc: stable@dpdk.org > > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com> > --- > examples/l3fwd-power/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c > index d049d8a5d..ffcc7ecf4 100644 > --- a/examples/l3fwd-power/main.c > +++ b/examples/l3fwd-power/main.c > @@ -1338,7 +1338,7 @@ main_loop(__attribute__((unused)) void *dummy) > */ > rte_delay_us(lcore_idle_hint); > else { > - /* suspend until rx interrupt trigges */ > + /* suspend until rx interrupt triggers */ > if (intr_en) { > turn_on_intr(qconf); > sleep_until_rx_interrupt( Acked-by: David Hunt <david.hunt@intel.com> ^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-stable] [PATCH 2/2] l3fwd-power: fix interrupt disable [not found] <20200121030657.39048-1-xiao.w.wang@intel.com> 2020-01-21 3:06 ` [dpdk-stable] [PATCH 1/2] l3fwd-power: fix a typo Xiao Wang @ 2020-01-21 3:06 ` Xiao Wang 2020-01-22 13:30 ` [dpdk-stable] [dpdk-dev] " Harman Kalra ` (2 more replies) 1 sibling, 3 replies; 10+ messages in thread From: Xiao Wang @ 2020-01-21 3:06 UTC (permalink / raw) To: david.hunt; +Cc: dev, Xiao Wang, stable Since all related queues' interrupts are turned on before epoll, we need to turn off all the interrupts after wakeup. This patch fixes the issue of only turning off the interrupted queues. Fixes: b736d64787fc ("examples/l3fwd-power: disable Rx interrupt when waking up") Cc: stable@dpdk.org Signed-off-by: Xiao Wang <xiao.w.wang@intel.com> --- examples/l3fwd-power/main.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index ffcc7ecf4..e9b2cb5b3 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -880,9 +880,6 @@ sleep_until_rx_interrupt(int num) port_id = ((uintptr_t)data) >> CHAR_BIT; queue_id = ((uintptr_t)data) & RTE_LEN2MASK(CHAR_BIT, uint8_t); - rte_spinlock_lock(&(locks[port_id])); - rte_eth_dev_rx_intr_disable(port_id, queue_id); - rte_spinlock_unlock(&(locks[port_id])); RTE_LOG(INFO, L3FWD_POWER, "lcore %u is waked up from rx interrupt on" " port %d queue %d\n", @@ -892,7 +889,7 @@ sleep_until_rx_interrupt(int num) return 0; } -static void turn_on_intr(struct lcore_conf *qconf) +static void turn_on_off_intr(struct lcore_conf *qconf, bool on) { int i; struct lcore_rx_queue *rx_queue; @@ -905,7 +902,10 @@ static void turn_on_intr(struct lcore_conf *qconf) queue_id = rx_queue->queue_id; rte_spinlock_lock(&(locks[port_id])); - rte_eth_dev_rx_intr_enable(port_id, queue_id); + if (on) + rte_eth_dev_rx_intr_enable(port_id, queue_id); + else + rte_eth_dev_rx_intr_disable(port_id, queue_id); rte_spinlock_unlock(&(locks[port_id])); } } @@ -1340,9 +1340,10 @@ main_loop(__attribute__((unused)) void *dummy) else { /* suspend until rx interrupt triggers */ if (intr_en) { - turn_on_intr(qconf); + turn_on_off_intr(qconf, 1); sleep_until_rx_interrupt( qconf->n_rx_queue); + turn_on_off_intr(qconf, 0); /** * start receiving packets immediately */ -- 2.15.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 2/2] l3fwd-power: fix interrupt disable 2020-01-21 3:06 ` [dpdk-stable] [PATCH 2/2] l3fwd-power: fix interrupt disable Xiao Wang @ 2020-01-22 13:30 ` Harman Kalra 2020-01-22 14:32 ` Wang, Xiao W 2020-01-30 17:40 ` [dpdk-stable] " Liang, Ma 2020-02-05 17:25 ` Liang, Ma 2 siblings, 1 reply; 10+ messages in thread From: Harman Kalra @ 2020-01-22 13:30 UTC (permalink / raw) To: Xiao Wang; +Cc: david.hunt, dev, stable On Mon, Jan 20, 2020 at 10:06:57PM -0500, Xiao Wang wrote: > Since all related queues' interrupts are turned on before epoll, we need > to turn off all the interrupts after wakeup. This patch fixes the issue > of only turning off the interrupted queues. > > Fixes: b736d64787fc ("examples/l3fwd-power: disable Rx interrupt when waking up") > Cc: stable@dpdk.org > > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com> > --- > examples/l3fwd-power/main.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c > index ffcc7ecf4..e9b2cb5b3 100644 > --- a/examples/l3fwd-power/main.c > +++ b/examples/l3fwd-power/main.c > @@ -880,9 +880,6 @@ sleep_until_rx_interrupt(int num) > port_id = ((uintptr_t)data) >> CHAR_BIT; > queue_id = ((uintptr_t)data) & > RTE_LEN2MASK(CHAR_BIT, uint8_t); > - rte_spinlock_lock(&(locks[port_id])); > - rte_eth_dev_rx_intr_disable(port_id, queue_id); > - rte_spinlock_unlock(&(locks[port_id])); > RTE_LOG(INFO, L3FWD_POWER, > "lcore %u is waked up from rx interrupt on" > " port %d queue %d\n", > @@ -892,7 +889,7 @@ sleep_until_rx_interrupt(int num) > return 0; > } > > -static void turn_on_intr(struct lcore_conf *qconf) > +static void turn_on_off_intr(struct lcore_conf *qconf, bool on) > { > int i; > struct lcore_rx_queue *rx_queue; > @@ -905,7 +902,10 @@ static void turn_on_intr(struct lcore_conf *qconf) > queue_id = rx_queue->queue_id; > > rte_spinlock_lock(&(locks[port_id])); > - rte_eth_dev_rx_intr_enable(port_id, queue_id); > + if (on) > + rte_eth_dev_rx_intr_enable(port_id, queue_id); > + else > + rte_eth_dev_rx_intr_disable(port_id, queue_id); Hi Wang I tested this patch on octeontx2 platform and have some queries regarding the same: Difference what I observed with this patch is, you are disabling interrupts for all the queues handled by the core which woke up but what is the advantage of doing so? I dont see any difference wrt octeontx2, with and without this patch in term of power saving. Can you please explain what I am missing. Thanks Harman > rte_spinlock_unlock(&(locks[port_id])); > } > } > @@ -1340,9 +1340,10 @@ main_loop(__attribute__((unused)) void *dummy) > else { > /* suspend until rx interrupt triggers */ > if (intr_en) { > - turn_on_intr(qconf); > + turn_on_off_intr(qconf, 1); > sleep_until_rx_interrupt( > qconf->n_rx_queue); > + turn_on_off_intr(qconf, 0); > /** > * start receiving packets immediately > */ > -- > 2.15.1 > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 2/2] l3fwd-power: fix interrupt disable 2020-01-22 13:30 ` [dpdk-stable] [dpdk-dev] " Harman Kalra @ 2020-01-22 14:32 ` Wang, Xiao W 2020-01-23 17:42 ` [dpdk-stable] [EXT] " Harman Kalra 0 siblings, 1 reply; 10+ messages in thread From: Wang, Xiao W @ 2020-01-22 14:32 UTC (permalink / raw) To: Harman Kalra; +Cc: Hunt, David, dev, stable Hi Kalra, This patch is more about bug fix on user interrupt, no powering saving tuning. The target scenario is, a worker core is dealing with 2 Rx queues, and it go sleep due to no traffic for some time, and then the first queue has new traffic arrived, and wakes up this core, so this worker core is busy polling again. The issue is that even though the core comes to polling state, the second queue will still send interrupt (if packet flushes in) to host.. This is what the core doesn't need, and unnecessary MSIX messages can cause throughput to degrade. Best Regards, Xiao > -----Original Message----- > From: Harman Kalra <hkalra@marvell.com> > Sent: Wednesday, January 22, 2020 9:30 PM > To: Wang, Xiao W <xiao.w.wang@intel.com> > Cc: Hunt, David <david.hunt@intel.com>; dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] l3fwd-power: fix interrupt disable > > On Mon, Jan 20, 2020 at 10:06:57PM -0500, Xiao Wang wrote: > > Since all related queues' interrupts are turned on before epoll, we need > > to turn off all the interrupts after wakeup. This patch fixes the issue > > of only turning off the interrupted queues. > > > > Fixes: b736d64787fc ("examples/l3fwd-power: disable Rx interrupt when > waking up") > > Cc: stable@dpdk.org > > > > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com> > > --- > > examples/l3fwd-power/main.c | 13 +++++++------ > > 1 file changed, 7 insertions(+), 6 deletions(-) > > > > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c > > index ffcc7ecf4..e9b2cb5b3 100644 > > --- a/examples/l3fwd-power/main.c > > +++ b/examples/l3fwd-power/main.c > > @@ -880,9 +880,6 @@ sleep_until_rx_interrupt(int num) > > port_id = ((uintptr_t)data) >> CHAR_BIT; > > queue_id = ((uintptr_t)data) & > > RTE_LEN2MASK(CHAR_BIT, uint8_t); > > - rte_spinlock_lock(&(locks[port_id])); > > - rte_eth_dev_rx_intr_disable(port_id, queue_id); > > - rte_spinlock_unlock(&(locks[port_id])); > > RTE_LOG(INFO, L3FWD_POWER, > > "lcore %u is waked up from rx interrupt on" > > " port %d queue %d\n", > > @@ -892,7 +889,7 @@ sleep_until_rx_interrupt(int num) > > return 0; > > } > > > > -static void turn_on_intr(struct lcore_conf *qconf) > > +static void turn_on_off_intr(struct lcore_conf *qconf, bool on) > > { > > int i; > > struct lcore_rx_queue *rx_queue; > > @@ -905,7 +902,10 @@ static void turn_on_intr(struct lcore_conf *qconf) > > queue_id = rx_queue->queue_id; > > > > rte_spinlock_lock(&(locks[port_id])); > > - rte_eth_dev_rx_intr_enable(port_id, queue_id); > > + if (on) > > + rte_eth_dev_rx_intr_enable(port_id, queue_id); > > + else > > + rte_eth_dev_rx_intr_disable(port_id, queue_id); > > Hi Wang > > I tested this patch on octeontx2 platform and have some queries > regarding the same: > Difference what I observed with this patch is, you are disabling > interrupts for all the queues handled by the core which woke up but > what is the advantage of doing so? > I dont see any difference wrt octeontx2, with and without this patch in > term of power saving. Can you please explain what I am missing. > > Thanks > Harman > > > rte_spinlock_unlock(&(locks[port_id])); > > } > > } > > @@ -1340,9 +1340,10 @@ main_loop(__attribute__((unused)) void > *dummy) > > else { > > /* suspend until rx interrupt triggers */ > > if (intr_en) { > > - turn_on_intr(qconf); > > + turn_on_off_intr(qconf, 1); > > sleep_until_rx_interrupt( > > qconf->n_rx_queue); > > + turn_on_off_intr(qconf, 0); > > /** > > * start receiving packets immediately > > */ > > -- > > 2.15.1 > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-stable] [EXT] RE: [dpdk-dev] [PATCH 2/2] l3fwd-power: fix interrupt disable 2020-01-22 14:32 ` Wang, Xiao W @ 2020-01-23 17:42 ` Harman Kalra 0 siblings, 0 replies; 10+ messages in thread From: Harman Kalra @ 2020-01-23 17:42 UTC (permalink / raw) To: Wang, Xiao W; +Cc: Hunt, David, dev, stable On Wed, Jan 22, 2020 at 02:32:26PM +0000, Wang, Xiao W wrote: > External Email > > ---------------------------------------------------------------------- > Hi Kalra, > > This patch is more about bug fix on user interrupt, no powering saving tuning. > The target scenario is, a worker core is dealing with 2 Rx queues, and it go sleep due to no traffic for some time, > and then the first queue has new traffic arrived, and wakes up this core, so this worker core is busy polling again. > The issue is that even though the core comes to polling state, the second queue will still send interrupt (if packet flushes in) to host.. This is what the core doesn't need, and unnecessary MSIX messages can cause throughput to degrade. > > Best Regards, > Xiao > Hi Xiao Thanks for the explaination, I tested the scenario as explained by you with and without your patch. I do see a huge difference in no of interrupts sent by other queues and it is worth avoiding these interrupts as they have no significance. Thanks Harman Tested-by: Harman Kalra <hkalra@marvell.com> > > -----Original Message----- > > From: Harman Kalra <hkalra@marvell.com> > > Sent: Wednesday, January 22, 2020 9:30 PM > > To: Wang, Xiao W <xiao.w.wang@intel.com> > > Cc: Hunt, David <david.hunt@intel.com>; dev@dpdk.org; stable@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 2/2] l3fwd-power: fix interrupt disable > > > > On Mon, Jan 20, 2020 at 10:06:57PM -0500, Xiao Wang wrote: > > > Since all related queues' interrupts are turned on before epoll, we need > > > to turn off all the interrupts after wakeup. This patch fixes the issue > > > of only turning off the interrupted queues. > > > > > > Fixes: b736d64787fc ("examples/l3fwd-power: disable Rx interrupt when > > waking up") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com> > > > --- > > > examples/l3fwd-power/main.c | 13 +++++++------ > > > 1 file changed, 7 insertions(+), 6 deletions(-) > > > > > > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c > > > index ffcc7ecf4..e9b2cb5b3 100644 > > > --- a/examples/l3fwd-power/main.c > > > +++ b/examples/l3fwd-power/main.c > > > @@ -880,9 +880,6 @@ sleep_until_rx_interrupt(int num) > > > port_id = ((uintptr_t)data) >> CHAR_BIT; > > > queue_id = ((uintptr_t)data) & > > > RTE_LEN2MASK(CHAR_BIT, uint8_t); > > > - rte_spinlock_lock(&(locks[port_id])); > > > - rte_eth_dev_rx_intr_disable(port_id, queue_id); > > > - rte_spinlock_unlock(&(locks[port_id])); > > > RTE_LOG(INFO, L3FWD_POWER, > > > "lcore %u is waked up from rx interrupt on" > > > " port %d queue %d\n", > > > @@ -892,7 +889,7 @@ sleep_until_rx_interrupt(int num) > > > return 0; > > > } > > > > > > -static void turn_on_intr(struct lcore_conf *qconf) > > > +static void turn_on_off_intr(struct lcore_conf *qconf, bool on) > > > { > > > int i; > > > struct lcore_rx_queue *rx_queue; > > > @@ -905,7 +902,10 @@ static void turn_on_intr(struct lcore_conf *qconf) > > > queue_id = rx_queue->queue_id; > > > > > > rte_spinlock_lock(&(locks[port_id])); > > > - rte_eth_dev_rx_intr_enable(port_id, queue_id); > > > + if (on) > > > + rte_eth_dev_rx_intr_enable(port_id, queue_id); > > > + else > > > + rte_eth_dev_rx_intr_disable(port_id, queue_id); > > > > Hi Wang > > > > I tested this patch on octeontx2 platform and have some queries > > regarding the same: > > Difference what I observed with this patch is, you are disabling > > interrupts for all the queues handled by the core which woke up but > > what is the advantage of doing so? > > I dont see any difference wrt octeontx2, with and without this patch in > > term of power saving. Can you please explain what I am missing. > > > > Thanks > > Harman > > > > > rte_spinlock_unlock(&(locks[port_id])); > > > } > > > } > > > @@ -1340,9 +1340,10 @@ main_loop(__attribute__((unused)) void > > *dummy) > > > else { > > > /* suspend until rx interrupt triggers */ > > > if (intr_en) { > > > - turn_on_intr(qconf); > > > + turn_on_off_intr(qconf, 1); > > > sleep_until_rx_interrupt( > > > qconf->n_rx_queue); > > > + turn_on_off_intr(qconf, 0); > > > /** > > > * start receiving packets immediately > > > */ > > > -- > > > 2.15.1 > > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 2/2] l3fwd-power: fix interrupt disable 2020-01-21 3:06 ` [dpdk-stable] [PATCH 2/2] l3fwd-power: fix interrupt disable Xiao Wang 2020-01-22 13:30 ` [dpdk-stable] [dpdk-dev] " Harman Kalra @ 2020-01-30 17:40 ` Liang, Ma 2020-02-14 10:43 ` Hunt, David 2020-02-05 17:25 ` Liang, Ma 2 siblings, 1 reply; 10+ messages in thread From: Liang, Ma @ 2020-01-30 17:40 UTC (permalink / raw) To: Xiao Wang; +Cc: david.hunt, dev, stable On 20 Jan 22:06, Xiao Wang wrote: > Since all related queues' interrupts are turned on before epoll, we need > to turn off all the interrupts after wakeup. This patch fixes the issue > of only turning off the interrupted queues. > > Fixes: b736d64787fc ("examples/l3fwd-power: disable Rx interrupt when waking up") > Cc: stable@dpdk.org > > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com> Hi Xiao, I'm OK with the patch. Reviewed-by: Liang Ma <liang.j.ma@intel.com> Regards Liang > --- > examples/l3fwd-power/main.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c > index ffcc7ecf4..e9b2cb5b3 100644 > --- a/examples/l3fwd-power/main.c > +++ b/examples/l3fwd-power/main.c > @@ -880,9 +880,6 @@ sleep_until_rx_interrupt(int num) > port_id = ((uintptr_t)data) >> CHAR_BIT; > queue_id = ((uintptr_t)data) & > RTE_LEN2MASK(CHAR_BIT, uint8_t); > - rte_spinlock_lock(&(locks[port_id])); > - rte_eth_dev_rx_intr_disable(port_id, queue_id); > - rte_spinlock_unlock(&(locks[port_id])); > RTE_LOG(INFO, L3FWD_POWER, > "lcore %u is waked up from rx interrupt on" > " port %d queue %d\n", > @@ -892,7 +889,7 @@ sleep_until_rx_interrupt(int num) > return 0; > } > > -static void turn_on_intr(struct lcore_conf *qconf) > +static void turn_on_off_intr(struct lcore_conf *qconf, bool on) > { > int i; > struct lcore_rx_queue *rx_queue; > @@ -905,7 +902,10 @@ static void turn_on_intr(struct lcore_conf *qconf) > queue_id = rx_queue->queue_id; > > rte_spinlock_lock(&(locks[port_id])); > - rte_eth_dev_rx_intr_enable(port_id, queue_id); > + if (on) > + rte_eth_dev_rx_intr_enable(port_id, queue_id); > + else > + rte_eth_dev_rx_intr_disable(port_id, queue_id); > rte_spinlock_unlock(&(locks[port_id])); > } > } > @@ -1340,9 +1340,10 @@ main_loop(__attribute__((unused)) void *dummy) > else { > /* suspend until rx interrupt triggers */ > if (intr_en) { > - turn_on_intr(qconf); > + turn_on_off_intr(qconf, 1); > sleep_until_rx_interrupt( > qconf->n_rx_queue); > + turn_on_off_intr(qconf, 0); > /** > * start receiving packets immediately > */ > -- > 2.15.1 > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 2/2] l3fwd-power: fix interrupt disable 2020-01-30 17:40 ` [dpdk-stable] " Liang, Ma @ 2020-02-14 10:43 ` Hunt, David 0 siblings, 0 replies; 10+ messages in thread From: Hunt, David @ 2020-02-14 10:43 UTC (permalink / raw) To: Liang, Ma, Xiao Wang; +Cc: dev, stable On 30/1/2020 5:40 PM, Liang, Ma wrote: > On 20 Jan 22:06, Xiao Wang wrote: >> Since all related queues' interrupts are turned on before epoll, we need >> to turn off all the interrupts after wakeup. This patch fixes the issue >> of only turning off the interrupted queues. >> >> Fixes: b736d64787fc ("examples/l3fwd-power: disable Rx interrupt when waking up") >> Cc: stable@dpdk.org >> >> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com> > Hi Xiao, > I'm OK with the patch. > Reviewed-by: Liang Ma <liang.j.ma@intel.com> > Regards > Liang Hi, I've discussed the before/after testing with Liang, and the code looks good to me. Acked-by: David Hunt <david.hunt@intel.com> Also, from Liang's email above, but without the leading spaces: Reviewed-by: Liang Ma <liang.j.ma@intel.com> Thanks, Dave ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 2/2] l3fwd-power: fix interrupt disable 2020-01-21 3:06 ` [dpdk-stable] [PATCH 2/2] l3fwd-power: fix interrupt disable Xiao Wang 2020-01-22 13:30 ` [dpdk-stable] [dpdk-dev] " Harman Kalra 2020-01-30 17:40 ` [dpdk-stable] " Liang, Ma @ 2020-02-05 17:25 ` Liang, Ma 2 siblings, 0 replies; 10+ messages in thread From: Liang, Ma @ 2020-02-05 17:25 UTC (permalink / raw) To: Xiao Wang; +Cc: david.hunt, dev, stable Tested-by: Liang Ma <liang.j.ma@intel.com> ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-02-14 10:46 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200121030657.39048-1-xiao.w.wang@intel.com>
2020-01-21 3:06 ` [dpdk-stable] [PATCH 1/2] l3fwd-power: fix a typo Xiao Wang
2020-02-14 10:46 ` Hunt, David
2020-02-14 10:46 ` Hunt, David
2020-01-21 3:06 ` [dpdk-stable] [PATCH 2/2] l3fwd-power: fix interrupt disable Xiao Wang
2020-01-22 13:30 ` [dpdk-stable] [dpdk-dev] " Harman Kalra
2020-01-22 14:32 ` Wang, Xiao W
2020-01-23 17:42 ` [dpdk-stable] [EXT] " Harman Kalra
2020-01-30 17:40 ` [dpdk-stable] " Liang, Ma
2020-02-14 10:43 ` Hunt, David
2020-02-05 17:25 ` Liang, Ma
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).