* [dpdk-stable] [PATCH 2/2] net/qede: Do not stop vport if not started.
[not found] <20200206200146.14808-1-manishc@marvell.com>
@ 2020-02-06 20:01 ` Manish Chopra
2020-02-07 6:22 ` [dpdk-stable] [dpdk-dev] [PATCH 1/2] net/qede: Fix VF re-load failure after ungraceful termination of DPDK Rasesh Mody
1 sibling, 0 replies; 3+ messages in thread
From: Manish Chopra @ 2020-02-06 20:01 UTC (permalink / raw)
To: dev, ferruh.yigit; +Cc: rmody, GR-Everest-DPDK-Dev, stable
Stopping an already disabled vport leads to firmware
assert. Stop the vport only if it was started.
Fixes: 2ea6f76aff40 ("qede: add core driver")
Cc: stable@dpdk.org
Signed-off-by: Manish Chopra <manishc@marvell.com>
Signed-off-by: Rasesh Mody <rmody@marvell.com>
---
drivers/net/qede/qede_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 500440c2c..74dfe895a 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -1509,7 +1509,8 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev)
if (eth_dev->data->dev_started)
qede_dev_stop(eth_dev);
- qede_stop_vport(edev);
+ if (qdev->vport_started)
+ qede_stop_vport(edev);
qdev->vport_started = false;
qede_fdir_dealloc_resc(eth_dev);
qede_dealloc_fp_resc(eth_dev);
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 1/2] net/qede: Fix VF re-load failure after ungraceful termination of DPDK
[not found] <20200206200146.14808-1-manishc@marvell.com>
2020-02-06 20:01 ` [dpdk-stable] [PATCH 2/2] net/qede: Do not stop vport if not started Manish Chopra
@ 2020-02-07 6:22 ` Rasesh Mody
2020-02-15 13:33 ` Jerin Jacob
1 sibling, 1 reply; 3+ messages in thread
From: Rasesh Mody @ 2020-02-07 6:22 UTC (permalink / raw)
To: Manish Chopra, dev, ferruh.yigit, Jerin Jacob
Cc: GR-Everest-DPDK-Dev, dpdk stable
+Jerin
>From: dev <dev-bounces@dpdk.org> On Behalf Of Manish Chopra
>Sent: Thursday, February 06, 2020 12:02 PM
>
>On ungraceful termination of DPDK application, PMD VF driver fails to re-load
>due to PF seeing the VF in unexpected state during VF acquisition handshake.
>
>This patch fixes it by allowing VF to request the PF for soft FLR during the load
>in such cases so that it can get cleanly re-loaded.
>
>Fixes: 2ea6f76aff40 ("qede: add core driver")
Cc: stable@dpdk.org
>
>Signed-off-by: Manish Chopra <manishc@marvell.com>
>Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>
>Signed-off-by: Rasesh Mody <rmody@marvell.com>
>---
Acked-by: Rasesh Mody <rmody@marvell.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 1/2] net/qede: Fix VF re-load failure after ungraceful termination of DPDK
2020-02-07 6:22 ` [dpdk-stable] [dpdk-dev] [PATCH 1/2] net/qede: Fix VF re-load failure after ungraceful termination of DPDK Rasesh Mody
@ 2020-02-15 13:33 ` Jerin Jacob
0 siblings, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2020-02-15 13:33 UTC (permalink / raw)
To: Rasesh Mody
Cc: Manish Chopra, dev, ferruh.yigit, GR-Everest-DPDK-Dev, dpdk stable
On Fri, Feb 7, 2020 at 11:52 AM Rasesh Mody <rmody@marvell.com> wrote:
>
> +Jerin
>
> >From: dev <dev-bounces@dpdk.org> On Behalf Of Manish Chopra
> >Sent: Thursday, February 06, 2020 12:02 PM
> >
> >On ungraceful termination of DPDK application, PMD VF driver fails to re-load
> >due to PF seeing the VF in unexpected state during VF acquisition handshake.
> >
> >This patch fixes it by allowing VF to request the PF for soft FLR during the load
> >in such cases so that it can get cleanly re-loaded.
> >
> >Fixes: 2ea6f76aff40 ("qede: add core driver")
>
> Cc: stable@dpdk.org
>
> >
> >Signed-off-by: Manish Chopra <manishc@marvell.com>
> >Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>
> >Signed-off-by: Rasesh Mody <rmody@marvell.com>
> >---
>
> Acked-by: Rasesh Mody <rmody@marvell.com>
Fixed following check-git-log.sh warnings[1]
Series applied to dpdk-next-net-mrvl/master. Thanks.
[1]
check-git-log failed
Wrong headline format:
net/qede: Do not stop vport if not started.
Wrong headline uppercase:
net/qede: Fix VF re-load failure after ungraceful termination of DPDK
net/qede: Do not stop vport if not started.
Headline too long:
net/qede: Fix VF re-load failure after ungraceful termination of DPDK
Is it candidate for Cc: stable@dpdk.org backport?
net/qede: Fix VF re-load failure after ungraceful termination of DPDK]
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-15 13:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200206200146.14808-1-manishc@marvell.com>
2020-02-06 20:01 ` [dpdk-stable] [PATCH 2/2] net/qede: Do not stop vport if not started Manish Chopra
2020-02-07 6:22 ` [dpdk-stable] [dpdk-dev] [PATCH 1/2] net/qede: Fix VF re-load failure after ungraceful termination of DPDK Rasesh Mody
2020-02-15 13:33 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).