From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3EE5A0542 for ; Fri, 7 Feb 2020 16:13:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9ED8A1C02E; Fri, 7 Feb 2020 16:13:23 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 738471C02E for ; Fri, 7 Feb 2020 16:13:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581088400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IVxG2YZSkGI9agEbnOeYjgRJohUCM3qJkUixZzcFrTw=; b=KVaksoxXIZr4q2ihW74Ia+1PF/uRmkUiCCjCZO2GucO558tIsttZvqS0WxXXapsPf3vvcs w68xrVPgf3hbGDW9hLNj4r8YXDNrgU75QxoF10YvnW2HYrVyNnj7JyQDoNCggW9/SUkMcZ 3In0XczXGFuXbAXdEd/+QVHnr180sdE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-275-UtdBDBfrMXiTSwu8SkSSDw-1; Fri, 07 Feb 2020 10:13:05 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E5A6B184AEB4; Fri, 7 Feb 2020 15:13:02 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.76]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6F5DF1001B0B; Fri, 7 Feb 2020 15:12:59 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: David Marchand , dpdk stable Date: Fri, 7 Feb 2020 15:12:13 +0000 Message-Id: <20200207151248.29804-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: UtdBDBfrMXiTSwu8SkSSDw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'eal/linux: fix uninitialized data valgrind warning' has been queued to LTS release 18.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/13/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/5febee7b601ecb874a= 06f2460afc7725264ce967 Thanks. Kevin. --- >From 5febee7b601ecb874a06f2460afc7725264ce967 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 27 Nov 2019 14:32:32 -0800 Subject: [PATCH] eal/linux: fix uninitialized data valgrind warning [ upstream commit e0ab8020ac2a5b379bb91fbe882ac3b08d333586 ] Valgrind reports that eal interrupt thread is calling epoll_ctl with uninitialized data. This is a false positive, because the kernel is not going to care about the unused bits in the union but trivial to fix by initializing it. Fixes: af75078fece3 ("first public release") Signed-off-by: Stephen Hemminger Acked-by: David Marchand --- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_interrupts.c b/lib/librte_eal/= linuxapp/eal/eal_interrupts.c index 102a9549ea..c2517a9a0a 100644 --- a/lib/librte_eal/linuxapp/eal/eal_interrupts.c +++ b/lib/librte_eal/linuxapp/eal/eal_interrupts.c @@ -965,5 +965,5 @@ static __attribute__((noreturn)) void * eal_intr_thread_main(__rte_unused void *arg) { -=09struct epoll_event ev; +=09struct epoll_event ev =3D { }; =20 =09/* host thread, never break out */ --=20 2.21.1 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092020-02-07 15:08:17.613151567 +0000 +++ 0001-eal-linux-fix-uninitialized-data-valgrind-warning.patch=092020-02-= 07 15:08:17.488063295 +0000 @@ -1 +1 @@ -From e0ab8020ac2a5b379bb91fbe882ac3b08d333586 Mon Sep 17 00:00:00 2001 +From 5febee7b601ecb874a06f2460afc7725264ce967 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit e0ab8020ac2a5b379bb91fbe882ac3b08d333586 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -17 +18 @@ - lib/librte_eal/linux/eal/eal_interrupts.c | 2 +- + lib/librte_eal/linuxapp/eal/eal_interrupts.c | 2 +- @@ -20,5 +21,5 @@ -diff --git a/lib/librte_eal/linux/eal/eal_interrupts.c b/lib/librte_eal/li= nux/eal/eal_interrupts.c -index 1955324d30..2cd537ba44 100644 ---- a/lib/librte_eal/linux/eal/eal_interrupts.c -+++ b/lib/librte_eal/linux/eal/eal_interrupts.c -@@ -1046,5 +1046,5 @@ static __attribute__((noreturn)) void * +diff --git a/lib/librte_eal/linuxapp/eal/eal_interrupts.c b/lib/librte_eal= /linuxapp/eal/eal_interrupts.c +index 102a9549ea..c2517a9a0a 100644 +--- a/lib/librte_eal/linuxapp/eal/eal_interrupts.c ++++ b/lib/librte_eal/linuxapp/eal/eal_interrupts.c +@@ -965,5 +965,5 @@ static __attribute__((noreturn)) void *