From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC46CA0542 for ; Fri, 7 Feb 2020 16:14:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9E64D1C130; Fri, 7 Feb 2020 16:14:07 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id C677E1C127 for ; Fri, 7 Feb 2020 16:14:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581088446; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J92rvvJpIpDvk4K5Be/6ts1GS/aNHfQu5B5DSCmQMXc=; b=M4mPbOCQfcfmSmmaU7jtl9Vwnuj8w+lA+Wz5IhDZFk7SLRw9eezJNnNqjte4FjR9N27NYG vsV7qQSPeToesREEOfYs6t28nxtAvoKyBbWVFcTcrm6+wOV875zZL6ZQW2Z1U6DvUa4375 qYoAuG2xR5B3WQevWrukJHFLsFXR5f4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-310-j4_siSFJOwy_JIK9UkhFtA-1; Fri, 07 Feb 2020 10:13:50 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 681CE800D5C; Fri, 7 Feb 2020 15:13:49 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.76]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5C25010016DA; Fri, 7 Feb 2020 15:13:48 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Bernard Iremonger , dpdk stable Date: Fri, 7 Feb 2020 15:12:36 +0000 Message-Id: <20200207151248.29804-24-ktraynor@redhat.com> In-Reply-To: <20200207151248.29804-1-ktraynor@redhat.com> References: <20200207151248.29804-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: j4_siSFJOwy_JIK9UkhFtA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'app/testpmd: call cleanup on exit' has been queued to LTS release 18.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/13/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/ad2076ec30fb881f75= e56cd81f556fc9e3b6ffee Thanks. Kevin. --- >From ad2076ec30fb881f75e56cd81f556fc9e3b6ffee Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 7 Jan 2020 10:59:42 -0800 Subject: [PATCH] app/testpmd: call cleanup on exit [ upstream commit 5e516c89830aacae67968490dbd8c542b9ffc430 ] The rte_eal_cleanup code is not exercised by testpmd which is the most used DPDK test tool. Add a call at end of program. This helps exercise free and close paths which can be checked with tools like valgrind. Fixes: af75078fece3 ("first public release") Signed-off-by: Stephen Hemminger Acked-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 98fe2f8f7d..31d559494d 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3297,4 +3297,9 @@ main(int argc, char** argv) =09} =20 -=09return 0; +=09ret =3D rte_eal_cleanup(); +=09if (ret !=3D 0) +=09=09rte_exit(EXIT_FAILURE, +=09=09=09 "EAL cleanup failed: %s\n", strerror(-ret)); + +=09return EXIT_SUCCESS; } --=20 2.21.1 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092020-02-07 15:08:18.776037828 +0000 +++ 0024-app-testpmd-call-cleanup-on-exit.patch=092020-02-07 15:08:17.54106= 2591 +0000 @@ -1 +1 @@ -From 5e516c89830aacae67968490dbd8c542b9ffc430 Mon Sep 17 00:00:00 2001 +From ad2076ec30fb881f75e56cd81f556fc9e3b6ffee Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 5e516c89830aacae67968490dbd8c542b9ffc430 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index b374682236..2eec8afda1 100644 +index 98fe2f8f7d..31d559494d 100644 @@ -25 +26 @@ -@@ -3571,4 +3571,9 @@ main(int argc, char** argv) +@@ -3297,4 +3297,9 @@ main(int argc, char** argv)