From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9AE0A0542 for ; Fri, 7 Feb 2020 16:13:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E18581C02E; Fri, 7 Feb 2020 16:13:33 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id C81781C02E for ; Fri, 7 Feb 2020 16:13:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581088412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0M/vt43Dqo3Y2Hus0GJmF49AZLJ3hKntz2ueEOlhCEM=; b=EdSzZMkB1icE5SuUIojPv63xVVZcBsOYx+o1JUNEUB28MnA2pg/WXfkc0PORXE9e6dIBBJ 7o1ORtT2bMiT0tZaudkz+QiD3vGj6ghTrkpfllVBMMvGiYn90yQKeicp8T/aNiZKRXY8KC jzQeW8usmaM007WrHtjOArhnhMyDpTo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-62-q7fI7RNzO96RsvHxkiIXZA-1; Fri, 07 Feb 2020 10:13:16 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9C87E18A550F; Fri, 7 Feb 2020 15:13:15 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.76]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8F29410016DA; Fri, 7 Feb 2020 15:13:14 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: David Marchand , dpdk stable Date: Fri, 7 Feb 2020 15:12:16 +0000 Message-Id: <20200207151248.29804-4-ktraynor@redhat.com> In-Reply-To: <20200207151248.29804-1-ktraynor@redhat.com> References: <20200207151248.29804-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: q7fI7RNzO96RsvHxkiIXZA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'build: explicitly enable sse4 for meson' has been queued to LTS release 18.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/13/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/cd487d1409e2ef4a71= 81327ab042f48c46039101 Thanks. Kevin. --- >From cd487d1409e2ef4a7181327ab042f48c46039101 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Mon, 23 Dec 2019 10:38:40 +0000 Subject: [PATCH] build: explicitly enable sse4 for meson [ upstream commit 10060dba6455461088d24e03d3cfeba639d53022 ] If the compiler does not recognise the specific CPU when building with the default "native" machine type, sse4.2 instructions can be missing, causing a build error. Rather than advising the user to change the machine type, we can just turn on SSE4.2 directly. This can prevent issues with running automated tests with older compilers/distros on newer hardware. Signed-off-by: Bruce Richardson Acked-by: David Marchand --- config/x86/meson.build | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/config/x86/meson.build b/config/x86/meson.build index 50a9edc411..c2be66811f 100644 --- a/config/x86/meson.build +++ b/config/x86/meson.build @@ -16,9 +16,7 @@ endif =20 # we require SSE4.2 for DPDK -sse_errormsg =3D '''SSE4.2 instruction set is required for DPDK. -Please set the machine type to "nehalem" or "corei7" or higher value''' - if cc.get_define('__SSE4_2__', args: machine_args) =3D=3D '' -=09error(sse_errormsg) +=09message('SSE 4.2 not enabled by default, explicitly enabling') +=09machine_args +=3D '-msse4' endif =20 --=20 2.21.1 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092020-02-07 15:08:17.763874922 +0000 +++ 0004-build-explicitly-enable-sse4-for-meson.patch=092020-02-07 15:08:17= .491063255 +0000 @@ -1 +1 @@ -From 10060dba6455461088d24e03d3cfeba639d53022 Mon Sep 17 00:00:00 2001 +From cd487d1409e2ef4a7181327ab042f48c46039101 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 10060dba6455461088d24e03d3cfeba639d53022 ] + @@ -12,2 +13,0 @@ -Cc: stable@dpdk.org - @@ -21 +21 @@ -index 8b0fa3e6f1..adc857ba28 100644 +index 50a9edc411..c2be66811f 100644