From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0B21A051C for ; Tue, 11 Feb 2020 12:41:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B8F531BFF5; Tue, 11 Feb 2020 12:41:02 +0100 (CET) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id DBD601BFF4 for ; Tue, 11 Feb 2020 12:41:00 +0100 (CET) Received: by mail-wm1-f66.google.com with SMTP id p17so3144521wma.1 for ; Tue, 11 Feb 2020 03:41:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EtB5Fvya9mitWK1HtWmptcVFpfp8nYOA9xeY6wWC548=; b=HGVKSqLc+pq+2DGZ0S2TWgsGKdaH8iP+pb+UNax8rBiM26Ra39lGcaRLgIxy+UVTln kYmC4LPYZ11B6FFgwp+HfsFaiB9iWQwYFrYDPM3r35Rojfjv5bOoyAjzlBUF3tUOov2H ugYlVz2Ksel+2iH2Z89qIw7Kpr0byeptofIzO/U4E01zg6kriq8KJPrG0vgj4c/a72Ju QZzlIIoR+vmv10vYHyQCgO+qq5h7kGJjOY5S+kCpbavgjgTfMKK3tEVpOvYStFDwgkgc QLIifx5/eonpMLYldElQFGAgrfI03wwHvMJDUABC8l5cMS/FLyfzwIC2QZKP3cB86TMG xfbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EtB5Fvya9mitWK1HtWmptcVFpfp8nYOA9xeY6wWC548=; b=K2t5VMkwICFJqbLuCA0t2s/GgS2wtqRaz8m8u5UnqaLVVZVE8a226S2D+C3OXa+KcI mn9kXHuNsDoTBEnqwkOa83uE8UXh3rWA0LaeunX2zW2nGlOC3zotxVCFyE2K3FrDpLUr UH6eFILVrvcp4CWRIG7R771ioPHcs4MfPHYvs8L+BHT3KjoP9YvkMsJR4PD0PXJZWG3x 012rDsbR+KCXFnHtXtlobkUGEOREXO4VgIjF3aMyyb3zNlpIqVn7Yyi/FFirnt/9XCSv WgX9+kugCtYW/vrhsDRVrClZ/9x047beMUcO5DjlJivrRjTkhFbbBW0PADFbE0b5Z1M8 5Cdg== X-Gm-Message-State: APjAAAVAWUFfIQupykExaSrafCgug7f5y3ieQaGFuMt8XQPRzhruH27u g4i/VOeVeiO0d9xJ9rBGlx8= X-Google-Smtp-Source: APXvYqw9A3oQY5hHWbTkXZZ+rPnX5cs6QmVkLLLwXHNZfNhJXXP8Rt1riuiQ4LC1GgZasb+7CcDhwQ== X-Received: by 2002:a05:600c:2147:: with SMTP id v7mr4986221wml.61.1581421260337; Tue, 11 Feb 2020 03:41:00 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id m21sm3326819wmi.27.2020.02.11.03.40.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2020 03:40:59 -0800 (PST) From: luca.boccassi@gmail.com To: Rasesh Mody Cc: dpdk stable Date: Tue, 11 Feb 2020 11:21:43 +0000 Message-Id: <20200211112216.3929-157-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200211112216.3929-1-luca.boccassi@gmail.com> References: <20200211112216.3929-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bnx2x: fix reset of scan FP flag' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/13/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 41a8f39240c35b8919fc69ff7ce245f0a3757ebe Mon Sep 17 00:00:00 2001 From: Rasesh Mody Date: Sun, 26 Jan 2020 14:54:18 -0800 Subject: [PATCH] net/bnx2x: fix reset of scan FP flag [ upstream commit d836d5efb93505ad86f72c0fcfb0f650858b96ac ] The fastpath task queue handler resets the fastpath scan flag unconditionally, this patch changes that to reset the flag only if it was set. Fixes: 08a6e472c3d7 ("net/bnx2x: fix packet drop") Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index ed31335ac5..50e289b286 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -4577,10 +4577,10 @@ static void bnx2x_handle_fp_tq(struct bnx2x_fastpath *fp) bnx2x_handle_fp_tq(fp); return; } + /* We have completed slow path completion, clear the flag */ + rte_atomic32_set(&sc->scan_fp, 0); } - /* Assuming we have completed slow path completion, clear the flag */ - rte_atomic32_set(&sc->scan_fp, 0); bnx2x_ack_sb(sc, fp->igu_sb_id, USTORM_ID, le16toh(fp->fp_hc_idx), IGU_INT_ENABLE, 1); } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-11 11:17:44.085598229 +0000 +++ 0157-net-bnx2x-fix-reset-of-scan-FP-flag.patch 2020-02-11 11:17:38.752007929 +0000 @@ -1,14 +1,15 @@ -From d836d5efb93505ad86f72c0fcfb0f650858b96ac Mon Sep 17 00:00:00 2001 +From 41a8f39240c35b8919fc69ff7ce245f0a3757ebe Mon Sep 17 00:00:00 2001 From: Rasesh Mody Date: Sun, 26 Jan 2020 14:54:18 -0800 Subject: [PATCH] net/bnx2x: fix reset of scan FP flag +[ upstream commit d836d5efb93505ad86f72c0fcfb0f650858b96ac ] + The fastpath task queue handler resets the fastpath scan flag unconditionally, this patch changes that to reset the flag only if it was set. Fixes: 08a6e472c3d7 ("net/bnx2x: fix packet drop") -Cc: stable@dpdk.org Signed-off-by: Rasesh Mody ---