From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39B80A051C for ; Tue, 11 Feb 2020 12:41:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2F2431BFF3; Tue, 11 Feb 2020 12:41:11 +0100 (CET) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 259051BFF7 for ; Tue, 11 Feb 2020 12:41:10 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id k11so11920728wrd.9 for ; Tue, 11 Feb 2020 03:41:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qSfq5V8R0Thqd8VNqbQbnjGBlavjMbJ0aNdbIaI18AY=; b=kQzQ9CWjAnXvCO0PgSdFXX5tSBLI/d+cbk+O0WgZ1gX0ZZ3efYeVQRay9H3qEjWgXg S4n2LvYIW6XQOMOEqUXO9zEZPyN+mBlkMQEDCadLv7bItuMqx0UM0RHiEfIRmu3UqiiJ /pIF1crEulnQaz1TkBl4q3t2fWSw/MX43OhqNALDj+bDEcOqjSwK1XdFTo+vE1GM/YGy UCRI0JHdl6EA0HcqF5yWg5Dnghg95FeBQ0d5LzRWipvXwEpHKRX8e9dOpUSXvOz0y3Ym Kmsocxb+tNMG1I70YyHfpsrfrNZy+mMDySpQFROzFE0gQpZZ0eKJ/m8iMzrmS6PgkWG+ w9Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qSfq5V8R0Thqd8VNqbQbnjGBlavjMbJ0aNdbIaI18AY=; b=YRCOfS+dLygU55J3Ls7QkEC8v8DVBZry6aL2o48Bf1a4bwQT/yTY21XX3adQby9imC Yhh9Z5I2wepf+uR1Tvo0DombMPBwnDE8I5xaajFTdtVvf/aGnZ6UdUAqaV3iXaa19R14 +KNh82rvo015Cc7N7fgR7fbxFecHahUbI8E9dqwpswZNK0ZLRJNCBBpiwmnUcWpmcT+U 0juTqwnllY4XTb1hXAAAvbo8+/m8GAtojePBJhku29yg6AC3rwHDdf2g0CFZet42neeO l2NmTM/EIZ7hOuLuxc4d2KIlRddSCmSHayNqetZi/vZW+z3G6LXtAUoDWSeQi9/sv3n+ 9stQ== X-Gm-Message-State: APjAAAVGcvjaVmPnvcJ7EwSKrYSB1b/AIFRhkD6XfQ8Gqyi+dIOp4lza Z2s6TVjiQ+NhtB5VkkNWR5g= X-Google-Smtp-Source: APXvYqxFgwA+4KVltsIUUo0ZvM6t0FngQWETED57uAKCreiv8fRlswH/irxONjyi17Io2ylgNezLQA== X-Received: by 2002:a5d:4052:: with SMTP id w18mr8036528wrp.112.1581421269857; Tue, 11 Feb 2020 03:41:09 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id 4sm3335296wmg.22.2020.02.11.03.41.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2020 03:41:09 -0800 (PST) From: luca.boccassi@gmail.com To: Kalesh AP Cc: Somnath Kotur , Ajit Khaparde , dpdk stable Date: Tue, 11 Feb 2020 11:21:48 +0000 Message-Id: <20200211112216.3929-162-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200211112216.3929-1-luca.boccassi@gmail.com> References: <20200211112216.3929-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bnxt: remove redundant if statement' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/13/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 79dd225dbacfe8c5e888c845c17ebc2120c5df8a Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Tue, 28 Jan 2020 12:59:18 +0530 Subject: [PATCH] net/bnxt: remove redundant if statement [ upstream commit cc73dfd0418ed6ca14256677e639c35d82c1e051 ] Since "eth_dev->data->dev_started" has been assigned to 0 at the beginning of bnxt_dev_stop_op() routine, the code inside the if() condition is redundant. Remove it. Anyways "eth_dev->data->dev_link.link_status" will be set to 0 in bnxt_dev_set_link_down_op() later in the routine. Fixes: 316e412299fd ("net/bnxt: fix crash when closing") Signed-off-by: Kalesh AP Signed-off-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 59400f3139..543ab2c7d4 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -933,10 +933,6 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev) bnxt_cancel_fw_health_check(bp); bp->flags &= ~BNXT_FLAG_INIT_DONE; - if (bp->eth_dev->data->dev_started) { - /* TBD: STOP HW queues DMA */ - eth_dev->data->dev_link.link_status = 0; - } bnxt_dev_set_link_down_op(eth_dev); /* Wait for link to be reset and the async notification to process. -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-11 11:17:44.250724533 +0000 +++ 0162-net-bnxt-remove-redundant-if-statement.patch 2020-02-11 11:17:38.768008228 +0000 @@ -1,8 +1,10 @@ -From cc73dfd0418ed6ca14256677e639c35d82c1e051 Mon Sep 17 00:00:00 2001 +From 79dd225dbacfe8c5e888c845c17ebc2120c5df8a Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Tue, 28 Jan 2020 12:59:18 +0530 Subject: [PATCH] net/bnxt: remove redundant if statement +[ upstream commit cc73dfd0418ed6ca14256677e639c35d82c1e051 ] + Since "eth_dev->data->dev_started" has been assigned to 0 at the beginning of bnxt_dev_stop_op() routine, the code inside the if() condition is redundant. Remove it. @@ -11,7 +13,6 @@ bnxt_dev_set_link_down_op() later in the routine. Fixes: 316e412299fd ("net/bnxt: fix crash when closing") -Cc: stable@dpdk.org Signed-off-by: Kalesh AP Signed-off-by: Somnath Kotur @@ -21,10 +22,10 @@ 1 file changed, 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c -index fc3f1a8db8..267a36148c 100644 +index 59400f3139..543ab2c7d4 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c -@@ -948,10 +948,6 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev) +@@ -933,10 +933,6 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev) bnxt_cancel_fw_health_check(bp); bp->flags &= ~BNXT_FLAG_INIT_DONE;