From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09B43A051C for ; Tue, 11 Feb 2020 12:42:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0098D1C014; Tue, 11 Feb 2020 12:42:15 +0100 (CET) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id B8ADB1C025 for ; Tue, 11 Feb 2020 12:42:13 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id m16so11914690wrx.11 for ; Tue, 11 Feb 2020 03:42:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ujtFSUw5wnOWh4CMcezdHoVkyCPzKmqiiAwxYo5tGcA=; b=r2Au7RP+Xl9ikrKi9SOBPMnnFhM0T3APMpXSUBA8Zwk6HSBXnINqBtm2m0Ywfj49/D 0xZ6l2InEWZk2zz5T6M9kblkI+EdeTe4u1RAoXq6CjavSUVCW/NqHngpGTeMT+hJWMGU 8wIR+9W1H8fB1ozjR3jWf6z76x9ZlfMrevXS2Vu+JXOduGnIQvmwvIHMBLTByqwZ4YX+ m3Ue/HVC7VzHb4jM04HkGuaC9IU1znEy74wfEdh1CoLv40aOIyxktT1HPz6dwe8QClqQ oonLLfrP0eNlimWTU1MGPmqf/fxzxLv0YJCaALmDylG/BiF+ar6kQo9XetnVTOS/K3XZ o/ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ujtFSUw5wnOWh4CMcezdHoVkyCPzKmqiiAwxYo5tGcA=; b=o0tx793mZuhxV6Vo6jKhxRq3qN1d+eJV21aOrxwgiFmSdemiTTjmWRKv6KvmlTA+QI 1e+/ZoTCiJPDI9WienTFmvygDVG/TsyNXHo0NbS9PbrjJAd7+sCCrViDgctl4sTKu5bL cHezlaTF2xAxvuSKzUpIRpNs5yfs7fksAbU6ygdyr12x97vG/Im+SBJTDoyLi4hW5L0g ey8K6/n48LNyPCSaLanlLSYDYixIPUE2vKkoUPWglMGqPeYVnb7yqnSoraYaKks39Bk/ RyngiGUBHk/azfasGCFmFQpvOVvrot9mJ6D1ZrmZOFjrYKXBb7tLqkkZIUn+LaHeVODp OtCw== X-Gm-Message-State: APjAAAXWH4JeUFCqf1jfdH6+N+q4n9N1NR/UctFfnk3SF0Daslg+ROH8 iVX8v109FkIFuXjofk3Gco8= X-Google-Smtp-Source: APXvYqyyBLnoZ8iyfL5QJs4FvIDvQtvKaL+ZIW67xC1oAIa4iBt330QnzIoR3L9o2mMPBO4mUsNcBA== X-Received: by 2002:a5d:550f:: with SMTP id b15mr8095878wrv.196.1581421333498; Tue, 11 Feb 2020 03:42:13 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id s19sm3231683wmj.33.2020.02.11.03.42.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2020 03:42:12 -0800 (PST) From: luca.boccassi@gmail.com To: Ori Kam Cc: Ferruh Yigit , dpdk stable Date: Tue, 11 Feb 2020 11:21:57 +0000 Message-Id: <20200211112216.3929-171-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200211112216.3929-1-luca.boccassi@gmail.com> References: <20200211112216.3929-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/testpmd: fix uninitialized members of MPLS' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/13/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 6a5a82c6448f2c3009a632042fdcc5d4ed03d6fb Mon Sep 17 00:00:00 2001 From: Ori Kam Date: Thu, 30 Jan 2020 16:59:35 +0000 Subject: [PATCH] app/testpmd: fix uninitialized members of MPLS [ upstream commit 56d5c1eedf22a1d384120466e6004faf9933d113 ] Some of the members of the MPLS struct are not initialized. This commit init the uninitialized members. Coverity issue: 325735 Fixes: 3e77031be855 ("app/testpmd: add MPLSoGRE encapsulation") Signed-off-by: Ori Kam Reviewed-by: Ferruh Yigit --- app/test-pmd/cmdline_flow.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 3cf05b5072..f059978730 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -4534,7 +4534,9 @@ parse_vc_action_mplsogre_decap(struct context *ctx, const struct token *token, struct rte_flow_item_gre gre = { .protocol = rte_cpu_to_be_16(ETHER_TYPE_MPLS_UNICAST), }; - struct rte_flow_item_mpls mpls; + struct rte_flow_item_mpls mpls = { + .ttl = 0, + }; uint8_t *header; int ret; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-11 11:17:44.527794713 +0000 +++ 0171-app-testpmd-fix-uninitialized-members-of-MPLS.patch 2020-02-11 11:17:38.808008976 +0000 @@ -1,14 +1,15 @@ -From 56d5c1eedf22a1d384120466e6004faf9933d113 Mon Sep 17 00:00:00 2001 +From 6a5a82c6448f2c3009a632042fdcc5d4ed03d6fb Mon Sep 17 00:00:00 2001 From: Ori Kam Date: Thu, 30 Jan 2020 16:59:35 +0000 Subject: [PATCH] app/testpmd: fix uninitialized members of MPLS +[ upstream commit 56d5c1eedf22a1d384120466e6004faf9933d113 ] + Some of the members of the MPLS struct are not initialized. This commit init the uninitialized members. Coverity issue: 325735 Fixes: 3e77031be855 ("app/testpmd: add MPLSoGRE encapsulation") -Cc: stable@dpdk.org Signed-off-by: Ori Kam Reviewed-by: Ferruh Yigit @@ -17,10 +18,10 @@ 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c -index e99e24c29f..c2cc4c57b8 100644 +index 3cf05b5072..f059978730 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c -@@ -4576,7 +4576,9 @@ parse_vc_action_mplsogre_encap(struct context *ctx, const struct token *token, +@@ -4534,7 +4534,9 @@ parse_vc_action_mplsogre_decap(struct context *ctx, const struct token *token, struct rte_flow_item_gre gre = { .protocol = rte_cpu_to_be_16(ETHER_TYPE_MPLS_UNICAST), };