From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB55BA051C for ; Tue, 11 Feb 2020 12:24:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D3D142B9C; Tue, 11 Feb 2020 12:24:40 +0100 (CET) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 4CE6C1BF81 for ; Tue, 11 Feb 2020 12:24:40 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id z3so11891378wru.3 for ; Tue, 11 Feb 2020 03:24:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m/2pTGHTTlDLlbZfjG4pHTBH+GwCDp0D5wXIns44FnI=; b=NCPMt1F7j7erWBX0BaaaquwCw/6cRrmtPvjGhAIRXUyovxJxE6QHW0pOOxK9ycvFSg 1OuvUWHtgnJBXLcDQvHcB2ZRFqH/hia9DSNsYm+1awb4l9+X7aM+ASJ0eXd01RBzhMWN 6O+pJ5eo4a1wBExlICh7q90YTF7ZvXYiPal6D0VOHMi+XpmqxSI91zvm65ZQvr243rZQ fAaefXJm2kjVaL09V1XKYeWW++dSbvfWCdyoEJmiCmOwdnzS6L53UHlKXnc2qQiJP9/4 zh6M7Zl2yvPLaoNy+xTHWT5Y2tG/V8evF6Ds+CXW8NZefi2H37rT1edXiuvQ0ManG1Vi c+3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m/2pTGHTTlDLlbZfjG4pHTBH+GwCDp0D5wXIns44FnI=; b=QVfhoss5R+0j/rmL18fjHtJ1gCFEkeh74RmpEH73XPSXZ2+rRQTd8yWWY+yYvph95a EFd983jDn19jVtBm9OEj8Jvrs+fOR6c5kDSjOVYPjRZY6FSrIw2PDcTAqFh5R9WuUDTX KIuL1TZiz/4zu7tMx0gPmwANrCME3CgZuI1I3KB9/ELZczWmYsFz015Qi+WprzVr/llK oPXdcyjP2kX9aBZELrI+5OtoOlf2m6gdBzO4fh7FPUCNXmGJil/iKu06jOwv0PADzyVe QJ5MPGW3j6zlsqcJQxLAuroQsXfwvekSJ+PrIW/7jX+1mdn5833QsKv7xGpV1QytGicQ dIyw== X-Gm-Message-State: APjAAAWKBKUQ1iyA4vCCW9jr6N/IaJ2ZnwJr4Z3ih8c9yWFA/Hl7qOY3 YQpwDWZ45dSRovp0AkNFZRE= X-Google-Smtp-Source: APXvYqzK0lxPOikn0lIW8fsiwSaJ8PvDotyUBlyS2nIlOuSj4oUKvCRvtpBvDHOgxbarhFgaR7l7DA== X-Received: by 2002:a5d:484d:: with SMTP id n13mr7916901wrs.420.1581420279005; Tue, 11 Feb 2020 03:24:39 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id n1sm4842617wrw.52.2020.02.11.03.24.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2020 03:24:38 -0800 (PST) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: dpdk stable Date: Tue, 11 Feb 2020 11:19:34 +0000 Message-Id: <20200211112216.3929-28-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200211112216.3929-1-luca.boccassi@gmail.com> References: <20200211112216.3929-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/netvsc: fix RSS offload flag' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/13/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From b00e1dc20ba8d3ca16a52175f60445fced63bbda Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 6 Dec 2019 15:52:47 -0800 Subject: [PATCH] net/netvsc: fix RSS offload flag [ upstream commit b1cf08ae095026ec9befe2aeddf4ecd1785a37a6 ] The change to add OFFLOAD_RSS_HASH broke use of netvsc PMD with testpmd. The netvsc driver fails during configure step: Configuring Port 1 (socket 0) hn_dev_configure(): unsupported RX offload: 0x80000 Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload") Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index 164e9ad174..5ef7a452cc 100644 --- a/drivers/net/netvsc/hn_ethdev.c +++ b/drivers/net/netvsc/hn_ethdev.c @@ -42,7 +42,8 @@ DEV_TX_OFFLOAD_VLAN_INSERT) #define HN_RX_OFFLOAD_CAPS (DEV_RX_OFFLOAD_CHECKSUM | \ - DEV_RX_OFFLOAD_VLAN_STRIP) + DEV_RX_OFFLOAD_VLAN_STRIP | \ + DEV_RX_OFFLOAD_RSS_HASH) int hn_logtype_init; int hn_logtype_driver; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-11 11:17:40.148805586 +0000 +++ 0028-net-netvsc-fix-RSS-offload-flag.patch 2020-02-11 11:17:38.340000225 +0000 @@ -1,8 +1,10 @@ -From b1cf08ae095026ec9befe2aeddf4ecd1785a37a6 Mon Sep 17 00:00:00 2001 +From b00e1dc20ba8d3ca16a52175f60445fced63bbda Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 6 Dec 2019 15:52:47 -0800 Subject: [PATCH] net/netvsc: fix RSS offload flag +[ upstream commit b1cf08ae095026ec9befe2aeddf4ecd1785a37a6 ] + The change to add OFFLOAD_RSS_HASH broke use of netvsc PMD with testpmd. The netvsc driver fails during configure step: @@ -10,7 +12,6 @@ hn_dev_configure(): unsupported RX offload: 0x80000 Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload") -Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger ---