From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 071D5A051C for ; Tue, 11 Feb 2020 12:24:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EDEE82B9C; Tue, 11 Feb 2020 12:24:42 +0100 (CET) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id A54831BF98 for ; Tue, 11 Feb 2020 12:24:41 +0100 (CET) Received: by mail-wm1-f66.google.com with SMTP id a9so3053832wmj.3 for ; Tue, 11 Feb 2020 03:24:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JZQEKlXYe7/LxVLC5u6TaaK8dGEr5ULQjdNHq7O5rQY=; b=L8POJ/oz57wrDaWWvfpp8JEpKIPwb6Y9eB8ZxGnpNyJJjzvYS7gTJ79T3r7bmvFsuF tlq/2qGg0eNBZEhtcB88fL5VKJZ/vQGJ9KQFuWOz+8LvbqZMR9uOxd9MenoVvHI4/TxE p1TUEDv9JIrGgyDo6g01I6OvtIDVS6Q6gszbkPEitNlv4f+0TxUqD/fmqjxRtMuXSUWf 6ms/+8VepClrZDG32T0o5vWDrumuk1RhatypNn2OAsXwU0crDc3QIOm0ZPWycOp8x8cb MQ1LxHTnnIK9LmwfTDGKhbUdqg/yXgLhrpw8ZlzNV3gqJSHog9YFF3zgiV0dJ/4PHgsu Kwdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JZQEKlXYe7/LxVLC5u6TaaK8dGEr5ULQjdNHq7O5rQY=; b=TRffDuUZm3Evpqt4G1clBKIss2smS7R90myd1X9H9lsLuaRIRCY0RdOlpdu1viiI6m dAQX/lUpfnmOJVje6ryORGczqImcKED7FTh1fUGYeseQ94c6yv9/5P9vyK1m9OUuZbhg ZAMRvKfnDz4z8f9dtkHbyQRJemrM0KBRfJx9rr7b6WGmja8+REl7QVUSYynVx7aeVdPj qzhvMlwlwvkO0BKh0+sE8D5w0J1xbUz/ynwmkkk+pMD7wjjaI6PxaWIJ331LZsIhK+1f 1XX0kRUYZK35W2/xt9waqHDdYxnZQXQsWvoiYDF5xMWnCj30xDG4PEpSNwEI1PaJpBB/ 8Lyg== X-Gm-Message-State: APjAAAUCG2aZCSJNp9gM5pkwZGl5FEOGglOjb+EqAnro/sqDtjZO3p1t JiA8qYAe2BBCqPxkoQGyGJI= X-Google-Smtp-Source: APXvYqw1CQuiJVuclMDMGDRTaraE1V59zDzittpQlnq2tKz11anxxKObLntzlqyc/aKlKQAD5mat1w== X-Received: by 2002:a1c:7317:: with SMTP id d23mr5275756wmb.165.1581420281175; Tue, 11 Feb 2020 03:24:41 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id g18sm3202075wmh.48.2020.02.11.03.24.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2020 03:24:40 -0800 (PST) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: Donald Lee , Dexuan Cui , Abhishek Marathe , dpdk stable Date: Tue, 11 Feb 2020 11:19:35 +0000 Message-Id: <20200211112216.3929-29-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200211112216.3929-1-luca.boccassi@gmail.com> References: <20200211112216.3929-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/netvsc: disable before changing RSS parameters' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/13/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 99682e1dc776a2c7ccb6965a4d6987bc5c75f8de Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 6 Dec 2019 15:52:48 -0800 Subject: [PATCH] net/netvsc: disable before changing RSS parameters [ upstream commit b604e806327cd4945cc560722cf4c0b3518f0bc6 ] In order to change RSS parameters, the host requires that RSS is disable first. Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters") Signed-off-by: Donald Lee Signed-off-by: Stephen Hemminger Tested-by: Dexuan Cui Tested-by: Abhishek Marathe --- drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index 5ef7a452cc..159116f7f6 100644 --- a/drivers/net/netvsc/hn_ethdev.c +++ b/drivers/net/netvsc/hn_ethdev.c @@ -292,6 +292,13 @@ static int hn_rss_reta_update(struct rte_eth_dev *dev, hv->rss_ind[i] = reta_conf[idx].reta[shift]; } + err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE); + if (err) { + PMD_DRV_LOG(NOTICE, + "rss disable failed"); + return err; + } + err = hn_rndis_conf_rss(hv, 0); if (err) { PMD_DRV_LOG(NOTICE, @@ -579,6 +586,13 @@ static int hn_dev_configure(struct rte_eth_dev *dev) return err; } + err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE); + if (err) { + PMD_DRV_LOG(NOTICE, + "rss disable failed"); + return err; + } + err = hn_rndis_conf_rss(hv, 0); if (err) { PMD_DRV_LOG(NOTICE, -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-11 11:17:40.177141149 +0000 +++ 0029-net-netvsc-disable-before-changing-RSS-parameters.patch 2020-02-11 11:17:38.340000225 +0000 @@ -1,13 +1,14 @@ -From b604e806327cd4945cc560722cf4c0b3518f0bc6 Mon Sep 17 00:00:00 2001 +From 99682e1dc776a2c7ccb6965a4d6987bc5c75f8de Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 6 Dec 2019 15:52:48 -0800 Subject: [PATCH] net/netvsc: disable before changing RSS parameters +[ upstream commit b604e806327cd4945cc560722cf4c0b3518f0bc6 ] + In order to change RSS parameters, the host requires that RSS is disable first. Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters") -Cc: stable@dpdk.org Signed-off-by: Donald Lee Signed-off-by: Stephen Hemminger