From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5852AA051C for ; Tue, 11 Feb 2020 12:24:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F77A1BF9E; Tue, 11 Feb 2020 12:24:49 +0100 (CET) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 5107D1BF9E for ; Tue, 11 Feb 2020 12:24:48 +0100 (CET) Received: by mail-wm1-f67.google.com with SMTP id a9so3054207wmj.3 for ; Tue, 11 Feb 2020 03:24:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z0MhXpacrRsKstFg8T6bcVe10nyv2HjqEa5kEAnyIZs=; b=cLjrXPSZ5eWNF7yYiczU1zsE3iYR2kBeWE1y9FNswvBhSS6tiCvaaUnDNy5dh3ofcm kbksLZB3AIWnHWW0o15ozqmYHpmZfuUVdJx06ucykhEpvE9MP1NuS686uLwHnI2qPQ/s JgHf1ZINdC8t1i7tZAvrAFHtfQEF2kUBowURRgJPh1QWsTHyi3nHv/cu+30Gzxv31R2K 63Z/23yG0QGRWDo/83fONFDgbLaQ90cpOlUjwfcsPURjjV6ePOVPg+hYnpPRoXwNvbi6 uysyfFLeCV7+JB80ftM8E68gI0j5zEpr6BaY0BzLnRM16Bb5j2xNpUyQnLbr5jrTMQmY U4pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z0MhXpacrRsKstFg8T6bcVe10nyv2HjqEa5kEAnyIZs=; b=KV64AUrqpirgyWTnConORcoi9ZV/BY5Lr7rbROmSQJvj7hQGcIS+JPBQg9Ahy1dZmF r13ncwrH30JGDaiVGYpL0lNj3QhQywq4LH2l/YgaKF5rJKLTKTQQEz48hD+XHIISCFby qJJALR3/US/mgcyFf0uz+as9NVvqCLuRJxgQrxSOQmJmMOEHI/kUURvAqDwMOVNTc3D4 QZ/RDWISakX8whoDFJZjKY+U5rw9VYhn55rx4lo5uc5MRh4MUCc6Fchge5RDfqmx/BG8 FY1sUjRLmHbFe4BvmfE8NmbcsStcgDp7X3LNva6qAGBlP8uh3JHPSNN5m18hOmD7fd9E yN1Q== X-Gm-Message-State: APjAAAWQnnV0+EbK3ebySIBnaV3rhfPnUItzfT2TuQnK3OHV91/fYmy/ FA0eDbXGhvrMpIGSRTcvomAj9hedvI0= X-Google-Smtp-Source: APXvYqyKKf+zF5v0bTj6NuIcbjlMS7Kg2pm8aTUHQvh93pJZcsTbvgxck87gwtDPjM9xPxR6DKOveA== X-Received: by 2002:a1c:4d07:: with SMTP id o7mr5286163wmh.174.1581420288070; Tue, 11 Feb 2020 03:24:48 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id f8sm4859910wru.12.2020.02.11.03.24.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2020 03:24:47 -0800 (PST) From: luca.boccassi@gmail.com To: Chenxu Di Cc: Xiaolong Ye , dpdk stable Date: Tue, 11 Feb 2020 11:19:39 +0000 Message-Id: <20200211112216.3929-33-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200211112216.3929-1-luca.boccassi@gmail.com> References: <20200211112216.3929-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/i40e: fix port close in FreeBSD' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/13/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 96ffc75a08059f60790b68d0b652b872e48ffd53 Mon Sep 17 00:00:00 2001 From: Chenxu Di Date: Wed, 11 Dec 2019 09:06:03 +0000 Subject: [PATCH] net/i40e: fix port close in FreeBSD [ upstream commit 1fa41f4518f9f30465a0ed32640e7dbce00b3f4f ] FreeBSD OS doesn't support igb_uio interrupt, so it will fail when unregister the interrupt callback in port close. We can fix the issue by passing -ENOENT when check the return value of unregister interrupt callback function. Fixes: ac89d46096d5 ("net/i40e: release port upon close") Signed-off-by: Chenxu Di Acked-by: Xiaolong Ye --- drivers/net/i40e/i40e_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 5999c964bd..8b25003910 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2594,7 +2594,7 @@ i40e_dev_close(struct rte_eth_dev *dev) do { ret = rte_intr_callback_unregister(intr_handle, i40e_dev_interrupt_handler, dev); - if (ret >= 0) { + if (ret >= 0 || ret == -ENOENT) { break; } else if (ret != -EAGAIN) { PMD_INIT_LOG(ERR, -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-11 11:17:40.290011769 +0000 +++ 0033-net-i40e-fix-port-close-in-FreeBSD.patch 2020-02-11 11:17:38.356000524 +0000 @@ -1,15 +1,16 @@ -From 1fa41f4518f9f30465a0ed32640e7dbce00b3f4f Mon Sep 17 00:00:00 2001 +From 96ffc75a08059f60790b68d0b652b872e48ffd53 Mon Sep 17 00:00:00 2001 From: Chenxu Di Date: Wed, 11 Dec 2019 09:06:03 +0000 Subject: [PATCH] net/i40e: fix port close in FreeBSD +[ upstream commit 1fa41f4518f9f30465a0ed32640e7dbce00b3f4f ] + FreeBSD OS doesn't support igb_uio interrupt, so it will fail when unregister the interrupt callback in port close. We can fix the issue by passing -ENOENT when check the return value of unregister interrupt callback function. Fixes: ac89d46096d5 ("net/i40e: release port upon close") -Cc: stable@dpdk.org Signed-off-by: Chenxu Di Acked-by: Xiaolong Ye