From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2E8CA051C for ; Tue, 11 Feb 2020 12:27:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CBBDE2B9C; Tue, 11 Feb 2020 12:27:59 +0100 (CET) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 651062B9C for ; Tue, 11 Feb 2020 12:27:58 +0100 (CET) Received: by mail-wm1-f68.google.com with SMTP id q9so3017982wmj.5 for ; Tue, 11 Feb 2020 03:27:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FJTkymx9ywKPsJ220yDma2RTkpUEXhkCa785bN5/O1Y=; b=Qdb3Cla3PiOL0QtZNhuHJxJq6G1/vAaHrfvFyUG4AlQZfJ1ZMPptbjkPvb/rqHo37F E20TklE9fekrUwkfMSvDZsgK4jVprVYip2bNgsrRiZH2uFHmfnYw9nLJbPg7+wO1jACN 9qx6AaYRqeRGfRI0usPl6P6P0qi/qSGGym9OR/JXYpxukINQ20VgdKDrfm4RVII/T11/ DNPhfhZJLl+CCTbxeoH3AOYXAqUYW5jk/h+Fc+vbk78bjYJqOmExX7IUUFb4W+RcjnIU ptuSrcvwakeiBdbHsBjQaWY1+eOMmwuQvlJPT1rw7q27EyM4o3QfKLfPHTzKm5DfaLzM OVSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FJTkymx9ywKPsJ220yDma2RTkpUEXhkCa785bN5/O1Y=; b=ECW8KPTkVDXSIE6LBm2aQPQKLK218Q8w7QDyZiCPZXTx92oLY2H/IjTMMYiUGJSbIl mZYGX2j8vAFNRDoCl3KMFG7Au77eaWFJnEWaN0+qxJyPhOkFRiDKjxH9zFrxMA4+Y2lx DGvFUvUSHnbnuggvZLzZZeQIdjO2BuIWahcSyUuLUnwuguN2ioWLFeXWlLhskMSAFXxf 9p60As6hiJHSpZV3SxUA94DiUWRfjG7GZEOXuayZ0ui2f5pDEA/siPMUyjwNB8zd4G2A CP2/fsjn/gf9py5i7+WmZk5KeUKXOC7e+G64tOPhD5o/lSc2mkhHOzDocuomxRKC1fb7 MBTA== X-Gm-Message-State: APjAAAXkPThDfdAFuyUngySEK5Yguu6Z5Gnb0EGY/BlDIt6dkJG4Nrls iJvYAjY2adRzU0NKKpY1w4M= X-Google-Smtp-Source: APXvYqyVJ2IgxNUBu1BM3Cc11C0Z4+urjq70tzUghgfK6mgU28fTDL3fqlJmRYmwIG7qbpcQsw6g8A== X-Received: by 2002:a1c:f001:: with SMTP id a1mr4985113wmb.76.1581420477092; Tue, 11 Feb 2020 03:27:57 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id q10sm3338296wme.16.2020.02.11.03.27.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2020 03:27:56 -0800 (PST) From: luca.boccassi@gmail.com To: Xiao Wang Cc: Ciara Loftus , dpdk stable Date: Tue, 11 Feb 2020 11:20:07 +0000 Message-Id: <20200211112216.3929-61-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200211112216.3929-1-luca.boccassi@gmail.com> References: <20200211112216.3929-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/af_xdp: fix redundant check for wakeup need' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/13/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From a0be896b85d0150b859e94e9f23a1b7c33a74b1a Mon Sep 17 00:00:00 2001 From: Xiao Wang Date: Mon, 6 Jan 2020 09:09:40 -0500 Subject: [PATCH] net/af_xdp: fix redundant check for wakeup need [ upstream commit fdf69a8179245b01de3a736938166331487f4257 ] Function kick_tx() has built-in detection on NEED_WAKEUP flag, so just call it directly, like elsewhere in the driver. Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") Signed-off-by: Xiao Wang Tested-by: Ciara Loftus --- drivers/net/af_xdp/rte_eth_af_xdp.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index 2b1245ee4f..d903e6c28a 100644 --- a/drivers/net/af_xdp/rte_eth_af_xdp.c +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c @@ -480,10 +480,7 @@ af_xdp_tx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) tx_bytes += mbuf->pkt_len; } -#if defined(XDP_USE_NEED_WAKEUP) - if (xsk_ring_prod__needs_wakeup(&txq->tx)) -#endif - kick_tx(txq); + kick_tx(txq); out: xsk_ring_prod__submit(&txq->tx, count); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-11 11:17:41.172328033 +0000 +++ 0061-net-af_xdp-fix-redundant-check-for-wakeup-need.patch 2020-02-11 11:17:38.452002319 +0000 @@ -1,13 +1,14 @@ -From fdf69a8179245b01de3a736938166331487f4257 Mon Sep 17 00:00:00 2001 +From a0be896b85d0150b859e94e9f23a1b7c33a74b1a Mon Sep 17 00:00:00 2001 From: Xiao Wang Date: Mon, 6 Jan 2020 09:09:40 -0500 Subject: [PATCH] net/af_xdp: fix redundant check for wakeup need +[ upstream commit fdf69a8179245b01de3a736938166331487f4257 ] + Function kick_tx() has built-in detection on NEED_WAKEUP flag, so just call it directly, like elsewhere in the driver. Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") -Cc: stable@dpdk.org Signed-off-by: Xiao Wang Tested-by: Ciara Loftus