From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D20DA051C for ; Tue, 11 Feb 2020 12:28:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 65B972B9C; Tue, 11 Feb 2020 12:28:13 +0100 (CET) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 2E2C71BF9C for ; Tue, 11 Feb 2020 12:28:12 +0100 (CET) Received: by mail-wm1-f65.google.com with SMTP id a6so3078698wme.2 for ; Tue, 11 Feb 2020 03:28:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/V41VLVGIIUM/iBd4AiIXcnfaI3UWmf6GjQZLJYXhho=; b=JOwLz9ZM0s9gNebDcxNGlsT+iDWKzRhuUgNNziFLn+uhNqlr9IyXFm7i8YpFZ0Du9P TX+kRDiWlM933U6DiY4X1BheVREk4PMdaZvgMaiJEH/LwPvyb7/YEIVl6U2qJCAseEwQ Jl4qA/8fofE0OIl5eoC4I4rN7ECPg+Q4e4DK2daes9ydlAEofibax6oUgEMHcyc4ZCpy ywF6Zc0WC62OrPLHy5vueCiox/8UccOBt7C4mKopwuPYL8fS7SCSAOX3NevxLyN7+ToM WPDymSK/1QBQGJDH4x9TohAtPEG3tMVkP8qEx9LWI0pXxIxrZzTkvq+OuPjTWSVrspwK QBcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/V41VLVGIIUM/iBd4AiIXcnfaI3UWmf6GjQZLJYXhho=; b=tyAXTsRu5L+S20aejcwWq28JRms/OjBMJFDjGs75VU7gmjBoO9yJ7sKK5cntFFVDEj p8PNzb6SkVx8toz8aomI8NLAMxPbX35eaIS7Hz+o0a0bTkE2CyZ5wV7N7KAmZ2M/52WU 7eTPn/A8vUaD8BStORczntR4CTGFCXfg4230wXhk4VHry3D/EdeqpLALodjEO/b1tnbD 3GKzvN/dKtJnhzUqhLjAX4YA98kv80vBlgHeDAObhKiofeaDuPfVdeIqLC/LWK4v7j5f XVxpFiqVJvc+Yca3t/5HDzlHItU2wg/wjdVVz36eh6DCVKpUq2gvOf/kU5P6dIX5yLa/ sLhQ== X-Gm-Message-State: APjAAAXuODg2vR7AlCcjomOIDvYOhtOjPR9LVMI8PbGVJTkF+R+0EAIJ 6SD89ovvOAX8GFQKjGTcVTY= X-Google-Smtp-Source: APXvYqz4NTwezU5AydZr9kaI46HxaSfd32Y1mXAWjmg1HFRRFv4yrSd0VclDbgKcQq/uEXYce8vlMA== X-Received: by 2002:a7b:c93a:: with SMTP id h26mr5409582wml.83.1581420491884; Tue, 11 Feb 2020 03:28:11 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id a62sm3442967wmh.33.2020.02.11.03.28.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2020 03:28:11 -0800 (PST) From: luca.boccassi@gmail.com To: Xiaolong Ye Cc: Doug Dziggel , Dariusz Chaberski , Qi Zhang , Beilei Xing , dpdk stable Date: Tue, 11 Feb 2020 11:20:16 +0000 Message-Id: <20200211112216.3929-70-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200211112216.3929-1-luca.boccassi@gmail.com> References: <20200211112216.3929-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/i40e/base: fix Tx descriptors number' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/13/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From a66d1b7e3fb5a70af1c9f289f40f753702fef6a8 Mon Sep 17 00:00:00 2001 From: Xiaolong Ye Date: Mon, 13 Jan 2020 10:39:30 +0800 Subject: [PATCH] net/i40e/base: fix Tx descriptors number [ upstream commit 79bfe7808788c8a9fb7be87cb864dba2bcbab80d ] The existing driver allows setting the number of TX descriptors to the value that is indivisible by 32. This is not properly supported by x710 hardware. The patch limits the number of TX descriptors to the whole value of 32. Fixes: 8db9e2a1b232 ("i40e: base driver") Signed-off-by: Doug Dziggel Signed-off-by: Dariusz Chaberski Signed-off-by: Xiaolong Ye Acked-by: Qi Zhang Acked-by: Beilei Xing --- drivers/net/i40e/base/i40e_type.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_type.h index 06863d772d..8c7fc4394a 100644 --- a/drivers/net/i40e/base/i40e_type.h +++ b/drivers/net/i40e/base/i40e_type.h @@ -79,8 +79,8 @@ typedef void (*I40E_ADMINQ_CALLBACK)(struct i40e_hw *, struct i40e_aq_desc *); #define I40E_HI_BYTE(x) ((u8)(((x) >> 8) & 0xFF)) #define I40E_LO_BYTE(x) ((u8)((x) & 0xFF)) -/* Number of Transmit Descriptors must be a multiple of 8. */ -#define I40E_REQ_TX_DESCRIPTOR_MULTIPLE 8 +/* Number of Transmit Descriptors must be a multiple of 32. */ +#define I40E_REQ_TX_DESCRIPTOR_MULTIPLE 32 /* Number of Receive Descriptors must be a multiple of 32 if * the number of descriptors is greater than 32. */ -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-11 11:17:41.437481264 +0000 +++ 0070-net-i40e-base-fix-Tx-descriptors-number.patch 2020-02-11 11:17:38.476002768 +0000 @@ -1,15 +1,16 @@ -From 79bfe7808788c8a9fb7be87cb864dba2bcbab80d Mon Sep 17 00:00:00 2001 +From a66d1b7e3fb5a70af1c9f289f40f753702fef6a8 Mon Sep 17 00:00:00 2001 From: Xiaolong Ye Date: Mon, 13 Jan 2020 10:39:30 +0800 Subject: [PATCH] net/i40e/base: fix Tx descriptors number +[ upstream commit 79bfe7808788c8a9fb7be87cb864dba2bcbab80d ] + The existing driver allows setting the number of TX descriptors to the value that is indivisible by 32. This is not properly supported by x710 hardware. The patch limits the number of TX descriptors to the whole value of 32. Fixes: 8db9e2a1b232 ("i40e: base driver") -Cc: stable@dpdk.org Signed-off-by: Doug Dziggel Signed-off-by: Dariusz Chaberski @@ -21,7 +22,7 @@ 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_type.h -index 8d257e00af..f0e4b667aa 100644 +index 06863d772d..8c7fc4394a 100644 --- a/drivers/net/i40e/base/i40e_type.h +++ b/drivers/net/i40e/base/i40e_type.h @@ -79,8 +79,8 @@ typedef void (*I40E_ADMINQ_CALLBACK)(struct i40e_hw *, struct i40e_aq_desc *);