From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A96EA051C for ; Tue, 11 Feb 2020 12:28:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 030FA2B9C; Tue, 11 Feb 2020 12:28:34 +0100 (CET) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id B8C5C2B9C for ; Tue, 11 Feb 2020 12:28:32 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id z7so11835168wrl.13 for ; Tue, 11 Feb 2020 03:28:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oiMFDqzXi7lG5JJRC5O85geGC89N1iU5qF+QmNdhBLk=; b=NnJWCYy/v3vH3NkRnRY4IP3X7YZQbsaulFc+SI+KMSZdJ+SEG1GuWRSatgSLXp4Kgw wKvOCxZJMYw/Y5/ySsQ42MeR780YJ2gR2+g9R+VqC4saMQ2mt0cCDhevZMSaG2nKZPSh +35sUkFSIu3eF3jkl3OMCNmFCebwJR27fk3x1XpcjU4lMQWRyw/I/81CMfJdqIbYTxXf rIzRx3uV/sCVa8wNw+REGOlHO2v2fnrNXAy5IagyqRlhD9xqhXuwvv1F229jFyOxpYAc RTwckhXrbFaHa+Vo3Xl01QpM3ACEscYmhaS5/sud4lUpl1UnivZ0pJWmgpKQTH7byZ0c nz9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oiMFDqzXi7lG5JJRC5O85geGC89N1iU5qF+QmNdhBLk=; b=kfRrnLMuSXHJ+cGtTE8yXk1QS58Mf+p5opQCHicIKPSeiK8+mYhCnDxoDPLVczFYsa 02M6N1RY/6KOL9r1drGzFIUyXm3JrITV1n4efZ1XAahh2i0bKTq0kq5ZaZFDjOkaasbX oYGOmaR+7lsk+OfgZfBtTkZmO5fzMR4fbkSWBgdbdiZ0wPmEgjSkJoNPWaObfOYpP0qb vC6C+dMJxLER743WvsR++8q/bVfnp5zUsAQbZMJ7pbjzujhhOdLsGmvwc8dt4Yw3YUWd 5HfendxWjMER9BbzuES6t6jOAW7Q7NpA8baJXLnAF3BblqMdcWLeu3lh1NiGSlcWIHnK qNtg== X-Gm-Message-State: APjAAAUgVwH2noK7SJI9eCnOBY5/ZvSIO9gudKPuSCDWbBcYgpFseBhG Wd+CZxEETT4n67fO4iFVq/s= X-Google-Smtp-Source: APXvYqwXbGApy0r8z5M62+TTWuAISNd3MtITBPyOkgjkIgOodPmsyL9IKt5M8GOOEfxAAOYyE5Z7JA== X-Received: by 2002:adf:97d6:: with SMTP id t22mr7955176wrb.407.1581420512484; Tue, 11 Feb 2020 03:28:32 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id d9sm4844448wrx.94.2020.02.11.03.28.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2020 03:28:32 -0800 (PST) From: luca.boccassi@gmail.com To: Dekel Peled Cc: Ori Kam , Andrew Rybchenko , dpdk stable Date: Tue, 11 Feb 2020 11:20:23 +0000 Message-Id: <20200211112216.3929-77-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200211112216.3929-1-luca.boccassi@gmail.com> References: <20200211112216.3929-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/testpmd: fix GENEVE flow item' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/13/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 44ff767e7aee732809944763c205e2252bab9ba4 Mon Sep 17 00:00:00 2001 From: Dekel Peled Date: Wed, 8 Jan 2020 17:07:02 +0200 Subject: [PATCH] app/testpmd: fix GENEVE flow item [ upstream commit dcd05da0aed1674263918b3b25b987c7bc99da88 ] Previous patch added support of GENEVE pattern item in flow rule. Function flow_item_default_mask() was not updated, so using it with GENEVE item returns null. Using testpmd command "set raw_decap" or "set raw_encap" with GENEVE item, without specifying any parameters, results in segmentation fault. This patch updates function flow_item_default_mask(), adding case to handle GENEVE item. Fixes: 0f4203fe9d18 ("app/testpmd: support GENEVE pattern item in flow rules") Signed-off-by: Dekel Peled Acked-by: Ori Kam Acked-by: Andrew Rybchenko --- app/test-pmd/cmdline_flow.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 99dade7d8c..3cf05b5072 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -6236,6 +6236,9 @@ flow_item_default_mask(const struct rte_flow_item *item) case RTE_FLOW_ITEM_TYPE_GTP_PSC: mask = &rte_flow_item_gtp_psc_mask; break; + case RTE_FLOW_ITEM_TYPE_GENEVE: + mask = &rte_flow_item_geneve_mask; + break; case RTE_FLOW_ITEM_TYPE_PPPOE_PROTO_ID: mask = &rte_flow_item_pppoe_proto_id_mask; default: -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-11 11:17:41.654768381 +0000 +++ 0077-app-testpmd-fix-GENEVE-flow-item.patch 2020-02-11 11:17:38.504003291 +0000 @@ -1,8 +1,10 @@ -From dcd05da0aed1674263918b3b25b987c7bc99da88 Mon Sep 17 00:00:00 2001 +From 44ff767e7aee732809944763c205e2252bab9ba4 Mon Sep 17 00:00:00 2001 From: Dekel Peled Date: Wed, 8 Jan 2020 17:07:02 +0200 Subject: [PATCH] app/testpmd: fix GENEVE flow item +[ upstream commit dcd05da0aed1674263918b3b25b987c7bc99da88 ] + Previous patch added support of GENEVE pattern item in flow rule. Function flow_item_default_mask() was not updated, so using it with GENEVE item returns null. @@ -14,7 +16,6 @@ adding case to handle GENEVE item. Fixes: 0f4203fe9d18 ("app/testpmd: support GENEVE pattern item in flow rules") -Cc: stable@dpdk.org Signed-off-by: Dekel Peled Acked-by: Ori Kam @@ -24,10 +25,10 @@ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c -index 77a6141ee3..1240de4efb 100644 +index 99dade7d8c..3cf05b5072 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c -@@ -6286,6 +6286,9 @@ flow_item_default_mask(const struct rte_flow_item *item) +@@ -6236,6 +6236,9 @@ flow_item_default_mask(const struct rte_flow_item *item) case RTE_FLOW_ITEM_TYPE_GTP_PSC: mask = &rte_flow_item_gtp_psc_mask; break;