From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67D1DA051C for ; Tue, 11 Feb 2020 12:28:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5FD4B2B9C; Tue, 11 Feb 2020 12:28:57 +0100 (CET) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 70F5B49E0 for ; Tue, 11 Feb 2020 12:28:55 +0100 (CET) Received: by mail-wr1-f65.google.com with SMTP id u6so11930885wrt.0 for ; Tue, 11 Feb 2020 03:28:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CdxoFQx2wQG68Wv3ggQ62IVBbNwvT3VBFwvU2KLhKkA=; b=Vq1/qEC0w6LpuYjA+aJs+9DdqgQO4x0y82x77EIHDUn2BvxQA5V0ydYDZwzKs+IkDM OaIlUENVUnsz/46U3tB2k5wYteH9ul4OiAT1SEyRkpqntezUCJlmxd7Lj50TCbQSIWUU KO1pEJvrD1wr5B50bC23yHOwe3qssRi6Y+57S9ZcIP/CxUqtcS4P7LD70oECrbefdFBJ ViKtxBz4zsruaIBm+bwnEIwkmYMz088KgOJrKFv1eeRlZaqpYq8ZFvhN9RfmZocIdtZP 31VpQVhm0KHJrjEj7QC8Ya8KAwaoFgUPB/YewcbRFR18eB9lHyTaHOUEs5667/rLhihq v39w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CdxoFQx2wQG68Wv3ggQ62IVBbNwvT3VBFwvU2KLhKkA=; b=YY3Io+phXsTzGsITv4eIRHe0TS73kRTBseVsrkViScM2OiTnsUufHfcFIR7CAiafOf Tk1vwma1MJ3aAfHjG7XzA9wilvZxlzFQuuHU6IuY7dAgDRD2HStcJMY+T/ILkPh1fIzQ CgXYiHjIXj409QYD4oa7iS5A7d6lR0uG8P8IafAI65gJSPOxIZ5mF9U69edHIzNTwAa0 LahO4aivSdztZLn6LtSzMzhGu4uyaJ+HdVe5theUcAVeEv/xa8slA56kOtpCaf8vJE5q YdbI8GYjlNNayeDkq3/uSuC9aWGXMC5ZNPizfC8mSBQ91ZyDBmRstN/JWtuIA4mMgWKF yEaA== X-Gm-Message-State: APjAAAXrnzkd0gk1PkQ/s4IOKoAjqz/ICKzHWepAcri1pOntD1DYtjAW t/PElHyMAtRS97gXe3jn+eA= X-Google-Smtp-Source: APXvYqwonxxzo0lhWkOg93nIQunxRm4lNnZAqbMchiy+muiMd3jmeKrMl3j60L+piI/VZZE/qZJ/QA== X-Received: by 2002:adf:e68d:: with SMTP id r13mr7996955wrm.349.1581420535213; Tue, 11 Feb 2020 03:28:55 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id m21sm3285982wmi.27.2020.02.11.03.28.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2020 03:28:54 -0800 (PST) From: luca.boccassi@gmail.com To: "Wei Hu (Xavier)" Cc: Hongbo Zheng , Huisong Li , dpdk stable Date: Tue, 11 Feb 2020 11:20:28 +0000 Message-Id: <20200211112216.3929-82-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200211112216.3929-1-luca.boccassi@gmail.com> References: <20200211112216.3929-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/hns3: fix link status on failed query' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/13/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From bfd523f593e5467b852d992f5ca3bd78a656e7fc Mon Sep 17 00:00:00 2001 From: "Wei Hu (Xavier)" Date: Thu, 9 Jan 2020 11:15:58 +0800 Subject: [PATCH] net/hns3: fix link status on failed query [ upstream commit eee015976b46af8cc218263b97f90e8a5937707c ] Currently, the hns3 PMD driver issues command to the firmware and gets link status information. When the driver fails to call internal interface function named hns3_cmd_send to query the status from firmware for some reason, the link status queried by the driver should be down. Fixes: 59fad0f32135 ("net/hns3: support link update operation") Signed-off-by: Hongbo Zheng Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c index f41a2fefd8..7e601b8bf8 100644 --- a/drivers/net/hns3/hns3_ethdev.c +++ b/drivers/net/hns3/hns3_ethdev.c @@ -3786,7 +3786,7 @@ hns3_get_mac_link_status(struct hns3_hw *hw) ret = hns3_cmd_send(hw, &desc, 1); if (ret) { hns3_err(hw, "get link status cmd failed %d", ret); - return ret; + return ETH_LINK_DOWN; } req = (struct hns3_link_status_cmd *)desc.data; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-11 11:17:41.809476826 +0000 +++ 0082-net-hns3-fix-link-status-on-failed-query.patch 2020-02-11 11:17:38.520003591 +0000 @@ -1,8 +1,10 @@ -From eee015976b46af8cc218263b97f90e8a5937707c Mon Sep 17 00:00:00 2001 +From bfd523f593e5467b852d992f5ca3bd78a656e7fc Mon Sep 17 00:00:00 2001 From: "Wei Hu (Xavier)" Date: Thu, 9 Jan 2020 11:15:58 +0800 Subject: [PATCH] net/hns3: fix link status on failed query +[ upstream commit eee015976b46af8cc218263b97f90e8a5937707c ] + Currently, the hns3 PMD driver issues command to the firmware and gets link status information. @@ -11,7 +13,6 @@ link status queried by the driver should be down. Fixes: 59fad0f32135 ("net/hns3: support link update operation") -Cc: stable@dpdk.org Signed-off-by: Hongbo Zheng Signed-off-by: Huisong Li @@ -21,10 +22,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c -index b05a557814..9866d147be 100644 +index f41a2fefd8..7e601b8bf8 100644 --- a/drivers/net/hns3/hns3_ethdev.c +++ b/drivers/net/hns3/hns3_ethdev.c -@@ -3836,7 +3836,7 @@ hns3_get_mac_link_status(struct hns3_hw *hw) +@@ -3786,7 +3786,7 @@ hns3_get_mac_link_status(struct hns3_hw *hw) ret = hns3_cmd_send(hw, &desc, 1); if (ret) { hns3_err(hw, "get link status cmd failed %d", ret);