From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDB81A051C for ; Tue, 11 Feb 2020 12:29:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C49272B9C; Tue, 11 Feb 2020 12:29:03 +0100 (CET) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id E36051BF83 for ; Tue, 11 Feb 2020 12:29:02 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id t2so11919982wrr.1 for ; Tue, 11 Feb 2020 03:29:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=clXqBSVFtH4sO1oOEvpMK771aLd/KvuuZwJJrZ9Auog=; b=ezMyqFFFQfok/a8n/kw8EmxbiTA1IMEQ17ib/DmV+uMtubtoAgUpBFu35UQZQDI2Cs KKmXMGXNH4IuVQVFIrWzwzCisfW0oni/uL5Ii2X7h1ON6VO0HxNDRBYJPBhDHp7W9sp2 OchKoc4mCtxVhwUoQWXkeN9bzATSaHmRXtdA33j6J5+ATLaPglQZUTQdjRTEzAmZuxtN 30/npH+utlm2BV3DSn1q1YX5OJN/NETLzmr0izCzSCdUhekv/MoOaixh6K6LMp2ofn17 uPtkQX4cj90wWikrXvXdl7ZOHrqdYY7jNFRBl98FJrF4oJ2GhyEem5un40Htapj0ijMT y/OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=clXqBSVFtH4sO1oOEvpMK771aLd/KvuuZwJJrZ9Auog=; b=phUz9gN+MsxOrMiHpAunfPTeiI4ZxrOosJi2ACMR9ZXgJVpcvdT4Ug3sbFE//G6b53 Zi2a4eizBbukHfdxX6YSSlim3oUKePUJ1ohC1QjTF+aOPanZvGZ85kt8ttAwt78F/gjX X1dFUqQGzziEQzbwf4qh0IQT3ZqtqMXF40CPyLCuibLeHEdPWFHsCcPCQhnZLCMC0vn9 mEM9WYxiY3RgqCLzcRpF7Ig2/gkbiIMcdPg4ROSC11suZSjjYJf1eD2F6Z+qEcxHTgEk XjhskuXHF+8jol/GtAC+SwYwi/bAxs47zlcK212sfzh3S62w8Mwhx1X8IN3i9rtVwOts n4jg== X-Gm-Message-State: APjAAAXiXoImSAzbx34NnHB8vkhSx3+ANLfn9gUOAUlvEaYp/URv6IYb 8x+Lq3tGxUpGXwQBNhm1o2GtTcACfMU= X-Google-Smtp-Source: APXvYqyoiUZln95Tu338dcdnZ4+siPvsa3AHEDFIfNyyYPAtc5sw4OT4FPQLxMBwQ7bYm81KfgmSVA== X-Received: by 2002:adf:a453:: with SMTP id e19mr7867233wra.305.1581420542689; Tue, 11 Feb 2020 03:29:02 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id k8sm4769840wrq.67.2020.02.11.03.29.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2020 03:29:02 -0800 (PST) From: luca.boccassi@gmail.com To: Krzysztof Kanas Cc: Jerin Jacob , dpdk stable Date: Tue, 11 Feb 2020 11:20:32 +0000 Message-Id: <20200211112216.3929-86-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200211112216.3929-1-luca.boccassi@gmail.com> References: <20200211112216.3929-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'mempool/octeontx: fix error handling in initialization' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/13/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 3f1a929aadc613921a352507ba54fc4eac4dbc4e Mon Sep 17 00:00:00 2001 From: Krzysztof Kanas Date: Thu, 19 Dec 2019 11:44:34 +0100 Subject: [PATCH] mempool/octeontx: fix error handling in initialization [ upstream commit 4f2c3c7b1da78bbb6270668e7a2b412863439b7f ] When octeontx_get_fpavf fails fpa pointer is used to get pool_stack_base, which is then freed. Coverity issue: 351263 Fixes: 9bc692f83baa ("mempool/octeontx: add application domain validation") Signed-off-by: Krzysztof Kanas Acked-by: Jerin Jacob --- drivers/mempool/octeontx/octeontx_fpavf.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b/drivers/mempool/octeontx/octeontx_fpavf.c index c97267db3c..63f8fb3b50 100644 --- a/drivers/mempool/octeontx/octeontx_fpavf.c +++ b/drivers/mempool/octeontx/octeontx_fpavf.c @@ -305,10 +305,8 @@ octeontx_fpapf_pool_destroy(unsigned int gpool_index) int ret = -1; fpa = octeontx_get_fpavf(gpool_index); - if (fpa == NULL) { - ret = -EINVAL; - goto err; - } + if (fpa == NULL) + return -EINVAL; hdr.coproc = FPA_COPROC; hdr.msg = FPA_CONFIGSET; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-11 11:17:41.928004926 +0000 +++ 0086-mempool-octeontx-fix-error-handling-in-initializatio.patch 2020-02-11 11:17:38.524003666 +0000 @@ -1,14 +1,15 @@ -From 4f2c3c7b1da78bbb6270668e7a2b412863439b7f Mon Sep 17 00:00:00 2001 +From 3f1a929aadc613921a352507ba54fc4eac4dbc4e Mon Sep 17 00:00:00 2001 From: Krzysztof Kanas Date: Thu, 19 Dec 2019 11:44:34 +0100 Subject: [PATCH] mempool/octeontx: fix error handling in initialization +[ upstream commit 4f2c3c7b1da78bbb6270668e7a2b412863439b7f ] + When octeontx_get_fpavf fails fpa pointer is used to get pool_stack_base, which is then freed. Coverity issue: 351263 Fixes: 9bc692f83baa ("mempool/octeontx: add application domain validation") -Cc: stable@dpdk.org Signed-off-by: Krzysztof Kanas Acked-by: Jerin Jacob