From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6D0CA054C for ; Fri, 14 Feb 2020 18:04:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C41DBF72; Fri, 14 Feb 2020 18:04:57 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id D59A2100C for ; Fri, 14 Feb 2020 18:04:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581699896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qw9FsKOI+iREG6D36k5nDD9nb8rngH8Qa1M6WMjoadc=; b=Zv1YUtKfI0+s3mHJaMJx6u3TiWa74ds1p0Zp1oyiLESYdm2ZLytx3WKobpIQborIDlU1X0 ilMTHG61G8ANQoj9yJgluKduB2ySjKrsnZtciOpvo2jSWMdL96lptubaUvIOgJVki7rgTO s+SPbELOsD0Q6wAe/+/fuDf11zGa1oA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-253-RjhJjm1iPleTSohUN1UMDQ-1; Fri, 14 Feb 2020 12:04:51 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2A0D7DB49; Fri, 14 Feb 2020 17:04:50 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7C4C189F3C; Fri, 14 Feb 2020 17:04:48 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Ajit Khaparde , dpdk stable Date: Fri, 14 Feb 2020 17:03:11 +0000 Message-Id: <20200214170337.25093-17-ktraynor@redhat.com> In-Reply-To: <20200214170337.25093-1-ktraynor@redhat.com> References: <20200214170337.25093-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: RjhJjm1iPleTSohUN1UMDQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'net/bnxt: do not log error if stats queried before start' has been queued to LTS release 18.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/20/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/35b43f2c6315c2442d= 1d54b9a52a4d3f522b9e8c Thanks. Kevin. --- >From 35b43f2c6315c2442d1d54b9a52a4d3f522b9e8c Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 22 Jan 2020 09:55:13 -0800 Subject: [PATCH] net/bnxt: do not log error if stats queried before start [ upstream commit d21e0fcc07cdecaaa177f21941bce5be4d333f67 ] When using pktgen lots of unnecessary errors are printed because pktgen queries statistics before device is started. Fixes: 3e92fd4e4ec0 ("net/bnxt: use dynamic log type") Signed-off-by: Stephen Hemminger Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_stats.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c index 497da0ba35..3846c7d896 100644 --- a/drivers/net/bnxt/bnxt_stats.c +++ b/drivers/net/bnxt/bnxt_stats.c @@ -386,8 +386,6 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev, =20 =09memset(bnxt_stats, 0, sizeof(*bnxt_stats)); -=09if (!(bp->flags & BNXT_FLAG_INIT_DONE)) { -=09=09PMD_DRV_LOG(ERR, "Device Initialization not complete!\n"); +=09if (!(bp->flags & BNXT_FLAG_INIT_DONE)) =09=09return -EIO; -=09} =20 =09num_q_stats =3D RTE_MIN(bp->rx_cp_nr_rings, --=20 2.21.1 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092020-02-14 17:02:37.984879729 +0000 +++ 0017-net-bnxt-do-not-log-error-if-stats-queried-before-st.patch=092020-= 02-14 17:02:36.949407980 +0000 @@ -1 +1 @@ -From d21e0fcc07cdecaaa177f21941bce5be4d333f67 Mon Sep 17 00:00:00 2001 +From 35b43f2c6315c2442d1d54b9a52a4d3f522b9e8c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d21e0fcc07cdecaaa177f21941bce5be4d333f67 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 20a16a629f..65f90e0d85 100644 +index 497da0ba35..3846c7d896 100644 @@ -22 +23 @@ -@@ -391,8 +391,6 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev, +@@ -386,8 +386,6 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,