From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A2DEA054C for ; Fri, 14 Feb 2020 18:05:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 232041DB9; Fri, 14 Feb 2020 18:05:07 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 79E03F72 for ; Fri, 14 Feb 2020 18:05:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581699905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y6AFNH9k6PJ1U2pNwDsVReg5k48fm/o+oFyMUF4PkGY=; b=ZhP8opASIGMAmFBdjRo1HIHaF6F0tQuywMR935UIC5JG/42YNTB1t0QS3dYtwZGVSUjgow wSmXeoSrXI8Labi6CpMhWAffTWdEZNJBz47CFWadjy+zcVR5MZFn2+UxHqFlpmjdXh3Yx1 mePYO0y5BtSabYwtu4sliI2PZV/6jjI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-91-lEs42ai2OEGj1gwV0Hjf6A-1; Fri, 14 Feb 2020 12:05:02 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6A81C801E67; Fri, 14 Feb 2020 17:05:01 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id AF98D84BCD; Fri, 14 Feb 2020 17:04:56 +0000 (UTC) From: Kevin Traynor To: Rasesh Mody Cc: dpdk stable Date: Fri, 14 Feb 2020 17:03:14 +0000 Message-Id: <20200214170337.25093-20-ktraynor@redhat.com> In-Reply-To: <20200214170337.25093-1-ktraynor@redhat.com> References: <20200214170337.25093-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: lEs42ai2OEGj1gwV0Hjf6A-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'net/bnx2x: fix reset of scan FP flag' has been queued to LTS release 18.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/20/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/bf70c73cc8dc32d6ce= 62cbd84d82cd72f678394e Thanks. Kevin. --- >From bf70c73cc8dc32d6ce62cbd84d82cd72f678394e Mon Sep 17 00:00:00 2001 From: Rasesh Mody Date: Sun, 26 Jan 2020 14:54:18 -0800 Subject: [PATCH] net/bnx2x: fix reset of scan FP flag [ upstream commit d836d5efb93505ad86f72c0fcfb0f650858b96ac ] The fastpath task queue handler resets the fastpath scan flag unconditionally, this patch changes that to reset the flag only if it was set. Fixes: 08a6e472c3d7 ("net/bnx2x: fix packet drop") Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index 3b034b1e9d..ab18fe2e56 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -4576,8 +4576,8 @@ static void bnx2x_handle_fp_tq(struct bnx2x_fastpath = *fp) =09=09=09return; =09=09} +=09=09/* We have completed slow path completion, clear the flag */ +=09=09rte_atomic32_set(&sc->scan_fp, 0); =09} =20 -=09/* Assuming we have completed slow path completion, clear the flag */ -=09rte_atomic32_set(&sc->scan_fp, 0); =09bnx2x_ack_sb(sc, fp->igu_sb_id, USTORM_ID, =09=09 le16toh(fp->fp_hc_idx), IGU_INT_ENABLE, 1); --=20 2.21.1 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092020-02-14 17:02:38.142485142 +0000 +++ 0020-net-bnx2x-fix-reset-of-scan-FP-flag.patch=092020-02-14 17:02:36.96= 7407604 +0000 @@ -1 +1 @@ -From d836d5efb93505ad86f72c0fcfb0f650858b96ac Mon Sep 17 00:00:00 2001 +From bf70c73cc8dc32d6ce62cbd84d82cd72f678394e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d836d5efb93505ad86f72c0fcfb0f650858b96ac ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index ed31335ac5..50e289b286 100644 +index 3b034b1e9d..ab18fe2e56 100644 @@ -22 +23 @@ -@@ -4578,8 +4578,8 @@ static void bnx2x_handle_fp_tq(struct bnx2x_fastpath= *fp) +@@ -4576,8 +4576,8 @@ static void bnx2x_handle_fp_tq(struct bnx2x_fastpath= *fp)