From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 699B6A054C for ; Fri, 14 Feb 2020 18:05:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 60A62F72; Fri, 14 Feb 2020 18:05:21 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 59CD2F72 for ; Fri, 14 Feb 2020 18:05:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581699918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7xHobVBamUS0ih2MRg+umC8Cxpzof/sQBS+6EIX0hR0=; b=DqyK1cM8YImKJ1Bm/fLd5ugzikBsxP80LXnB/HkpmGABIbNnPR2BAtktkaS63REKyAHyty KAbuc93qMFEOzDF0Z/PC4mVyapS93N55RcyORMHq8qsQodmUd7hMR0I0eP/aEe8q2VGeRf dLXpebbg3N9pwQiEGATuTi5Q1PGF/sw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-23-9ptdnP_mND-lcJ4KLClNtQ-1; Fri, 14 Feb 2020 12:05:13 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 05723DB22; Fri, 14 Feb 2020 17:05:12 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id F17CC89F3C; Fri, 14 Feb 2020 17:05:08 +0000 (UTC) From: Kevin Traynor To: Kalesh AP Cc: Somnath Kotur , Ajit Khaparde , dpdk stable Date: Fri, 14 Feb 2020 17:03:17 +0000 Message-Id: <20200214170337.25093-23-ktraynor@redhat.com> In-Reply-To: <20200214170337.25093-1-ktraynor@redhat.com> References: <20200214170337.25093-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: 9ptdnP_mND-lcJ4KLClNtQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'net/bnxt: remove redundant if statement' has been queued to LTS release 18.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/20/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/1b234f85b3f218cbb3= 248fd3afd096c594666410 Thanks. Kevin. --- >From 1b234f85b3f218cbb3248fd3afd096c594666410 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Tue, 28 Jan 2020 12:59:18 +0530 Subject: [PATCH] net/bnxt: remove redundant if statement [ upstream commit cc73dfd0418ed6ca14256677e639c35d82c1e051 ] Since "eth_dev->data->dev_started" has been assigned to 0 at the beginning of bnxt_dev_stop_op() routine, the code inside the if() condition is redundant. Remove it. Anyways "eth_dev->data->dev_link.link_status" will be set to 0 in bnxt_dev_set_link_down_op() later in the routine. Fixes: 316e412299fd ("net/bnxt: fix crash when closing") Signed-off-by: Kalesh AP Signed-off-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.= c index 6d7c430030..06dfbf3ec9 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -664,8 +664,4 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_de= v) =20 =09bp->flags &=3D ~BNXT_FLAG_INIT_DONE; -=09if (bp->eth_dev->data->dev_started) { -=09=09/* TBD: STOP HW queues DMA */ -=09=09eth_dev->data->dev_link.link_status =3D 0; -=09} =09bnxt_dev_set_link_down_op(eth_dev); =20 --=20 2.21.1 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092020-02-14 17:02:38.320900303 +0000 +++ 0023-net-bnxt-remove-redundant-if-statement.patch=092020-02-14 17:02:36= .987407187 +0000 @@ -1 +1 @@ -From cc73dfd0418ed6ca14256677e639c35d82c1e051 Mon Sep 17 00:00:00 2001 +From 1b234f85b3f218cbb3248fd3afd096c594666410 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit cc73dfd0418ed6ca14256677e639c35d82c1e051 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index fc3f1a8db8..267a36148c 100644 +index 6d7c430030..06dfbf3ec9 100644 @@ -27 +28 @@ -@@ -949,8 +949,4 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_d= ev) +@@ -664,8 +664,4 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_d= ev)