From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0B73A054C for ; Fri, 14 Feb 2020 18:05:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C8D7AF72; Fri, 14 Feb 2020 18:05:32 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id A4946F72 for ; Fri, 14 Feb 2020 18:05:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581699931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VgQhGhrKmB1g6ccDjVhbp6BD8wRxrc29QzlszFolxlA=; b=YPvl18QmXR75koTKYEUzKHEVEruFRHCXwbVlsOLmr7EwYuUU/f9xbP+ZWjeiOG/b0bzI0k 55fK6xl0EScyr/3wGRHB5eqI+J3SAghWZmaGLC7o6psASzie2slzeDpZoXmh3cP+dMMrpE Y+Fpo7qaZf7t++Hnxv7NdVM/DLu7Q5A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-103-fXbFs4m_P5m1I_EHnTLdfA-1; Fri, 14 Feb 2020 12:05:27 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 033A9107ACC4; Fri, 14 Feb 2020 17:05:26 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4CD7384BCD; Fri, 14 Feb 2020 17:05:20 +0000 (UTC) From: Kevin Traynor To: Ori Kam Cc: Ferruh Yigit , dpdk stable Date: Fri, 14 Feb 2020 17:03:21 +0000 Message-Id: <20200214170337.25093-27-ktraynor@redhat.com> In-Reply-To: <20200214170337.25093-1-ktraynor@redhat.com> References: <20200214170337.25093-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: fXbFs4m_P5m1I_EHnTLdfA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'app/testpmd: fix uninitialized members of MPLS' has been queued to LTS release 18.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/20/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/2f1a2defab638d4ead= 5d07720c488966608fafc2 Thanks. Kevin. --- >From 2f1a2defab638d4ead5d07720c488966608fafc2 Mon Sep 17 00:00:00 2001 From: Ori Kam Date: Thu, 30 Jan 2020 16:59:35 +0000 Subject: [PATCH] app/testpmd: fix uninitialized members of MPLS [ upstream commit 56d5c1eedf22a1d384120466e6004faf9933d113 ] Some of the members of the MPLS struct are not initialized. This commit init the uninitialized members. Coverity issue: 325735 Fixes: 3e77031be855 ("app/testpmd: add MPLSoGRE encapsulation") Signed-off-by: Ori Kam Reviewed-by: Ferruh Yigit --- app/test-pmd/cmdline_flow.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index d1fd273272..daba39ddfc 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -3857,5 +3857,7 @@ parse_vc_action_mplsogre_decap(struct context *ctx, c= onst struct token *token, =09=09.protocol =3D rte_cpu_to_be_16(ETHER_TYPE_MPLS_UNICAST), =09}; -=09struct rte_flow_item_mpls mpls; +=09struct rte_flow_item_mpls mpls =3D { +=09=09.ttl =3D 0, +=09}; =09uint8_t *header; =09int ret; --=20 2.21.1 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092020-02-14 17:02:38.539444332 +0000 +++ 0027-app-testpmd-fix-uninitialized-members-of-MPLS.patch=092020-02-14 1= 7:02:36.997406978 +0000 @@ -1 +1 @@ -From 56d5c1eedf22a1d384120466e6004faf9933d113 Mon Sep 17 00:00:00 2001 +From 2f1a2defab638d4ead5d07720c488966608fafc2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 56d5c1eedf22a1d384120466e6004faf9933d113 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index e99e24c29f..c2cc4c57b8 100644 +index d1fd273272..daba39ddfc 100644 @@ -23 +24 @@ -@@ -4577,5 +4577,7 @@ parse_vc_action_mplsogre_encap(struct context *ctx, = const struct token *token, +@@ -3857,5 +3857,7 @@ parse_vc_action_mplsogre_decap(struct context *ctx, = const struct token *token,