From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F01ACA0553 for ; Mon, 17 Feb 2020 18:46:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E97721DA12; Mon, 17 Feb 2020 18:46:20 +0100 (CET) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 7ED991DA12 for ; Mon, 17 Feb 2020 18:46:19 +0100 (CET) Received: by mail-wm1-f65.google.com with SMTP id p17so197792wma.1 for ; Mon, 17 Feb 2020 09:46:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=THWhyKYLmlaTf0C3UMmg7ZKPaNHsjwZkCsjrirn2Hrk=; b=Zx/FWQWMagWOF9cCaqWViSvs934dJZtLBPN9IYQSP69NXNjfKyzAgCgtVYG4wvRiJQ q9dCSgLrZxakcPH6wjvnvpSWx1vntP3kycmUsgSkbAjpvkJAYaFpibtRiFm5efVpP2zA s15uDQlmHR+ZBK1IpmPzwLz4+oVo1mE8opS4lsV8WaTMpPR+Xyyyc050n+nGFjS1MyQw we1XEXhif6rXCsFldJp+7kSMMIHXJ2xqVTmdtMQUMLDyyABKcqQiJOe6qyysEaNFHXaQ 70MjDNqUgasf6c3Ii9Zs2i2kIPujUv+XJ/0g4NeCJYfvg7I0/K7f7G/Q/N2Qka9T2cBL 7Aog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=THWhyKYLmlaTf0C3UMmg7ZKPaNHsjwZkCsjrirn2Hrk=; b=AhJ0VBNFbWh5KSMDwhgt6BWhvPOSRqk8GcGaK9B7o4TmHMW1+YdBKJmFGSVvmB9chQ K6yP4/TvvE2hDlMQGxbDu8tTgPesaOTPT38lqNpDLBb+WIuaMhGVDcTbtOOJ1+ejgOdU in8QmeY6PkhJGRM6Y65Kr2tf6aphLrcJlKUKdmgapWuq8/AE2rxqtqEfmvbn/avPI5M3 JhtcUe/ly5sYvulQ1N6GxvPvhFkV/CYUugpcnZV66+0+KelfPPCR/ccAvIXYkipQGMuw 4Q7Qz1xCNE6qGqS/uDrr1PiN/4CGB2xSjNheSxH206PQVH8C4oGAhRfGMAnxDoaHHrxP gdEg== X-Gm-Message-State: APjAAAVeAHFjXJwIIdN4U9Vxm4jmLSnZdznJlK58mvSajLPO6MNMhCZW KUfZytl+ykDxAslBmzaOT0k= X-Google-Smtp-Source: APXvYqzQcJwZHwR0cv+8qJvcqwxfM0wvexUWfPR3DmVccTuqQ44eybgVH+gAW9KRKH+1cwguBSf2ZA== X-Received: by 2002:a7b:ce84:: with SMTP id q4mr139221wmj.57.1581961579250; Mon, 17 Feb 2020 09:46:19 -0800 (PST) Received: from localhost (userh634.uk.uudial.com. [194.69.103.7]) by smtp.gmail.com with ESMTPSA id y6sm2027057wrl.17.2020.02.17.09.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2020 09:46:18 -0800 (PST) From: luca.boccassi@gmail.com To: Kalesh AP Cc: Somnath Kotur , Ajit Khaparde , dpdk stable Date: Mon, 17 Feb 2020 17:45:10 +0000 Message-Id: <20200217174546.25334-18-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200217174546.25334-1-luca.boccassi@gmail.com> References: <20200211112216.3929-190-luca.boccassi@gmail.com> <20200217174546.25334-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bnxt: fix unnecessary delay in port stop' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/19/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From dc997c7fc2a0b857c2a6ffea0990a56a05366933 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Thu, 6 Feb 2020 22:03:08 +0530 Subject: [PATCH] net/bnxt: fix unnecessary delay in port stop [ upstream commit 967a722be08cacdd05e6a29d2e1790d5747a6217 ] VFs and multifunction PFs do not have the privilege to change link configuration. We force the physical link down as a part of device stop only for single physical function(SPF). This change also helps in eliminating the logs when a VF port is stopped: "Port 0: link state change event" "bnxt_print_link_info(): Port 0 Link Up - speed 25000 Mbps - full-duplex" Fixes: 316e412299fd ("net/bnxt: fix crash when closing") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index cfe3ac2c39..778bdf9367 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -934,9 +934,10 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev) bnxt_dev_set_link_down_op(eth_dev); /* Wait for link to be reset and the async notification to process. - * During reset recovery, there is no need to wait + * During reset recovery, there is no need to wait and + * VF/NPAR functions do not have privilege to change PHY config. */ - if (!is_bnxt_in_error(bp)) + if (!is_bnxt_in_error(bp) && BNXT_SINGLE_PF(bp)) bnxt_link_update(eth_dev, 1, ETH_LINK_DOWN); /* Clean queue intr-vector mapping */ -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-17 17:00:15.824206668 +0000 +++ 0018-net-bnxt-fix-unnecessary-delay-in-port-stop.patch 2020-02-17 17:00:15.291950228 +0000 @@ -1,8 +1,10 @@ -From 967a722be08cacdd05e6a29d2e1790d5747a6217 Mon Sep 17 00:00:00 2001 +From dc997c7fc2a0b857c2a6ffea0990a56a05366933 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Thu, 6 Feb 2020 22:03:08 +0530 Subject: [PATCH] net/bnxt: fix unnecessary delay in port stop +[ upstream commit 967a722be08cacdd05e6a29d2e1790d5747a6217 ] + VFs and multifunction PFs do not have the privilege to change link configuration. We force the physical link down as a part of device stop only for single physical function(SPF). @@ -14,7 +16,6 @@ "bnxt_print_link_info(): Port 0 Link Up - speed 25000 Mbps - full-duplex" Fixes: 316e412299fd ("net/bnxt: fix crash when closing") -Cc: stable@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur @@ -24,10 +25,10 @@ 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c -index c1cb40160b..537820960e 100644 +index cfe3ac2c39..778bdf9367 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c -@@ -948,9 +948,10 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev) +@@ -934,9 +934,10 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev) bnxt_dev_set_link_down_op(eth_dev); /* Wait for link to be reset and the async notification to process.